Unskip reject all tests (#1861)

* Try mocking geo cookie

* Pretend to be in Ireland instead of faking an ad-lite subscription

* Update page load functions

Author: emma-imber

playwright/lib/load-page.ts

@@ -30,6 +30,7 @@ const loadPage = async (page: Page, path: string, region = 'GB') => {
 const visitArticleNoOkta = async (
 	page: Page,
 	path = '/politics/2022/feb/10/keir-starmer-says-stop-the-war-coalition-gives-help-to-authoritarians-like-putin',
+	region = 'IE',
 ) => {
 	const fixture = {
 		config: {
@@ -46,7 +47,7 @@ const visitArticleNoOkta = async (
 		adtest: undefined,
 		fixture,
 	});
-	await loadPage(page, url);
+	await loadPage(page, url, region);
 };
 
 export { loadPage, visitArticleNoOkta };

playwright/lib/util.ts

@@ -111,61 +111,34 @@ const setupFakeLogin = async (
 	page: Page,
 	context: BrowserContext,
 	subscriber = true,
-	allowRejectAll = true,
 ) => {
 	const bodyOverride: UserFeaturesResponse = {
 		userId: '107421393',
 		digitalSubscriptionExpiryDate: '2999-01-01',
-		guardianAdLiteExpiryDate: '2999-01-01',
-		showSupportMessaging: true,
+		showSupportMessaging: false,
 		contentAccess: {
 			member: false,
 			paidMember: false,
 			recurringContributor: false,
 			digitalPack: true,
 			paperSubscriber: false,
 			guardianWeeklySubscriber: false,
-			guardianAdLite: true,
 		},
 	};
 
 	if (!subscriber) {
 		bodyOverride.contentAccess.digitalPack = false;
-		bodyOverride.showSupportMessaging = false;
 		delete bodyOverride.digitalSubscriptionExpiryDate;
 	}
 
-	// following the launch of consent or pay, an account is required to be able to reject all
-	if (allowRejectAll) {
-		const sevenDaysLater = new Date(Date.now() + 7 * 24 * 60 * 60 * 1000);
-
-		await context.addCookies([
-			{
-				name: 'GU_U',
-				value: 'WyIzMjc5Nzk0IiwiIiwiSmFrZTkiLCIiLDE2NjA4MzM3NTEyMjcsMCwxMjEyNjgzMTQ3MDAwLHRydWVd.MC0CFQCIbpFtd0J5IqK946U1vagzLgCBkwIUUN3UOkNfNN8jwNE3scKfrcvoRSg',
-				domain: 'localhost',
-				path: '/',
-			},
-			{
-				name: 'gu_allow_reject_all',
-				value: sevenDaysLater.getTime().toString(),
-				domain: 'localhost',
-				path: '/',
-			},
-			{
-				name: 'gu_hide_support_messaging',
-				value: sevenDaysLater.getTime().toString(),
-				domain: 'localhost',
-				path: '/',
-			},
-			{
-				name: 'gu_user_benefits_expiry',
-				value: sevenDaysLater.getTime().toString(),
-				domain: 'localhost',
-				path: '/',
-			},
-		]);
-	}
+	await context.addCookies([
+		{
+			name: 'GU_U',
+			value: 'WyIzMjc5Nzk0IiwiIiwiSmFrZTkiLCIiLDE2NjA4MzM3NTEyMjcsMCwxMjEyNjgzMTQ3MDAwLHRydWVd.MC0CFQCIbpFtd0J5IqK946U1vagzLgCBkwIUUN3UOkNfNN8jwNE3scKfrcvoRSg',
+			domain: 'localhost',
+			path: '/',
+		},
+	]);
 
 	await page.route(
 		'https://members-data-api.theguardian.com/user-attributes/me**',
@@ -176,15 +149,6 @@ const setupFakeLogin = async (
 		},
 		{ times: 1 },
 	);
-
-	await page.route(
-		'https://user-benefits.guardianapis.com/benefits/me**',
-		(route) => {
-			return route.fulfill({
-				body: JSON.stringify(['allowRejectAll']),
-			});
-		},
-	);
 };
 
 // Playwright does not currently have a useful method for removing a cookie, so this workaround is needed.

playwright/tests/consent.spec.ts

@@ -42,14 +42,10 @@ test.describe('tcfv2 consent', () => {
 		await adSlotsAreFulfilled(page);
 	});
 
-	test.skip(`Reject all, load Opt Out, ad slots are present`, async ({
-		page,
-		context,
-	}) => {
-		// After consent or pay, we need to be logged in and mock an ad-lite subscription to be able to reject all
-		await setupFakeLogin(page, context, false, true);
-
-		await visitArticleNoOkta(page);
+	test(`Reject all, load Opt Out, ad slots are present`, async ({ page }) => {
+		// if we pretend to be in Ireland, we can reject all and see opt out ads
+		// without needing to fake logging into an ad-lite account
+		await loadPage(page, path, 'IE');
 
 		const optOutPromise = waitForOptOut(page);
 
@@ -60,16 +56,18 @@ test.describe('tcfv2 consent', () => {
 		await adSlotsArePresent(page);
 	});
 
-	test.skip(`Login as subscriber, reject all, load Opt Out, ad slots are not present on multiple page loads`, async ({
+	test(`Login as subscriber, reject all, load Opt Out, ad slots are not present on multiple page loads`, async ({
 		page,
 		context,
 	}) => {
-		await setupFakeLogin(page, context, true, true);
+		await setupFakeLogin(page, context, true);
 
 		await visitArticleNoOkta(page);
 
 		const optOutPromise = waitForOptOut(page);
+
 		await cmpRejectAll(page);
+
 		await optOutPromise;
 
 		await visitArticleNoOkta(page);
@@ -85,14 +83,12 @@ test.describe('tcfv2 consent', () => {
 		await adSlotsAreNotPresent(page);
 	});
 
-	test.skip(`Reject all, ad slots are fulfilled, then accept all, ad slots are fulfilled`, async ({
+	test(`Reject all, ad slots are fulfilled, then accept all, ad slots are fulfilled`, async ({
 		page,
-		context,
 	}) => {
-		// After consent or pay, we need to be logged in and mock an ad-lite subscription to be able to reject all
-		await setupFakeLogin(page, context, false, true);
-
-		await visitArticleNoOkta(page);
+		// if we pretend to be in Ireland, we can reject all and see opt out ads
+		// without needing to fake logging into an ad-lite account
+		await loadPage(page, path, 'IE');
 
 		const optOutPromise = waitForOptOut(page);
 
@@ -111,7 +107,7 @@ test.describe('tcfv2 consent', () => {
 		page,
 		context,
 	}) => {
-		await setupFakeLogin(page, context, true, false);
+		await setupFakeLogin(page, context, true);
 
 		await visitArticleNoOkta(page);
 
@@ -131,7 +127,7 @@ test.describe('tcfv2 consent', () => {
 		page,
 		context,
 	}) => {
-		await setupFakeLogin(page, context, true, true);
+		await setupFakeLogin(page, context, true);
 
 		await visitArticleNoOkta(page);
 
@@ -148,18 +144,16 @@ test.describe('tcfv2 consent', () => {
 		await adSlotsArePresent(page);
 	});
 
-	test.skip(`Reject all, ad slots are present, accept all, page refreshes, ad slots are fulfilled`, async ({
+	test(`Reject all, ad slots are present, accept all, page refreshes, ad slots are fulfilled`, async ({
 		page,
-		context,
 	}) => {
-		// After consent or pay, we need to be logged in and mock an ad-lite subscription to be able to reject all
-		await setupFakeLogin(page, context, false, true);
-
-		await visitArticleNoOkta(page);
+		// if we pretend to be in Ireland, we can reject all and see opt out ads
+		// without needing to fake logging into an ad-lite account
+		await loadPage(page, path, 'IE');
 
 		await cmpRejectAll(page);
 
-		await visitArticleNoOkta(page);
+		await loadPage(page, path, 'IE');
 
 		await adSlotsArePresent(page);
 

src/types/membership.ts

@@ -14,7 +14,6 @@ export type UserFeaturesResponse = {
 	paperSubscriptionExpiryDate?: LocalDate;
 	guardianWeeklyExpiryDate?: LocalDate;
 	liveAppSubscriptionExpiryDate?: LocalDate;
-	guardianAdLiteExpiryDate?: LocalDate;
 	alertAvailableFor?: string;
 
 	showSupportMessaging: boolean;
@@ -26,6 +25,5 @@ export type UserFeaturesResponse = {
 		digitalPack: boolean;
 		paperSubscriber: boolean;
 		guardianWeeklySubscriber: boolean;
-		guardianAdLite: boolean;
 	};
 };