Bump to @guardian/cql 1.3.5 to ensure content pasted into chip values is correctly quoted

Author: jonathonherbert

kahuna/package-lock.json

@@ -1,7 +1,7 @@
 {
   "dependencies": {
     "@babel/polyfill": "^7.8.7",
-    "@guardian/cql": "^1.3.4",
+    "@guardian/cql": "^1.3.5",
     "@guardian/user-telemetry-client": "^1.1.0",
     "@sentry/browser": "^6.10.0",
     "@sentry/integrations": "^6.10.0",
@@ -75,7 +75,7 @@
     "webpack-merge": "^5.8.0"
   },
   "scripts": {
-    "test": "npm run lint && jest --coverage",
+    "test": "jest --coverage",
     "lint": "eslint public/js && htmllint public/js/**/*.html",
     "lint-fix": "eslint public/js --fix && htmllint public/js/**/*.html",
     "dist": "webpack --config webpack.config.prod.js",

kahuna/package.json

@@ -10,6 +10,11 @@ const queries = [
     cql: "text",
     structuredQuery: [{ type: "text", value: "text" }]
   },
+  {
+    name: "an empty chip",
+    cql: "+:",
+    structuredQuery: []
+  },
   {
     name: "a single chip",
     cql: "has:chip",
@@ -87,6 +92,18 @@ const queries = [
       },
       { type: "text", value: "more text" }
     ]
+  },
+  {
+    name: "chips with quoted keys",
+    cql: `category:"PR Image"`,
+    structuredQuery: [
+      {
+        filterType: "inclusion",
+        key: "category",
+        type: "filter",
+        value: "PR Image"
+      }
+    ]
   }
 ];
 

kahuna/public/js/components/gr-cql-input/syntax.spec.ts

@@ -53,6 +53,10 @@ const structuredQueryFromField = ({
   key: { literal, tokenType },
   value
 }: CqlField): StructuredQuery => {
+  if (!literal) {
+    return [];
+  }
+
   const type = literal === "collection" ? "static-filter" : "filter";
   const filterType =
     tokenType === "CHIP_KEY_NEGATIVE" ? "exclusion" : "inclusion";