Skip to content

Commit 516b04b

Browse files
author
Joseph Smith
committed
Add logging
1 parent 22c6c4d commit 516b04b

1 file changed

Lines changed: 15 additions & 2 deletions

File tree

media-api/app/lib/elasticsearch/ElasticSearch.scala

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import com.gu.mediaservice.lib.argo.model.{ExtraCount, ExtraCountConfig, ExtraCo
66
import com.gu.mediaservice.lib.elasticsearch.filters
77
import com.gu.mediaservice.lib.auth.Authentication.Principal
88
import com.gu.mediaservice.lib.elasticsearch.{CompletionPreview, ElasticSearchClient, ElasticSearchConfig, MigrationStatusProvider, Running}
9-
import com.gu.mediaservice.lib.logging.{GridLogging, LogMarker, MarkerMap}
9+
import com.gu.mediaservice.lib.logging.{GridLogging, LogMarker, MarkerMap, Stopwatch, combineMarkers}
1010
import com.gu.mediaservice.lib.metrics.FutureSyntax
1111
import com.gu.mediaservice.model.{Agencies, Agency, AwaitingReviewForSyndication, Image}
1212
import com.sksamuel.elastic4s.{ElasticDsl, Hit}
@@ -372,15 +372,28 @@ class ElasticSearch(
372372
} else {
373373
val queryEmbeddingDouble: List[Double] = queryEmbedding.map(_.toDouble)
374374

375+
val stopwatch = Stopwatch.start
376+
375377
if (fillScores) {
376-
fillScoresSearch(query, queryEmbeddingDouble, k, numCandidates, vecWeight, filterOpt)
378+
val searchResults = fillScoresSearch(query, queryEmbeddingDouble, k, numCandidates, vecWeight, filterOpt)
379+
val elapsed = stopwatch.elapsed
380+
logger.info(
381+
combineMarkers(logMarker, elapsed),
382+
s"hybrid search (fill scores) completed in ${elapsed.toMillis} ms"
383+
)
384+
searchResults
377385
} else {
378386
for {
379387
maxScore <- fetchMaxBm25Score(query, filterOpt)
380388
searchRequest = makeHybridSearchRequest(query, queryEmbeddingDouble, k, numCandidates, vecWeight, maxScore, filterOpt)
381389
result <- executeAndLog(withSearchQueryTimeout(searchRequest), "hybrid search")
382390
} yield {
383391
val imageHits = result.result.hits.hits.map(resolveHit).toSeq.flatten.map(i => (i.instance.id, i))
392+
val elapsed = stopwatch.elapsed
393+
logger.info(
394+
combineMarkers(logMarker, elapsed),
395+
s"hybrid search (current) completed in ${elapsed.toMillis} ms"
396+
)
384397
SearchResults(hits = imageHits, total = imageHits.length, extraCounts = None)
385398
}
386399
}

0 commit comments

Comments
 (0)