Skip to content

Commit ac1ad44

Browse files
committed
feat(report): Remove VPCSecurityGroup from EC2 instances
The `VPCSecurityGroup` group allows ingress and egress to/from 0.0.0.0/0 on all protocols and ports. The ASG is configured to launch instances in the VPC's private subnets (i.e. not routable from the internet) and the launch template explicitly sets `AssociatePublicIpAddress` to false. That is, there is no route from 0.0.0.0/0 to the EC2 instance; `VPCSecurityGroup` being attached to the EC2 instance has no effect and can be removed.
1 parent e4d672b commit ac1ad44

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

report/conf/report.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ Parameters:
3636
- CODE
3737
- PROD
3838
Description: Environment name
39-
VPCSecurityGroup:
40-
Type: AWS::EC2::SecurityGroup::Id
41-
Description: The default security group of the VPC
4239
VpcId:
4340
Type: AWS::EC2::VPC::Id
4441
Description: The VPC
@@ -268,7 +265,6 @@ Resources:
268265
InstanceType: !FindInMap [StageVariables, !Ref Stage, InstanceType]
269266
SecurityGroups:
270267
- !Ref InstanceSecurityGroup
271-
- !Ref VPCSecurityGroup
272268
MetadataOptions:
273269
HttpTokens: required
274270
UserData:

0 commit comments

Comments
 (0)