Replace + with Plus for Newspaper package names in new-product-api (#3318)

* Replace + with Plus for paper package names

* Fix paper package name by replacing '+' with 'Plus'

Author: graham228221

handlers/new-product-api/src/main/scala/com/gu/newproduct/api/addsubscription/email/serialisers/PaperEmailFields.scala

@@ -34,7 +34,7 @@ object PaperEmailFields {
       "IncludesDigipack" -> digipackPlans.contains(data.plan.id).toString,
       "date_of_first_paper" -> data.firstPaperDate.format(dateformat),
       "date_of_first_payment" -> data.firstPaymentDate.format(dateformat),
-      "package" -> data.plan.description.value,
+      "package" -> data.plan.description.value.replace("+", "Plus"),
       "subscription_rate" -> data.discountMessage
         .map(_.value)
         .getOrElse(data.plan.paymentPlans.get(data.currency).map(_.description).getOrElse("")),

handlers/new-product-api/src/test/scala/com/gu/newproduct/api/addsubscription/email/paper/PaperEmailDataTest.scala

@@ -116,7 +116,7 @@ class PaperEmailDataTest extends AnyFlatSpec with Matchers {
         |  "IncludesDigipack" : "true",
         |  "date_of_first_paper" : "1 November 2018",
         |  "date_of_first_payment" : "1 December 2018",
-        |  "package" : "Everyday+",
+        |  "package" : "EverydayPlus",
         |  "subscription_rate" : "GBP 12.25 every month",
         |  "bank_account_no" : "*****mask",
         |  "bank_sort_code" : "12-34-56",
@@ -160,7 +160,7 @@ class PaperEmailDataTest extends AnyFlatSpec with Matchers {
         |  "IncludesDigipack" : "true",
         |  "date_of_first_paper" : "1 November 2018",
         |  "date_of_first_payment" : "1 December 2018",
-        |  "package" : "Everyday+",
+        |  "package" : "EverydayPlus",
         |  "subscription_rate" : "GBP 10.00 for first 2 months , then GBP 12.25 every 12 months",
         |  "bank_account_no" : "*****mask",
         |  "bank_sort_code" : "12-34-56",