Merge pull request #15 from gugahoi/fix/completion-project-id

fix(completion): do not require project for completion command

Author: gugahoi

pkg/cmd/root.go

@@ -22,6 +22,10 @@ var rootCmd = &cobra.Command{
 	Short:        "perform actions on firestore",
 	SilenceUsage: true,
 	PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
+		if isCompletionCommand(cmd) {
+			return nil
+		}
+
 		if projectId == "" {
 			envValue := os.Getenv("PROJECT_ID")
 			if envValue == "" {
@@ -48,6 +52,16 @@ var rootCmd = &cobra.Command{
 	},
 }
 
+func isCompletionCommand(cmd *cobra.Command) bool {
+	for cmd != nil {
+		if cmd.Name() == "completion" || cmd.Name() == cobra.ShellCompRequestCmd {
+			return true
+		}
+		cmd = cmd.Parent()
+	}
+	return false
+}
+
 // Execute adds all child commands to the root command and sets flags appropriately.
 // This is called by main.main(). It only needs to happen once to the rootCmd.
 func Execute() {