diff --git a/NEWS.md b/NEWS.md index 622dcff..f3b9fdd 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,3 @@ # shinyfaithful (development version) -* Initial CRAN submission. +* Duplicated histogram (#1). diff --git a/R/app_server.R b/R/app_server.R index da78de0..68a0183 100644 --- a/R/app_server.R +++ b/R/app_server.R @@ -6,5 +6,6 @@ #' @noRd app_server <- function(input, output, session) { # Your application server logic - mod_faithful_hist_server("hist") + mod_faithful_hist_server("hist-waiting", variable = "waiting") + mod_faithful_hist_server("hist-eruptions", variable = "eruptions") } diff --git a/R/app_ui.R b/R/app_ui.R index 83966d6..aac8e6a 100644 --- a/R/app_ui.R +++ b/R/app_ui.R @@ -11,7 +11,8 @@ app_ui <- function(request) { # Your application UI logic fluidPage( h1("Old Faithful Geyser - Hist"), - mod_faithful_hist_ui("hist") + mod_faithful_hist_ui("hist-waiting"), + mod_faithful_hist_ui("hist-eruptions") ) ) } diff --git a/R/mod_faithful_hist.R b/R/mod_faithful_hist.R index b8b2443..a79ad0b 100644 --- a/R/mod_faithful_hist.R +++ b/R/mod_faithful_hist.R @@ -28,13 +28,14 @@ mod_faithful_hist_ui <- function(id) { } #' @rdname mod_faithful_hist +#' @param variable character column name of faithful data #' #' @import shiny -mod_faithful_hist_server <- function(id){ +mod_faithful_hist_server <- function(id, variable){ moduleServer( id, function(input, output, session){ ns <- session$ns # generate bins based on input$bins from ui.R - variable <- "waiting" + # variable <- "waiting" x <- datasets::faithful[, variable, drop = FALSE] bins <- reactive(seq(min(x), max(x), length.out = input$bins + 1)) diff --git a/man/mod_faithful_hist.Rd b/man/mod_faithful_hist.Rd index 29124d2..0fd04a4 100644 --- a/man/mod_faithful_hist.Rd +++ b/man/mod_faithful_hist.Rd @@ -8,10 +8,12 @@ \usage{ mod_faithful_hist_ui(id) -mod_faithful_hist_server(id) +mod_faithful_hist_server(id, variable) } \arguments{ \item{id}{Internal parameter for {shiny}.} + +\item{variable}{character column name of faithful data} } \description{ UI and server function for an example Shiny module.