fix(admin): subscriptions page hid all subs; transactions leaked i18n key (#307)

Two defects surfaced while QA-testing admin analytics (#289).

Subscriptions list (`/dashboard/admin/subscriptions`):
- The PostgREST embed selected `plans(... duration_type)`, but `plans` has
  no `duration_type` column (it's `duration_in_days`). The whole query
  errored with `42703 column plans_1.duration_type does not exist`, the
  error was swallowed, `subscriptions` came back null, and the page showed
  "0 active / No subscriptions yet" — hiding every real subscription.
- Switch the select to `duration_in_days` and render a period label
  (month / year / N days) instead of the missing `duration_type`.
- Drop a stray double colon in the Renews/Ended label (keys already end
  with `:`).

Transactions table (`/dashboard/admin/transactions`):
- Payment method used `t(\`table.methods.${pm}\`) || pm`, but next-intl
  returns the full key PATH on a miss (truthy), so the `|| pm` fallback was
  dead code. Free-form methods like "manual - Bank Transfer" leaked
  `dashboard.admin.transactions.table.methods.manual - Bank Transfer` into
  the UI. Guard with `t.has()` and fall back to the raw value.

Adds en/es keys: subscriptions.table.perMonth/perYear/perDays.

Note: the unused `getSubscriptionDetails()` action carries the same
`duration_type` reference (plus a non-existent `profiles.email`); left as-is
since it's dead code, but it must be corrected before it's ever wired up.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: guillermoscript

app/[locale]/dashboard/admin/subscriptions/page.tsx

@@ -39,6 +39,14 @@ export default async function SubscriptionsPage({
   const dateLocale = locale === 'es' ? es : enUS
   const supabase = createAdminClient()
 
+  // plans stores billing period as duration_in_days (no duration_type column);
+  // map the common cadences to a label and fall back to a day count.
+  const periodLabel = (days?: number | null) => {
+    if (days === 30) return t('table.perMonth')
+    if (days === 365) return t('table.perYear')
+    return days ? t('table.perDays', { count: days }) : ''
+  }
+
   const userId = await getCurrentUserId()
   if (!userId) {
     redirect('/auth/login')
@@ -77,7 +85,7 @@ export default async function SubscriptionsPage({
         plan_name,
         price,
         currency,
-        duration_type
+        duration_in_days
       )
     `
     )
@@ -306,7 +314,7 @@ export default async function SubscriptionsPage({
                                 <span className="flex items-center gap-1">
                                   <IconCurrencyDollar className="h-4 w-4" />
                                   {plan?.currency} {plan?.price?.toFixed(2)}/
-                                  {plan?.duration_type}
+                                  {periodLabel(plan?.duration_in_days)}
                                 </span>
                                 <span className="flex items-center gap-1">
                                   <IconCalendar className="h-4 w-4" />
@@ -316,7 +324,7 @@ export default async function SubscriptionsPage({
                                 {subscription.current_period_end && (
                                   <span className="flex items-center gap-1">
                                     <IconCalendar className="h-4 w-4" />
-                                    {isCancelled ? t('table.ended') : t('table.renews')}:{' '}
+                                    {isCancelled ? t('table.ended') : t('table.renews')}{' '}
                                     {format(new Date(subscription.current_period_end), 'MMM d, yyyy', { locale: dateLocale })}
                                   </span>
                                 )}

app/[locale]/dashboard/admin/transactions/page.tsx

@@ -206,7 +206,11 @@ export default async function AdminTransactionsPage({
                             </Badge>
                           </td>
                           <td className="px-4 py-3 text-xs text-muted-foreground">
-                            {transaction.payment_method ? (t(`table.methods.${transaction.payment_method}`) || transaction.payment_method) : t('table.notAvailable')}
+                            {transaction.payment_method
+                              ? (t.has(`table.methods.${transaction.payment_method}`)
+                                  ? t(`table.methods.${transaction.payment_method}`)
+                                  : transaction.payment_method)
+                              : t('table.notAvailable')}
                           </td>
                           <td className="px-4 py-3 text-xs tabular-nums text-muted-foreground">
                             {format(new Date(transaction.transaction_date), 'MMM d, yyyy HH:mm', { locale: dateLocale })}

docs/screenshots/admin-analytics-289.gif

@@ -1963,6 +1963,9 @@
           "started": "Started:",
           "ended": "Ended:",
           "renews": "Renews:",
+          "perMonth": "month",
+          "perYear": "year",
+          "perDays": "{count} days",
           "noSubscriptions": "No subscriptions yet",
           "noFilteredSubscriptions": "No subscriptions found matching your filters"
         },

messages/en.json

@@ -1959,6 +1959,9 @@
           "started": "Iniciado:",
           "ended": "Finalizado:",
           "renews": "Renueva:",
+          "perMonth": "mes",
+          "perYear": "año",
+          "perDays": "{count} días",
           "noSubscriptions": "Aún no hay suscripciones",
           "noFilteredSubscriptions": "No se encontraron suscripciones que coincidan con tus filtros"
         },