fix(payments): categorize binance_enabled under Payment settings, not general (#479) (#490)

getAllSettingsByCategory()'s categoryMap had no entry for binance_enabled,
so it fell through to 'general' instead of 'payment'. The admin Settings >
Payment page reads settings.payment.binance_enabled to set the Binance Pay
switch's initial state, so the toggle always rendered unchecked on reload
regardless of the saved value — an admin who enabled it would see it off on
next visit, and re-saving from that state would silently disable it in the
DB. getEnabledPaymentProviders() (used by checkout/product forms) queries
the key directly and was unaffected.


Claude-Session: https://claude.ai/code/session_01UYWqTKnHDLQC1hbithnsb3

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Author: guillermoscript

app/actions/admin/settings.ts

@@ -35,7 +35,7 @@ export async function getSettings(category?: string): Promise<SettingsResponse>
       const categoryPrefixes: Record<string, string[]> = {
         general: ['site_name', 'site_description', 'contact_email', 'support_email', 'timezone', 'maintenance_mode'],
         email: ['smtp_', 'email_'],
-        payment: ['stripe_', 'paypal_', 'lemonsqueezy_', 'solana_', 'currency', 'tax_rate', 'invoice_prefix', 'require_payment_approval', 'manual_payment_instructions'],
+        payment: ['stripe_', 'paypal_', 'lemonsqueezy_', 'solana_', 'binance_', 'currency', 'tax_rate', 'invoice_prefix', 'require_payment_approval', 'manual_payment_instructions'],
         enrollment: ['auto_enrollment', 'require_enrollment_approval', 'max_enrollments_per_user', 'allow_self_enrollment', 'enrollment_expiration_days', 'course_capacity_enabled'],
       }
       const keys = categoryPrefixes[category]
@@ -440,7 +440,7 @@ export async function getAllSettingsByCategory(): Promise<SettingsResponse> {
       smtp_host: 'email', smtp_port: 'email', smtp_username: 'email', smtp_password: 'email',
       smtp_from_email: 'email', smtp_from_name: 'email', email_notifications: 'email',
       stripe_enabled: 'payment', paypal_enabled: 'payment',
-      lemonsqueezy_enabled: 'payment', solana_enabled: 'payment', solana_accept_sol: 'payment', currency: 'payment',
+      lemonsqueezy_enabled: 'payment', solana_enabled: 'payment', solana_accept_sol: 'payment', binance_enabled: 'payment', currency: 'payment',
       tax_rate: 'payment', invoice_prefix: 'payment', require_payment_approval: 'payment',
       manual_payment_instructions: 'payment',
       auto_enrollment: 'enrollment', require_enrollment_approval: 'enrollment',

tests/unit/admin-settings-category-map.test.ts

@@ -0,0 +1,62 @@
+import { describe, it, expect, beforeEach, vi } from 'vitest'
+
+/**
+ * Regression for issue #479: getAllSettingsByCategory()'s categoryMap
+ * previously had no entry for `binance_enabled`, so it fell through to the
+ * `'general'` bucket instead of `'payment'`. The admin Settings > Payment
+ * page reads `settings.payment.binance_enabled` — a missing map entry made
+ * the Binance Pay toggle always render unchecked on reload regardless of the
+ * saved value, even though getEnabledPaymentProviders() (which queries the
+ * key directly) still gated checkout/product forms correctly.
+ */
+
+const state: {
+  role: string
+  rows: { setting_key: string; setting_value: unknown }[]
+} = { role: 'admin', rows: [] }
+
+function makeFakeAdmin() {
+  const b: Record<string, unknown> = {
+    from() { return b },
+    select() { return b },
+    eq() { return b },
+    order() { return Promise.resolve({ data: state.rows, error: null }) },
+  }
+  return b
+}
+
+vi.mock('next/cache', () => ({ revalidatePath: vi.fn() }))
+vi.mock('@/lib/supabase/tenant', () => ({ getCurrentTenantId: () => Promise.resolve('t1') }))
+vi.mock('@/lib/supabase/get-user-role', () => ({ getUserRole: () => Promise.resolve(state.role) }))
+vi.mock('@/lib/supabase/admin', () => ({
+  createAdminClient: () => makeFakeAdmin(),
+}))
+
+import { getAllSettingsByCategory } from '@/app/actions/admin/settings'
+
+beforeEach(() => { state.role = 'admin'; state.rows = [] })
+
+describe('getAllSettingsByCategory', () => {
+  it('groups binance_enabled under payment, not general', async () => {
+    state.rows = [{ setting_key: 'binance_enabled', setting_value: { enabled: true } }]
+    const r = await getAllSettingsByCategory()
+    expect(r.success).toBe(true)
+    expect(r.data?.payment?.binance_enabled?.value?.enabled).toBe(true)
+    expect(r.data?.general?.binance_enabled).toBeUndefined()
+  })
+
+  it('keeps every other payment toggle categorized alongside it', async () => {
+    state.rows = [
+      { setting_key: 'stripe_enabled', setting_value: { enabled: true } },
+      { setting_key: 'paypal_enabled', setting_value: { enabled: false } },
+      { setting_key: 'lemonsqueezy_enabled', setting_value: { enabled: false } },
+      { setting_key: 'solana_enabled', setting_value: { enabled: false } },
+      { setting_key: 'binance_enabled', setting_value: { enabled: true } },
+    ]
+    const r = await getAllSettingsByCategory()
+    const paymentKeys = Object.keys(r.data?.payment ?? {})
+    expect(paymentKeys.sort()).toEqual(
+      ['binance_enabled', 'lemonsqueezy_enabled', 'paypal_enabled', 'solana_enabled', 'stripe_enabled'].sort()
+    )
+  })
+})