Commit fed4366
Merge master into fix/submission-grader-grading-states-567
#578 (widget i18n/colour semantics) and #575 (missing-data display) both
rewrote submission-grader/widget.tsx, so every hunk of this branch
conflicted. Resolved by resetting the file to master and re-applying the
#567 fix on top of the new structure rather than reconciling markers.
What changed in the re-application:
- The three new affordances are now translated. "Not graded",
"Teacher adjusted", the low-confidence pill and the ungraded-points note
all have en/es entries in this widget's STRINGS table, matching #578's
convention; a missing Spanish string is a type error.
- The em dash for an ungraded question is no longer hand-written.
fmt.number() from shared/i18n.tsx already renders null as an em dash, so
dropping the `?? 0` is now the entire fix at that call site and the
dash follows the reader's locale like every other number.
- Points and confidence go through fmt.number/fmt.percent, so es renders
"confianza: 41 %" rather than a hardcoded English percentage.
master's own shared/severity.ts landed the same rule this issue is about —
"a draft course with no lessons has nothing to complete (neutral); a
student who has completed nothing is at 0% and that is the worst case" —
and #575 applied it to the roster while leaving `points_earned ?? 0` in
this widget untouched. The re-applied fix is that doctrine reaching the
per-question list, and isUngraded() now cites it.
Kept from master unchanged: the inline "(82% confidence)" suffix for a
confident score, so only a guess is promoted to a pill.
Verified after the merge: mcp-server tsc --noEmit clean (the 4 pre-existing
useCallTool errors this branch flagged are gone — master fixed them),
66/66 mcp-server tests, and the demo fixture re-shot in dark, light and es.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Zt1kZKdcWAcsiJdBgnX3D80 files changed
Lines changed: 3642 additions & 589 deletions
File tree
- app/[locale]
- components
- tenant
- docs
- qa
- 568
- 569
- 577
- screenshots
- lib
- color
- puck
- components
- layout
- lms
- primitives
- utils
- sentry
- mcp-server
- docs
- resources
- course-catalog
- course-dashboard
- course-detail
- exam-readiness
- exam-submissions
- gamification-profile
- landing-page-preview
- my-exam-results
- my-learning
- practice-player
- school-overview
- student-progress-roster
- study-plan
- submission-grader
- src
- tools
- tests
- messages
- tests/unit
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
170 | 171 | | |
171 | 172 | | |
172 | 173 | | |
| 174 | + | |
173 | 175 | | |
174 | 176 | | |
175 | 177 | | |
| |||
0 commit comments