Cleaned up strings

Author: gustavkarlsson

src/main/java/se/gustavkarlsson/rocketchat/jira_trigger/configuration/EnvVarConfigMap.java

@@ -57,7 +57,7 @@ public Boolean getBoolean(String key) {
 					} else if (string.equalsIgnoreCase("false")) {
 						return false;
 					} else {
-						throw new IllegalStateException("'" + string + "' could not be parsed to a boolean value");
+						throw new IllegalStateException(String.format("'%s' could not be parsed to a boolean value", string));
 					}
 				})
 				.orElse(null);

src/main/java/se/gustavkarlsson/rocketchat/jira_trigger/jira/AuthHandlerProvider.java

@@ -55,7 +55,7 @@ private String readPassword(String username) {
 		if (console == null) {
 			throw new IllegalStateException("No console available for password input");
 		}
-		char[] password = console.readPassword("Enter JIRA password for user " + username + ": ");
+		char[] password = console.readPassword(String.format("Enter JIRA password for user %s: ", username));
 		return new String(password);
 	}
 }

src/main/java/se/gustavkarlsson/rocketchat/jira_trigger/routes/DetectIssueRoute.java

@@ -74,7 +74,7 @@ protected ToRocketChatMessage handle(Request request, Response response, FromRoc
 		log.debug("Issues: {}", issues.stream().map(Issue::getId).collect(toList()));
 		log.debug("Creating message");
 		ToRocketChatMessage message = messageFactory.create();
-		message.setText(issues.size() == 1 ? "Found 1 issue" : "Found " + issues.size() + " issues");
+		message.setText(issues.size() == 1 ? "Found 1 issue" : String.format("Found %d issues", issues.size()));
 		List<ToRocketChatAttachment> attachments = createAttachments(issues);
 		message.setAttachments(attachments);
 		return message;