Skip to content

nix-info from CI #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gustavo-grieco wants to merge 1 commit into from
Closed

nix-info from CI #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ jobs:

- name: Build dynamic echidna
run: |
nix-shell -p nix-info --run "nix-info -m"
false
Comment on lines +61 to +62
Copy link

@coderabbitai coderabbitai bot Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

❓ Verification inconclusive

Avoid unconditionally failing the build step
The false on line 62 causes this step (and the entire job) to always error out before nix build ever runs—no artifact is produced and downstream releases are blocked. If your goal is merely to capture Nix diagnostics without breaking CI, consider either:

  • Removing false and appending || true to the nix-shell invocation, or
  • Splitting into two steps: run nix-info in a separate step with continue-on-error: true, then run nix build in the next step.
@@ -59,7 +59,12 @@ jobs:
-      - name: Build dynamic echidna
-        run: |
-          nix-shell -p nix-info --run "nix-info -m"
-          false
-          nix build .#echidna
+      - name: Emit Nix environment info
+        continue-on-error: true
+        run: nix-shell -p nix-info --run "nix-info -m"
+
+      - name: Build dynamic echidna
+        run: nix build .#echidna

Split Nix diagnostics from the build to avoid unconditional failure

The false on line 62 forces this step (and the entire job) to error out before nix build ever runs—no artifact is produced and downstream releases are blocked. Separate diagnostics from the build so that Nix info can be emitted without breaking CI, then run the build in a second step.

Files to update:

  • .github/workflows/release.yml (around lines 59–67)

Proposed diff:

@@ -59,7 +59,12 @@ jobs:
-      - name: Build dynamic echidna
-        run: |
-          nix-shell -p nix-info --run "nix-info -m"
-          false
-          nix build .#echidna
+      - name: Emit Nix environment info
+        continue-on-error: true
+        run: nix-shell -p nix-info --run "nix-info -m"
+
+      - name: Build dynamic echidna
+        run: nix build .#echidna
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
nix-shell -p nix-info --run "nix-info -m"
false
- name: Emit Nix environment info
continue-on-error: true
run: nix-shell -p nix-info --run "nix-info -m"
- name: Build dynamic echidna
run: nix build .#echidna
🤖 Prompt for AI Agents 
In .github/workflows/release.yml around lines 61 to 62, the presence of `false`
causes the step to always fail, preventing the build from running and blocking
downstream releases. To fix this, remove the `false` command and either append
`|| true` to the `nix-shell` command to allow it to fail without breaking the
job, or split this into two separate steps: one to run `nix-info` with
`continue-on-error: true` and another to run the actual `nix build`. This
separation ensures diagnostics run without stopping the build process.

nix build .#echidna

- name: Build redistributable echidna
Expand Down
Loading