fix(breakout): spawn buttons centred and non-overlapping

New breakout buttons defaulted to a fixed position and stacked on top of
each other, forcing the user to drag every newly-enabled button into place.

Keep an internal registry of each shown breakout button's live rect. When a
button first appears without a saved position, place it in the middle of the
screen and cascade it until it clears every other breakout button, so they
can't spawn overlapping. Saved positions are still restored as before.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: GWToolbox Bot

GWToolboxdll/ToolboxUIElement.cpp

@@ -597,13 +597,54 @@ void ToolboxUIElement::ShowVisibleRadio()
     ImGui::PopID();
 }
 
+namespace {
+    // Live rects of currently-shown breakout buttons, keyed by their ImGui window id.
+    // Lets a newly-shown button pick a spot near the screen centre that doesn't overlap the others.
+    std::unordered_map<std::string, ImRect> breakout_button_rects;
+
+    bool BreakoutRectsOverlap(const ImRect& a, const ImRect& b)
+    {
+        return a.Min.x < b.Max.x && a.Max.x > b.Min.x && a.Min.y < b.Max.y && a.Max.y > b.Min.y;
+    }
+
+    // Pick a position starting from the centre of the screen, cascading until it clears every other breakout button.
+    ImVec2 GetDefaultBreakoutPos(const char* window_id, const ImVec2& size)
+    {
+        const ImGuiViewport* vp = ImGui::GetMainViewport();
+        const ImVec2 start = {vp->WorkPos.x + (vp->WorkSize.x - size.x) * 0.5f, vp->WorkPos.y + (vp->WorkSize.y - size.y) * 0.5f};
+        const ImVec2 max = {vp->WorkPos.x + vp->WorkSize.x, vp->WorkPos.y + vp->WorkSize.y};
+        ImVec2 pos = start;
+        for (int i = 0; i < 256; i++) {
+            const ImRect candidate = {pos, {pos.x + size.x, pos.y + size.y}};
+            bool overlaps = false;
+            for (const auto& [id, rect] : breakout_button_rects) {
+                if (id != window_id && BreakoutRectsOverlap(candidate, rect)) {
+                    overlaps = true;
+                    break;
+                }
+            }
+            if (!overlaps) break;
+            pos.x += size.x + 6.f;
+            if (pos.x + size.x > max.x) {
+                pos.x = start.x;
+                pos.y += size.y + 6.f;
+                if (pos.y + size.y > max.y) pos.y = vp->WorkPos.y;
+            }
+        }
+        return pos;
+    }
+}
+
 void ToolboxUIElement::DrawBreakoutButton(IDirect3DDevice9*)
 {
-    if (!show_breakout_button) return;
-
     char window_id[256];
     snprintf(window_id, sizeof(window_id), "%s##breakout_btn", Name());
 
+    if (!show_breakout_button) {
+        breakout_button_rects.erase(window_id);
+        return;
+    }
+
     ImGuiWindowFlags flags = ImGuiWindowFlags_NoTitleBar | ImGuiWindowFlags_NoScrollbar | ImGuiWindowFlags_NoScrollWithMouse | ImGuiWindowFlags_AlwaysAutoResize | ImGuiWindowFlags_NoFocusOnAppearing | ImGuiWindowFlags_NoNav;
 
     if (!ToolboxSettings::move_all && lock_breakout_button) {
@@ -613,6 +654,16 @@ void ToolboxUIElement::DrawBreakoutButton(IDirect3DDevice9*)
     if (pending_breakout_pos) {
         ImGui::SetNextWindowPos({breakout_pos[0], breakout_pos[1]}, ImGuiCond_Always);
         pending_breakout_pos = false;
+        breakout_pos_set = true;
+    }
+    else if (!breakout_pos_set) {
+        // Brand-new button: default to the middle of the screen, nudged so it doesn't land on another button.
+        const float est = ImGui::GetFrameHeight() + 16.f;
+        const ImVec2 pos = GetDefaultBreakoutPos(window_id, {est, est});
+        ImGui::SetNextWindowPos(pos, ImGuiCond_Always);
+        breakout_pos[0] = pos.x;
+        breakout_pos[1] = pos.y;
+        breakout_pos_set = true;
     }
 
     ImGui::PushStyleVar(ImGuiStyleVar_WindowPadding, {6.f, 6.f});
@@ -666,9 +717,11 @@ void ToolboxUIElement::DrawBreakoutButton(IDirect3DDevice9*)
     ImGui::PopStyleVar(2);
 
     // Keep breakout_pos current so SaveSettings captures the right position even without a live ImGui context.
+    // Also record the live rect so other breakout buttons can avoid overlapping this one.
     if (const auto bw = ImGui::FindWindowByName(window_id)) {
         breakout_pos[0] = bw->Pos.x;
         breakout_pos[1] = bw->Pos.y;
+        breakout_button_rects[window_id] = ImRect(bw->Pos, {bw->Pos.x + bw->Size.x, bw->Pos.y + bw->Size.y});
     }
 }
 

GWToolboxdll/ToolboxUIElement.h

@@ -54,6 +54,8 @@ class ToolboxUIElement : public ToolboxModule {
     bool lock_breakout_button = false;
     std::array<float, 2> breakout_pos = {60.f, 60.f};
     bool pending_breakout_pos = false;
+    // Runtime-only: set once the button has been positioned (from saved settings or a computed default)
+    bool breakout_pos_set = false;
 
     // Mobile-mode layout settings (separate from normal-mode settings above)
     bool mobile_lock_move = false;