Merge pull request #2407 from gwdevhub/claude/issue-2399-20260712-0839

3vcloud · web-flow · commit 98ea2780349e · 2026-07-12T10:06:14.000+01:00
fix(injector): normalize LF to CRLF in changelog before display
diff --git a/GWToolbox/Download.cpp b/GWToolbox/Download.cpp
@@ -480,7 +480,14 @@ bool DownloadWindow::Create()
 
 void DownloadWindow::SetChangelog(const char* str, const size_t length) const
 {
-    const std::wstring content(str, str + length);
+    // Win32 Edit control requires CRLF; GitHub release bodies use bare LF
+    std::wstring content;
+    content.reserve(length);
+    for (const char* p = str; p != str + length; ++p) {
+        if (*p == '\n' && (p == str || p[-1] != '\r'))
+            content += L'\r';
+        content += static_cast<wchar_t>(*p);
+    }
     SendMessageW(m_hChangelog, WM_SETTEXT, 0, reinterpret_cast<LPARAM>(content.c_str()));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -480,7 +480,14 @@ bool DownloadWindow::Create()`
`480`	`480`
`481`	`481`	`void DownloadWindow::SetChangelog(const char* str, const size_t length) const`
`482`	`482`	`{`
`483`		`- const std::wstring content(str, str + length);`
	`483`	`+ // Win32 Edit control requires CRLF; GitHub release bodies use bare LF`
	`484`	`+ std::wstring content;`
	`485`	`+ content.reserve(length);`
	`486`	`+ for (const char* p = str; p != str + length; ++p) {`
	`487`	`+ if (*p == '\n' && (p == str \|\| p[-1] != '\r'))`
	`488`	`+ content += L'\r';`
	`489`	`+ content += static_cast<wchar_t>(*p);`
	`490`	`+ }`
`484`	`491`	`SendMessageW(m_hChangelog, WM_SETTEXT, 0, reinterpret_cast<LPARAM>(content.c_str()));`
`485`	`492`	`}`
`486`	`493`