fix(quest): defer quest path calc until loading screen clears

Server quest messages (kServerActiveQuestChanged, kQuestAdded,
kClientActiveQuestChanged, kQuestDetailsChanged) arrive while the
zone-in loading screen is still up. OnPostUIMessage refreshed the path
immediately, kicking the route calc off against transitional map/pathing
data and leaving the route stuck until a Toolbox restart.

Instead of sprinkling loading-screen guards across each call site, the
message handlers and OnMapLoaded now just raise refresh_all_quest_paths_queued.
QuestModule::Update consumes it in one place, already behind the existing
loading-screen and pathing guards, so the calc only ever kicks off once
the map is fully loaded.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: GWToolbox Bot

GWToolboxdll/Modules/QuestModule.cpp

@@ -37,6 +37,9 @@ namespace {
     bool QuestPathingAvailable() { return PathfindingWindow::IsPathingEnabled(); }
 
     bool fetch_missing_quest_info_queued = false;
+    // Quest messages and map loads only flag a refresh; QuestModule::Update() consumes it behind the loading-screen and
+    // pathing guards, so we never kick a route calc off against transitional map data mid-load.
+    bool refresh_all_quest_paths_queued = false;
 
     std::vector<QuestModule::CustomMarkerChangedCallback> custom_marker_callbacks;
 
@@ -560,10 +563,10 @@ namespace {
                     // Quest assigned without user interaction
                     QuestModule::SetActiveQuestId(player_chosen_quest_id, true);
                 }
-                RefreshQuestPath(*static_cast<GW::Constants::QuestID*>(packet));
+                refresh_all_quest_paths_queued = true;
             } break;
             case GW::UI::UIMessage::kServerActiveQuestChanged:
-                RefreshQuestPath(*static_cast<GW::Constants::QuestID*>(packet));
+                refresh_all_quest_paths_queued = true;
                 break;
             case GW::UI::UIMessage::kMapLoaded:
                 BlockQuestSound();
@@ -583,11 +586,9 @@ namespace {
         if (custom_quest_marker_world_pos.y != 0 || custom_quest_marker_world_pos.x != 0) {
             QuestModule::SetCustomQuestMarker(custom_quest_marker_world_pos, quest_id_before_map_load == custom_quest_id);
         }
-        RefreshAllQuestPaths();
+        refresh_all_quest_paths_queued = true;
     }
 
-    bool refresh_all_quest_paths_queued = 0;
-
     // Dangerously frees gw memory!
     void RemoveQuest(GW::Constants::QuestID quest_id)
     {
@@ -929,6 +930,13 @@ void QuestModule::Update(float)
         return;
     }
 
+    // Consume any refresh flagged by quest messages / map loads. We're past the loading-screen and pathing guards here,
+    // so this is the one place a route calc kicks off — never against transitional map data mid-load.
+    if (refresh_all_quest_paths_queued) {
+        refresh_all_quest_paths_queued = false;
+        RefreshAllQuestPaths();
+    }
+
     const size_t size = calculated_quest_paths.size();
 check_paths:
     for (const auto& [quest_id, calculated_quest_path] : calculated_quest_paths) {