Skip to content

Misleading note on README #55

@russointroitoa

Description

@russointroitoa

I noticed that one of the first lines of README states:

NOTE: As of 1.0 batch_size renamed to batch_flush_size

However, the two variables have clearly different meanings. The former defines the number of items per batch, the latter, instead, states how many items you should fetch from Redis each time. In other words, batch_flush_size is the pluck_size and batch_size is the chunk_size; therefore if you choose batch_flush_size=5000 and batch_size=100, you will obtain 5000/100 = 50 batches.

As it is written on the README, it seems that the two parameters are the same, but in my understanding they are different.

Playing with those two parameters could be useful to increase the speed of batches creation (and maybe solve this issue)

Am I missing something?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions