Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py -> JS issue example notebook #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gzuidhof
Copy link
Owner

@gzuidhof gzuidhof commented Aug 10, 2021

To reproduce locally you can try the steps here.

@stefnotch
Copy link
Collaborator

stefnotch commented Aug 15, 2021

I think I know what the issue is. I haven't actually debugged it though

This right here where the result gets returned

doesn't handle object-proxy objects. It might be worthwhile to hook it up to this
serializePostMessage(value: any): any {

@stefnotch
Copy link
Collaborator

stefnotch commented Aug 19, 2021

I took a closer look at it. I suppose the kernel could/should automatically handle that. This could be done around here

value: result,

Though, ideally at some point https://github.com/hoodmane/synclink would be ready for production use. And then we could use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants