fix: improve report template modal scrolling and allow renaming

Make the template editor modal content panes reliably scroll for large markdown bodies and allow editing template names in edit mode, with old-name cleanup on save when renamed.

Made-with: Cursor

Author: h0tak88r

internal/modules/gobot/ui/app.js

@@ -184,6 +184,7 @@ const state = {
   _shellWired: false,
   _r2BrowserWired: false,
   _metricsTimer: null,
+  reportTemplateOriginalName: '',
 };
 
 // ── Router ────────────────────────────────────────────────────────────────────
@@ -7801,7 +7802,9 @@ async function openReportTemplateModal(name = '') {
   if (!modal || !title || !nameInput || !contentInput) return;
 
   nameInput.value = name;
-  nameInput.readOnly = name !== '';
+  // Allow renaming existing templates.
+  nameInput.readOnly = false;
+  state.reportTemplateOriginalName = name || '';
   contentInput.value = '';
   title.textContent = name ? '📝 Edit Template' : '➕ New Template';
 
@@ -7832,12 +7835,14 @@ function updateTemplatePreview() {
 
 function closeReportTemplateModal() {
   const modal = document.getElementById('modal-report-template');
+  state.reportTemplateOriginalName = '';
   if (modal) modal.style.display = 'none';
 }
 
 async function saveReportTemplate() {
   const name = document.getElementById('report-template-name').value.trim();
   const content = document.getElementById('report-template-content').value;
+  const originalName = String(state.reportTemplateOriginalName || '').trim();
 
   if (!name || !content) {
     showToast('error', 'Validation', 'Name and content are required');
@@ -7857,6 +7862,19 @@ async function saveReportTemplate() {
       throw new Error(data.error || 'Failed to save template');
     }
 
+    // If this was a rename, remove the old template key.
+    if (originalName && originalName !== name) {
+      try {
+        const delHeaders = await buildAuthHeaders();
+        await fetch(`${API}/api/report-templates/${encodeURIComponent(originalName)}`, {
+          method: 'DELETE',
+          headers: delHeaders,
+        });
+      } catch (_) {
+        // Best effort: keep successful save even if old key cleanup fails.
+      }
+    }
+
     showToast('success', 'Template Saved', `Template "${name}" saved successfully`);
     closeReportTemplateModal();
     renderReportTemplates();

internal/modules/gobot/ui/index.html

@@ -649,29 +649,29 @@ <h1 class="view-title">📝 Report Templates</h1>
 
 <!-- Modal: Report Template Editor -->
 <div id="modal-report-template" class="auth-gate" style="display:none" aria-modal="true" role="dialog">
-  <div class="auth-card" style="width: 95%; max-width: 1200px; padding: 24px; height: 90vh; display: flex; flex-direction: column;">
+  <div class="auth-card" style="width: 95%; max-width: 1200px; padding: 24px; height: 90vh; display: flex; flex-direction: column; overflow: hidden;">
     <div class="view-header" style="margin-bottom: 20px; flex-shrink: 0;">
       <h2 class="view-title" id="report-template-modal-title">📝 Edit Template</h2>
       <div class="view-subtitle">Markdown format supported with real-time preview</div>
     </div>
 
-    <div class="auth-form" style="display: flex; flex-direction: column; gap: 16px; flex: 1; min-height: 0;">
+    <div class="auth-form" style="display: flex; flex-direction: column; gap: 16px; flex: 1; min-height: 0; overflow: hidden;">
       <div style="flex-shrink: 0;">
         <label class="auth-label" for="report-template-name">Template Name</label>
         <input class="search-input auth-input" id="report-template-name" type="text" placeholder="e.g. pentest-report" required />
       </div>
 
-      <div style="display: grid; grid-template-columns: 1fr 1fr; gap: 20px; flex: 1; min-height: 0;">
-        <div style="display: flex; flex-direction: column;">
+      <div style="display: grid; grid-template-columns: 1fr 1fr; gap: 20px; flex: 1; min-height: 0; overflow: hidden;">
+        <div style="display: flex; flex-direction: column; min-height: 0;">
           <label class="auth-label">Markdown Editor</label>
           <textarea id="report-template-content" class="search-input auth-input" 
-            style="flex: 1; font-family: 'JetBrains Mono', monospace; font-size: 13px; line-height: 1.5; padding: 12px; resize: none; background: #010409;" 
+            style="flex: 1; min-height: 0; overflow-y: auto; font-family: 'JetBrains Mono', monospace; font-size: 13px; line-height: 1.5; padding: 12px; resize: none; background: #010409;" 
             placeholder="# My Report Template..." oninput="updateTemplatePreview()"></textarea>
         </div>
-        <div style="display: flex; flex-direction: column;">
+        <div style="display: flex; flex-direction: column; min-height: 0;">
           <label class="auth-label">Live Preview</label>
           <div id="report-template-preview" class="search-input" 
-            style="flex: 1; overflow-y: auto; padding: 16px; background: #0d1117; border: 1px solid var(--border); border-radius: 8px; color: var(--text-primary); font-size: 14px;"></div>
+            style="flex: 1; min-height: 0; overflow-y: auto; padding: 16px; background: #0d1117; border: 1px solid var(--border); border-radius: 8px; color: var(--text-primary); font-size: 14px;"></div>
         </div>
       </div>