Merge pull request #509 from hack-a-chain-software/snapshot-remove

refactor: removed heapdump writing

Author: 0xneves

Dockerfile

@@ -1,24 +1,18 @@
 FROM node:18-alpine as builder
 WORKDIR /app
 COPY indexer yarn.lock ./
-# Install build dependencies for native modules like heapdump
-RUN apk add --no-cache python3 make g++
 RUN rm -rf node_modules && yarn install --frozen-lockfile
 RUN npx graphql-codegen
 RUN yarn build
 
 FROM node:18-alpine
 WORKDIR /app
 COPY indexer/package.json indexer/tsconfig.json yarn.lock ./
-# Install build dependencies for native modules like heapdump
-RUN apk add --no-cache python3 make g++
 RUN yarn install --frozen-lockfile
 COPY --from=builder /app/dist ./dist
 COPY --from=builder /app/src/config/global-bundle.pem ./dist/config/global-bundle.pem
 COPY --from=builder /app/src/kadena-server/config/schema.graphql ./dist/kadena-server/config/schema.graphql
 COPY --from=builder /app/src/circulating-coins/ ./dist/circulating-coins/
-# Create snapshots directory for heap dumps
-RUN mkdir -p /snapshots
 EXPOSE 3001
 
 ARG INDEXER_MODE_PARAM

indexer/package.json

@@ -51,7 +51,6 @@
     "@types/decimal.js": "^7.4.3",
     "@types/eventsource": "^1.1.15",
     "@types/express": "^4.17.21",
-    "@types/heapdump": "^0.3.4",
     "@types/jest": "^29.5.12",
     "@types/mocha": "^10.0.7",
     "@types/node": "^20.11.17",
@@ -62,7 +61,6 @@
     "dotenv": "^16.4.4",
     "dotenv-cli": "^8.0.0",
     "eslint": "^8.56.0",
-    "heapdump": "^0.3.15",
     "jest": "^29.7.0",
     "mocha": "^10.7.3",
     "module-alias": "^2.2.3",

indexer/src/index.ts

@@ -20,6 +20,7 @@ import { startStreaming } from './services/streaming';
 import { backfillPairEvents } from './services/pair';
 import { setupAssociations } from './models/setup-associations';
 import { PriceUpdaterService } from '@/services/price/price-updater.service';
+import { initializeMemoryMonitoring } from '@/utils/memory-usage';
 
 /**
  * Command-line interface configuration using Commander.
@@ -51,6 +52,7 @@ async function main() {
   try {
     console.info('Starting v1.1.0');
     initializeErrorMonitoring();
+    initializeMemoryMonitoring();
     setupAssociations();
     PriceUpdaterService.getInstance();
 

indexer/src/kadena-server/server.ts

@@ -19,7 +19,6 @@
  */
 
 import './plugins/instrument';
-import heapdump from 'heapdump';
 import { ApolloServer, ApolloServerPlugin } from '@apollo/server';
 import { expressMiddleware } from '@apollo/server/express4';
 import { ApolloServerPluginDrainHttpServer } from '@apollo/server/plugin/drainHttpServer';
@@ -510,23 +509,6 @@ export async function startGraphqlServer() {
     res.status(404).end();
   });
 
-  const logMemoryUsage = () => {
-    const mem = process.memoryUsage();
-    console.info(
-      `[INFO][MEMORY] Heap: ${(mem.heapUsed / 1024 / 1024).toFixed(2)}MB / ${(mem.heapTotal / 1024 / 1024).toFixed(2)}MB | External: ${(mem.external / 1024 / 1024).toFixed(2)}MB | RSS: ${(mem.rss / 1024 / 1024).toFixed(2)}MB`,
-    );
-
-    // Capture heap snapshot at 1GB memory threshold
-    if (mem.heapUsed > 1 * 1024 * 1024 * 1024) {
-      const filename = `/snapshots/indexer-heap-1GB-${Date.now()}.heapsnapshot`;
-      console.error(`[WARN][MEMORY] 1GB threshold reached! Capturing heap snapshot: ${filename}`);
-      heapdump.writeSnapshot(filename);
-    }
-  };
-
-  // Start periodic memory monitoring every one hour
-  setInterval(logMemoryUsage, 1000 * 60 * 60);
-
   // Initialize cache and start the server
   await initCache(context);
   await new Promise<void>(resolve => httpServer.listen({ port: KADENA_GRAPHQL_API_PORT }, resolve));

indexer/src/utils/memory-usage.ts

@@ -0,0 +1,13 @@
+export const initializeMemoryMonitoring = () => {
+  const memoryMonitoringInterval = 1000 * 60 * 30; // 30 minutes
+  setInterval(monitorMemoryUsage, memoryMonitoringInterval);
+};
+
+const monitorMemoryUsage = () => {
+  const mem = process.memoryUsage();
+  const heapUsedMB = mem.heapUsed / 1024 / 1024;
+  const heapInfo = `Heap: ${heapUsedMB.toFixed(2)}MB / ${(mem.heapTotal / 1024 / 1024).toFixed(2)}MB`;
+  const externalInfo = `External: ${(mem.external / 1024 / 1024).toFixed(2)}MB`;
+  const rssInfo = `RSS: ${(mem.rss / 1024 / 1024).toFixed(2)}MB`;
+  console.info(`[INFO][MEMORY] ${heapInfo} | ${externalInfo} | ${rssInfo}`);
+};

yarn.lock

@@ -2663,11 +2663,6 @@
   dependencies:
     "@types/node" "*"
 
-"@types/heapdump@^0.3.4":
-  version "0.3.4"
-  resolved "https://registry.yarnpkg.com/@types/heapdump/-/heapdump-0.3.4.tgz#59645b30165d832ea654449c8ffbed0c156ad60c"
-  integrity sha512-gTGn7W7i58F1yzvLZ5+hRE7M/VqgEzgccERJ9ZThC6qor5R8wo3oP7iiHvwgHIZzoqPF22ngu8mBagcqPWMVTg==
-
 "@types/http-errors@*":
   version "2.0.4"
   resolved "https://registry.npmjs.org/@types/http-errors/-/http-errors-2.0.4.tgz"
@@ -5350,13 +5345,6 @@ header-case@^2.0.4:
     capital-case "^1.0.4"
     tslib "^2.0.3"
 
-heapdump@^0.3.15:
-  version "0.3.15"
-  resolved "https://registry.yarnpkg.com/heapdump/-/heapdump-0.3.15.tgz#631a8a2585588ea64778d8ec80a64c6c025f6a08"
-  integrity sha512-n8aSFscI9r3gfhOcAECAtXFaQ1uy4QSke6bnaL+iymYZ/dWs9cqDqHM+rALfsHUwukUbxsdlECZ0pKmJdQ/4OA==
-  dependencies:
-    nan "^2.13.2"
-
 html-escaper@^2.0.0:
   version "2.0.2"
   resolved "https://registry.npmjs.org/html-escaper/-/html-escaper-2.0.2.tgz"
@@ -6707,11 +6695,6 @@ [email protected]:
   resolved "https://registry.npmjs.org/mute-stream/-/mute-stream-0.0.8.tgz"
   integrity sha512-nnbWWOkoWyUsTjKrhgD0dcz22mdkSnpYqbEjIm2nhwhuxlSkpywJmBo8h0ZqJdkp73mb90SssHkN4rsRaBAfAA==
 
-nan@^2.13.2:
-  version "2.23.0"
-  resolved "https://registry.yarnpkg.com/nan/-/nan-2.23.0.tgz#24aa4ddffcc37613a2d2935b97683c1ec96093c6"
-  integrity sha512-1UxuyYGdoQHcGg87Lkqm3FzefucTa0NAiOcuRsDmysep3c1LVCRK2krrUDafMWtjSG04htvAmvg96+SDknOmgQ==
-
 napi-wasm@^1.1.0:
   version "1.1.0"
   resolved "https://registry.npmjs.org/napi-wasm/-/napi-wasm-1.1.0.tgz"