Skip to content

fix: remove unnecessary error throwing in dataloaders #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mschead merged 1 commit into from
Sep 11, 2025
+0 −24
Merged

fix: remove unnecessary error throwing in dataloaders #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions indexer/src/kadena-server/repository/infra/repository/block-db-repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,12 +610,6 @@ export default class BlockDbRepository implements BlockRepository {
[eventIds],
);

if (blockRows.length !== eventIds.length) {
throw new Error(
`[ERROR][DB][DATA_CORRUPT] Fetched blocks count (${blockRows.length}) does not match event IDs count (${eventIds.length}).`,
);
}

const blockMap = blockRows.reduce(
(acum, row) => ({
...acum,
Expand Down Expand Up @@ -663,12 +657,6 @@ export default class BlockDbRepository implements BlockRepository {
[transactionIds],
);

if (blockRows.length !== transactionIds.length) {
throw new Error(
`[ERROR][DB][DATA_CORRUPT] Fetched blocks count (${blockRows.length}) does not match transaction IDs count (${transactionIds.length}).`,
);
}

const blockMap = blockRows.reduce(
(acum, row) => ({
...acum,
Expand Down Expand Up @@ -714,12 +702,6 @@ export default class BlockDbRepository implements BlockRepository {
[hashes],
);

if (blockRows.length !== hashes.length) {
throw new Error(
`[ERROR][DB][DATA_CORRUPT] Fetched blocks count (${blockRows.length}) does not match requested hashes count (${hashes.length}).`,
);
}

const blockMap = blockRows.reduce(
(acum, row) => ({
...acum,
Expand Down
6 changes: 0 additions & 6 deletions indexer/src/kadena-server/repository/infra/repository/transaction-db-repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,12 +772,6 @@ export default class TransactionDbRepository implements TransactionRepository {
[eventIds],
);

if (rows.length !== eventIds.length) {
throw new Error(
`[ERROR][DB][DATA_CORRUPT] Fetched blocks count (${rows.length}) does not match event IDs count (${eventIds.length}).`,
);
}

const transactionMap = rows.reduce(
(acum, row) => ({
...acum,
Expand Down