Merge pull request #122 from hackaburg/copilot/fix-typecheck-issues

Fix all TypeScript errors from `yarn run frontend::typecheck`

Author: sezanzeb

backend/src/controllers/rating-controller.ts

@@ -1,18 +1,6 @@
-import {
-  Authorized,
-  JsonController,
-  CurrentUser,
-  Get,
-  Post,
-  Body,
-  Param,
-} from "routing-controllers";
+import { Authorized, JsonController, CurrentUser, Get, Post, Body, Param } from "routing-controllers";
 import { Inject } from "typedi";
 import { UserRole } from "../entities/user-role";
-import {
-  SettingsServiceToken,
-  ISettingsService,
-} from "../services/settings-service";
 import { RatingServiceToken, IRatingService } from "../services/rating-service";
 import {
   RatingDTO,
@@ -25,7 +13,6 @@ import { Rating } from "../entities/rating";
 @JsonController("/ratings")
 export class RatingController {
   public constructor(
-    @Inject(SettingsServiceToken) private readonly _settings: ISettingsService,
     @Inject(RatingServiceToken) private readonly _ratings: IRatingService,
   ) {}
 

backend/src/entities/criterion.ts

@@ -1,4 +1,4 @@
-import { Column, Entity, OneToOne, PrimaryGeneratedColumn } from "typeorm";
+import { Column, Entity, PrimaryGeneratedColumn } from "typeorm";
 import { Longtext } from "./longtext";
 
 @Entity()

backend/src/services/project-service.ts

@@ -47,7 +47,6 @@ export const ProjectServiceToken = new Token<IProjectService>();
 export class ProjectService implements IProjectService {
   private _projects!: Repository<Project>;
   private _teams!: Repository<Team>;
-  private _users!: Repository<User>;
   private _settings!: Repository<Settings>;
 
   public constructor(
@@ -60,7 +59,6 @@ export class ProjectService implements IProjectService {
   public async bootstrap(): Promise<void> {
     this._projects = this._database.getRepository(Project);
     this._teams = this._database.getRepository(Team);
-    this._users = this._database.getRepository(User);
     this._settings = this._database.getRepository(Settings);
   }
 

backend/src/services/rating-service.ts

@@ -1,5 +1,4 @@
 import {
-  BadRequestError,
   ForbiddenError,
   NotFoundError,
 } from "routing-controllers";
@@ -60,7 +59,6 @@ export class RatingService implements IRatingService {
   private _ratings!: Repository<Rating>;
   private _projects!: Repository<Project>;
   private _teams!: Repository<Team>;
-  private _users!: Repository<User>;
 
   public constructor(
     @Inject(DatabaseServiceToken) private readonly _database: IDatabaseService,
@@ -74,7 +72,6 @@ export class RatingService implements IRatingService {
     this._ratings = this._database.getRepository(Rating);
     this._projects = this._database.getRepository(Project);
     this._teams = this._database.getRepository(Team);
-    this._users = this._database.getRepository(User);
   }
 
   /**
@@ -206,7 +203,6 @@ export class RatingService implements IRatingService {
       }
 
       // Calculate average
-      const criterionIdToAvg: Record<number, number> = {};
       for (const criterionId in criterionIdToSum) {
         const average =
           criterionIdToSum[criterionId] / criterionIdToCount[criterionId];

frontend/src/api/index.ts

@@ -592,8 +592,8 @@ export class ApiClient {
    * Get Project by Id
    * @return project by id
    */
-  public async getProjectByID(id: number): Promise<TeamResponseDTO> {
-    return await this.get<ApplicationControllerMethods["getTeamByID"]>(
+  public async getProjectByID(id: number): Promise<ProjectDTO> {
+    return await this.get<ProjectsControllerMethods["getProjectByID"]>(
       `/projects/${id}`,
     );
   }
@@ -630,7 +630,7 @@ export class ApiClient {
    * Gets all ratings.
    */
   public async getUsersRatingsForProject(
-    project,
+    project: ProjectDTO,
   ): Promise<readonly RatingDTO[]> {
     return await this.get<RatingControllerMethods["getUsersRatingsForProject"]>(
       `/ratings/by-project/${project.id}`,
@@ -651,7 +651,7 @@ export class ApiClient {
    * @param rating The rating to submit
    */
   public async createRating(rating: RatingDTO): Promise<RatingDTO> {
-    return await this.post<RatingControllerMethods["createRating"]>(
+    return await this.post<RatingControllerMethods["rate"]>(
       "/ratings/rate",
       rating,
     );

frontend/src/api/types/controllers.ts

@@ -3,6 +3,6 @@ export * from "../../../../backend/src/controllers/settings-controller";
 export * from "../../../../backend/src/controllers/users-controller";
 export * from "../../../../backend/src/controllers/application-controller";
 export * from "../../../../backend/src/controllers/system-controller";
-export * from "../../../../backend/src/controllers/criterioncontroller";
+export * from "../../../../backend/src/controllers/criterion-controller";
 export * from "../../../../backend/src/controllers/projects-controller";
 export * from "../../../../backend/src/controllers/rating-controller";

frontend/src/components/base/button.tsx

@@ -76,9 +76,7 @@ export const Button = ({
   disable = false,
   primary = false,
   loading = false,
-  wide = false,
   color,
-  href = null,
 }: IButtonProps) => {
   const handleClick = useCallback(
     (event: React.MouseEvent) => {

frontend/src/components/base/chevron.tsx

@@ -11,6 +11,7 @@ interface IChevronProps {
   color?: string;
   size?: number;
   rotation?: number;
+  style?: React.CSSProperties;
 }
 
 /**

frontend/src/components/base/collapsible.tsx

@@ -5,11 +5,9 @@ import { useToggle } from "../../hooks/use-toggle";
 import { Chevron } from "./chevron";
 import {
   FlexColumnContainer,
-  NonGrowingFlexContainer,
   Spacer,
   VerticallyCenteredContainer,
 } from "./flex";
-import { Subsubheading } from "./headings";
 
 const ExpandButton = styled.button`
   cursor: pointer;
@@ -39,18 +37,18 @@ export const Collapsible = ({
     <FlexColumnContainer>
       <VerticallyCenteredContainer>
         <ExpandButton onClick={handleOpen}>
-          <span style={{ "font-size": "1.25rem", "margin-right": "10px" }}>
+          <span style={{ fontSize: "1.25rem", marginRight: "10px" }}>
             {title}
           </span>
           <Chevron
             rotation={isOpen ? 0 : -90}
-            style={{ "vertical-align": "center" }}
+            style={{ verticalAlign: "center" }}
           />
         </ExpandButton>
       </VerticallyCenteredContainer>
 
       {isOpen && (
-        <FlexColumnContainer style={{ "padding-top": "5px" }}>
+        <FlexColumnContainer style={{ paddingTop: "5px" }}>
           {children}
           <Spacer />
         </FlexColumnContainer>

frontend/src/components/base/dialog.tsx

@@ -18,7 +18,6 @@ import { FaLinkedin } from "react-icons/fa";
 export interface SimpleDialogProps {
   open: boolean;
   onClose: (value: true) => void;
-  Button;
 }
 
 /**