Add waiting time calculations to review controllers

Author: samdev-7

app/controllers/admin/build_reviews_controller.rb

@@ -100,6 +100,13 @@ def show
     @claimed_by_other = Reviews::ClaimProject.claimed_by_other?(project: @project, reviewer: current_user, type: :build)
     @build_review = @project.build_reviews.build
     @ai_review = @project.latest_ai_review("build") if Flipper.enabled?(:ai_reviewer)
+
+    # Waiting time: last and first time project entered build_pending
+    pending_versions = PaperTrail::Version.where(item_type: "Project", item_id: @project.id, event: "update")
+                        .where("jsonb_exists(object_changes, 'review_status')")
+                        .where("object_changes->'review_status'->>1 = ?", "build_pending")
+    @waiting_since = pending_versions.maximum(:created_at)
+    @first_waiting_since = pending_versions.minimum(:created_at)
   end
 
   def show_next

app/controllers/admin/design_reviews_controller.rb

@@ -86,6 +86,13 @@ def show
     @claimed_by_other = Reviews::ClaimProject.claimed_by_other?(project: @project, reviewer: current_user, type: :design)
     @design_review = @project.design_reviews.build
     @ai_review = @project.latest_ai_review("design") if Flipper.enabled?(:ai_reviewer)
+
+    # Waiting time: last and first time project entered design_pending
+    pending_versions = PaperTrail::Version.where(item_type: "Project", item_id: @project.id, event: "update")
+                        .where("jsonb_exists(object_changes, 'review_status')")
+                        .where("object_changes->'review_status'->>1 = ?", "design_pending")
+    @waiting_since = pending_versions.maximum(:created_at)
+    @first_waiting_since = pending_versions.minimum(:created_at)
   end
 
   def show_next

app/views/admin/build_reviews/_streamlined_show.html.erb

@@ -76,6 +76,18 @@
                 <% if project.ysws.present? %>
                   &middot; <span class="text-zinc-300"><%= project.ysws %></span>
                 <% end %>
+                <% if @waiting_since %>
+                  <%
+                    now = Time.current
+                    fmt = ->(t) { secs = now - t; secs < 1.hour ? "<1h" : secs < 1.day ? "#{(secs / 1.hour).floor}h" : "#{(secs / 1.day).floor}d" }
+                    last_str = fmt.call(@waiting_since)
+                    first_str = @first_waiting_since ? fmt.call(@first_waiting_since) : last_str
+                  %>
+                  &middot; Waiting <span class="text-zinc-300"><%= last_str %></span>
+                  <% if last_str != first_str %>
+                    (<span class="text-zinc-300"><%= first_str %></span> total)
+                  <% end %>
+                <% end %>
               </p>
             </div>
 

app/views/admin/build_reviews/show.html.erb

@@ -39,7 +39,20 @@
     <div class="flex flex-col justify-between space-y-1" >
       <h1 class="pb-2 text-4xl">Project #<%= @project.id %>, <%= link_to @project.title, admin_project_path(@project), class: "underline" %></h1>
       <div>
-        <p>By <%= render "shared/user_inline", user: @project.user, admin_view: true %> on <%= @project.created_at.strftime("%B %d, %Y") %></p>
+        <p>By <%= render "shared/user_inline", user: @project.user, admin_view: true %> on <%= @project.created_at.strftime("%B %d, %Y") %>
+        <% if @waiting_since %>
+          <%
+            now = Time.current
+            fmt = ->(t) { secs = now - t; secs < 1.hour ? "<1h" : secs < 1.day ? "#{(secs / 1.hour).floor}h" : "#{(secs / 1.day).floor}d" }
+            last_str = fmt.call(@waiting_since)
+            first_str = @first_waiting_since ? fmt.call(@first_waiting_since) : last_str
+          %>
+          &middot; Waiting <%= last_str %>
+          <% if last_str != first_str %>
+            (<%= first_str %> total)
+          <% end %>
+        <% end %>
+        </p>
       </div>
       <div class="flex justify-start text-xl mt-4">
         <% if @project.tier.present? %>

app/views/admin/design_reviews/_streamlined_show.html.erb

@@ -156,6 +156,18 @@
                     <% if project.ysws == "hackpad" && project.approx_hour.present? %>
                       &middot; Self-reported: <span class="text-zinc-700 dark:text-zinc-300"><%= project.approx_hour %>h</span>
                     <% end %>
+                    <% if @waiting_since %>
+                      <%
+                        now = Time.current
+                        fmt = ->(t) { secs = now - t; secs < 1.hour ? "<1h" : secs < 1.day ? "#{(secs / 1.hour).floor}h" : "#{(secs / 1.day).floor}d" }
+                        last_str = fmt.call(@waiting_since)
+                        first_str = @first_waiting_since ? fmt.call(@first_waiting_since) : last_str
+                      %>
+                      &middot; Waiting <span class="text-zinc-700 dark:text-zinc-300"><%= last_str %></span>
+                      <% if last_str != first_str %>
+                        (<span class="text-zinc-700 dark:text-zinc-300"><%= first_str %></span> total)
+                      <% end %>
+                    <% end %>
                   </span>
                   <% if current_user.admin? %>
                     <% u = project.user

app/views/admin/design_reviews/show.html.erb

@@ -44,7 +44,20 @@
       <div class="flex flex-col justify-between space-y-1 flex-1">
         <h1 class="pb-2 text-4xl">Project #<%= @project.id %>, <%= link_to @project.title, admin_project_path(@project), class: "underline" %></h1>
         <div>
-          <p>By <%= render "shared/user_inline", user: @project.user, admin_view: true %> on <%= @project.created_at.strftime("%B %d, %Y") %></p>
+          <p>By <%= render "shared/user_inline", user: @project.user, admin_view: true %> on <%= @project.created_at.strftime("%B %d, %Y") %>
+          <% if @waiting_since %>
+            <%
+              now = Time.current
+              fmt = ->(t) { secs = now - t; secs < 1.hour ? "<1h" : secs < 1.day ? "#{(secs / 1.hour).floor}h" : "#{(secs / 1.day).floor}d" }
+              last_str = fmt.call(@waiting_since)
+              first_str = @first_waiting_since ? fmt.call(@first_waiting_since) : last_str
+            %>
+            &middot; Waiting <%= last_str %>
+            <% if last_str != first_str %>
+              (<%= first_str %> total)
+            <% end %>
+          <% end %>
+          </p>
         </div>
       <div class="flex justify-start text-xl mt-4">
         <% if @project.tier.present? %>