Updated User model variable names

Author: del9ra

app/core/admin.py

@@ -46,7 +46,7 @@ class UserAdmin(DefaultUserAdmin):
             {
                 "fields": (
                     "username",
-                    "email",
+                    "email_intake",
                     "password",
                 )
             },
@@ -55,12 +55,12 @@ class UserAdmin(DefaultUserAdmin):
             _("Profile"),
             {
                 "fields": (
-                    "first_name",
-                    "last_name",
-                    "gmail",
-                    "preferred_email",
-                    "current_job_title",
-                    "target_job_title",
+                    "name_first",
+                    "name_last",
+                    "email_gmail",
+                    "email_preferred",
+                    "job_title_current_intake",
+                    "job_title_target_intake",
                     "current_skills",
                     "target_skills",
                     "linkedin_account",
@@ -69,14 +69,19 @@ class UserAdmin(DefaultUserAdmin):
                     "phone",
                     "texting_ok",
                     "time_zone",
+                    "practice_area_primary",
+                    "practice_area_secondary",
+                    "practice_area_target_intake",
+                    "referred_by",
+                    "email_cognito",
                 )
             },
         ),
         (
             _("Permissions"),
             {
                 "fields": (
-                    "is_active",
+                    "user_status",
                     "is_staff",
                     "is_superuser",
                     "groups",
@@ -94,15 +99,15 @@ class UserAdmin(DefaultUserAdmin):
             },
         ),
     )
-    readonly_fields = ("username", "email", "created_at", "updated_at")
+    readonly_fields = ("username", "email_intake", "created_at", "updated_at")
     add_fieldsets = (
         (
             None,
             {
                 "classes": ("wide",),
                 "fields": (
                     "username",
-                    "email",
+                    "email_intake",
                     "password",
                     "password2",
                 ),
@@ -111,8 +116,8 @@ class UserAdmin(DefaultUserAdmin):
     )
     form = UserChangeForm
     add_form = UserCreationForm
-    list_display = ("username", "is_staff", "is_active")
-    list_filter = ("username", "email")
+    list_display = ("username", "is_staff", "user_status")
+    list_filter = ("username", "email_intake")
 
 
 @admin.register(Project)

app/core/api/serializers.py

@@ -75,13 +75,13 @@ class Meta:
             "username",
             "created_at",
             "updated_at",
-            "email",
-            "first_name",
-            "last_name",
-            "gmail",
-            "preferred_email",
-            "current_job_title",
-            "target_job_title",
+            "email_intake",
+            "name_first",
+            "name_last",
+            "email_gmail",
+            "email_preferred",
+            "job_title_current_intake",
+            "job_title_target_intake",
             "current_skills",
             "target_skills",
             "linkedin_account",
@@ -90,13 +90,18 @@ class Meta:
             "phone",
             "texting_ok",
             "time_zone",
+            "practice_area_primary",
+            "practice_area_secondary",
+            "practice_area_target_intake",
+            "referred_by",
+            "email_cognito",
         )
         read_only_fields = (
             "uuid",
             "created_at",
             "updated_at",
             "username",
-            "email",
+            "email_intake",
         )
 
 

app/core/api/views.py

@@ -74,7 +74,7 @@ def get(self, request, *args, **kwargs):
         description="Return a list of all the existing users",
         parameters=[
             OpenApiParameter(
-                name="email",
+                name="email_intake",
                 type=str,
                 description="Filter by email address",
                 examples=[
@@ -118,9 +118,9 @@ def get_queryset(self):
         Optionally filter users by an 'email' and/or 'username' query paramerter in the URL
         """
         queryset = get_user_model().objects.all()
-        email = self.request.query_params.get("email")
-        if email is not None:
-            queryset = queryset.filter(email=email)
+        email_intake = self.request.query_params.get("email_intake")
+        if email_intake is not None:
+            queryset = queryset.filter(email_intake=email_intake)
         username = self.request.query_params.get("username")
         if username is not None:
             queryset = queryset.filter(username=username)

app/core/migrations/0033_rename_gmail_user_email_gmail_and_more.py

@@ -0,0 +1,72 @@
+# Generated by Django 4.2.16 on 2025-03-05 21:36
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('core', '0032_projectprogramareaxref_project_program_areas'),
+    ]
+
+    operations = [
+        migrations.RenameField(
+            model_name='user',
+            old_name='gmail',
+            new_name='email_gmail',
+        ),
+        migrations.RenameField(
+            model_name='user',
+            old_name='email',
+            new_name='email_intake',
+        ),
+        migrations.RenameField(
+            model_name='user',
+            old_name='preferred_email',
+            new_name='email_preferred',
+        ),
+        migrations.RenameField(
+            model_name='user',
+            old_name='current_job_title',
+            new_name='job_title_current_intake',
+        ),
+        migrations.RenameField(
+            model_name='user',
+            old_name='target_job_title',
+            new_name='job_title_target_intake',
+        ),
+        migrations.RenameField(
+            model_name='user',
+            old_name='first_name',
+            new_name='name_first',
+        ),
+        migrations.RenameField(
+            model_name='user',
+            old_name='last_name',
+            new_name='name_last',
+        ),
+        migrations.RemoveField(
+            model_name='user',
+            name='is_active',
+        ),
+        migrations.AddField(
+            model_name='user',
+            name='email_cognito',
+            field=models.EmailField(blank=True, max_length=254),
+        ),
+        migrations.AddField(
+            model_name='user',
+            name='practice_area_primary',
+            field=models.ManyToManyField(related_name='primary_users', to='core.practicearea'),
+        ),
+        migrations.AddField(
+            model_name='user',
+            name='practice_area_secondary',
+            field=models.ManyToManyField(related_name='secondary_users', to='core.practicearea'),
+        ),
+        migrations.AddField(
+            model_name='user',
+            name='practice_area_target_intake',
+            field=models.ManyToManyField(related_name='target_intake_users', to='core.practicearea'),
+        ),
+    ]

app/core/migrations/0034_alter_user_email_intake.py

@@ -0,0 +1,18 @@
+# Generated by Django 4.2.16 on 2025-03-08 01:16
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('core', '0033_rename_gmail_user_email_gmail_and_more'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='user',
+            name='email_intake',
+            field=models.EmailField(blank=True, max_length=254, null=True, verbose_name='Email address'),
+        ),
+    ]

app/core/migrations/0035_alter_user_email_intake.py

@@ -0,0 +1,19 @@
+# Generated by Django 4.2.16 on 2025-03-08 03:09
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('core', '0034_alter_user_email_intake'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='user',
+            name='email_intake',
+            field=models.EmailField(blank=True, default='[email protected]', max_length=254, verbose_name='Email address'),
+            preserve_default=False,
+        ),
+    ]

app/core/migrations/max_migration.txt

@@ -1 +1 @@
-0032_projectprogramareaxref_project_program_areas
+0035_alter_user_email_intake

app/core/models.py

@@ -53,7 +53,6 @@ class User(PermissionsMixin, AbstractBaseUser, AbstractBaseModel):
     username = models.CharField(
         "Username", max_length=255, unique=True, validators=[username_validator]
     )
-    is_active = models.BooleanField("Active", default=True)
 
     # Cognito-user related fields #
     # some additional fields which will be filled-out only for users
@@ -62,26 +61,31 @@ class User(PermissionsMixin, AbstractBaseUser, AbstractBaseModel):
 
     # Django-user related fields #
     # password is inherited from AbstractBaseUser
-    email = models.EmailField("Email address", blank=True)  # allow non-unique emails
+    email_intake = models.EmailField("Email address", blank=True)  # allow non-unique emails
     is_staff = models.BooleanField(
         "staff status",
         default=False,
         help_text="Designates whether the user can log into this admin site.",
     )
 
-    first_name = models.CharField(max_length=255, blank=True)
-    last_name = models.CharField(max_length=255, blank=True)
-    gmail = models.EmailField(blank=True)
-    preferred_email = models.EmailField(blank=True)
+    name_first = models.CharField(max_length=255, blank=True)
+    name_last = models.CharField(max_length=255, blank=True)
+    email_gmail = models.EmailField(blank=True)
+    email_preferred = models.EmailField(blank=True)
+    email_cognito = models.EmailField(blank=True)
 
     user_status = models.ForeignKey(
         "UserStatusType", null=True, on_delete=models.PROTECT
     )
     # current_practice_area = models.ManyToManyField("PracticeArea")
     # target_practice_area = models.ManyToManyField("PracticeArea")
+    practice_area_primary = models.ManyToManyField("PracticeArea", related_name="primary_users")
+    practice_area_secondary = models.ManyToManyField("PracticeArea", related_name="secondary_users")
+    practice_area_target_intake = models.ManyToManyField("PracticeArea", related_name="target_intake_users")
 
-    current_job_title = models.CharField(max_length=255, blank=True)
-    target_job_title = models.CharField(max_length=255, blank=True)
+
+    job_title_current_intake = models.CharField(max_length=255, blank=True)
+    job_title_target_intake = models.CharField(max_length=255, blank=True)
     current_skills = models.CharField(max_length=255, blank=True)
     target_skills = models.CharField(max_length=255, blank=True)
 
@@ -105,15 +109,15 @@ class User(PermissionsMixin, AbstractBaseUser, AbstractBaseModel):
     objects = UserManager()
 
     USERNAME_FIELD = "username"
-    EMAIL_FIELD = "preferred_email"
-    REQUIRED_FIELDS = ["email"]  # used only on createsuperuser
+    EMAIL_FIELD = "email_preferred"
+    REQUIRED_FIELDS = ["email_intake"]  # used only on createsuperuser
 
     @property
     def is_django_user(self):
         return self.has_usable_password()
 
     def __str__(self):
-        return f"{self.email}"
+        return f"{self.email_intake}"
 
 
 class Project(AbstractBaseModel):

app/core/tests/conftest.py

@@ -30,16 +30,16 @@
 def user_superuser_admin():
     return User.objects.create_user(
         username="AdminUser",
-        email="[email protected]",
+        email_intake="[email protected]",
         password="adminuser",
         is_superuser=True,
     )
 
 
 @pytest.fixture
 def user_permissions():
-    user1 = User.objects.create(username="TestUser1", email="[email protected]")
-    user2 = User.objects.create(username="TestUser2", email="[email protected]")
+    user1 = User.objects.create(username="TestUser1", email_intake="[email protected]")
+    user2 = User.objects.create(username="TestUser2", email_intake="[email protected]")
     project = Project.objects.create(name="Test Project")
     permission_type = PermissionType.objects.first()
     practice_area = PracticeArea.objects.first()
@@ -61,7 +61,7 @@ def user_permissions():
 @pytest.fixture
 def user_permission_admin_project():
     user = User.objects.create(
-        username="TestUser Admin Project", email="[email protected]"
+        username="TestUser Admin Project", email_intake="[email protected]"
     )
     project = Project.objects.create(name="Test Project Admin Project")
     permission_type = PermissionType.objects.filter(name=admin_project).first()
@@ -78,7 +78,7 @@ def user_permission_admin_project():
 def user_permission_practice_lead_project():
     user = User.objects.create(
         username="TestUser Practie Lead Project",
-        email="[email protected]",
+        email_intake="[email protected]",
     )
     permission_type = PermissionType.objects.filter(name=practice_lead_project).first()
     project = Project.objects.create(name="Test Project Admin Project")
@@ -97,7 +97,7 @@ def user_permission_practice_lead_project():
 def user(django_user_model):
     return django_user_model.objects.create_user(
         username="TestUser",
-        email="[email protected]",
+        email_intake="[email protected]",
         password="testpass",
     )
 
@@ -106,7 +106,7 @@ def user(django_user_model):
 def user2(django_user_model):
     return django_user_model.objects.create_user(
         username="TestUser2",
-        email="[email protected]",
+        email_intake="[email protected]",
         password="testpass",
     )
 
@@ -116,7 +116,7 @@ def admin(django_user_model):
     return django_user_model.objects.create_user(
         is_staff=True,
         username="TestAdminUser",
-        email="[email protected]",
+        email_intake="[email protected]",
         password="testadmin",
     )