Skip to content

Lost schema of S3 URL. #1892

Open
Open
@fukumoto-ts

Description

@fukumoto-ts

Since v2.5.0, S3 URL schema is now lost.

Image

This is caused by a change in this PR. #1762 (#1761)


It would be good to change it like this.

Now:
https://github.com/blademainer/codimd/blob/7b1e4e3ddb2ef07d1170dcd819986252d5758596/lib/imageRouter/s3.js#L54

s3Endpoint = `s3-${config.s3.region}.amazonaws.com`

After:

s3Endpoint = `https://s3-${config.s3.region}.amazonaws.com`

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions