HCK-13038: adjust Azure MFA auth for RE (#124)

* fix db name parsing

* adjust connection parameters for Azure Entra ID

* remove unused msal-node package

Author: taras-dubyk

package-lock.json

@@ -44,7 +44,6 @@
     "icon_url": "logo.jpg",
     "disabled": false,
     "dependencies": {
-        "@azure/msal-node": "3.8.0",
         "@hackolade/fetch": "1.3.0",
         "base64url": "3.0.1",
         "crypto": "1.0.1",
@@ -80,4 +79,4 @@
         "prettier": "3.2.5",
         "simple-git-hooks": "2.11.1"
     }
-}
+}

package.json

@@ -53,6 +53,7 @@
 			{
 				"inputLabel": "Host",
 				"inputKeyword": "host",
+				"inputPlaceholder": "Host",
 				"description": "Specify Azure Synapse server name",
 				"inputType": "text",
 				"dependency": {
@@ -117,7 +118,7 @@
 					},
 					{
 						"value": "Azure Active Directory (MFA)",
-						"label": "Azure Active Directory (MFA)"
+						"label": "Azure Entra ID (MFA)"
 					}
 				]
 			},
@@ -155,17 +156,7 @@
 				"inputTooltip": "Specify the Tenant ID from the Overview screen of your Azure AD tenant",
 				"dependency": {
 					"key": "authMethod",
-					"value": ["Azure Active Directory (Username / Password)", "Azure Active Directory (MFA)"]
-				}
-			},
-			{
-				"inputLabel": "User Name",
-				"inputKeyword": "loginHint",
-				"inputType": "text",
-				"inputPlaceholder": "User Name",
-				"dependency": {
-					"key": "authMethod",
-					"value": ["Azure Active Directory (MFA)"]
+					"value": ["Azure Active Directory (Username / Password)"]
 				}
 			}
 		]

reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json

@@ -1,6 +1,5 @@
 const { hckFetch } = require('@hackolade/fetch');
 const sql = require('mssql');
-const msal = require('@azure/msal-node');
 const { logAuthTokenInfo, logConnectionHostAndUsername } = require('../../helpers/logInfo');
 const { prepareError } = require('./errorService');
 const { parseResponse } = require('../../helpers/parseResponse');

reverse_engineering/databaseService/helpers/connection.js

@@ -33,7 +33,7 @@ const parseSqlServerUrl = ({ url = '' }) => {
 	return {
 		host,
 		port: port ? Number(port) : null,
-		databaseName: params.databaseName,
+		databaseName: params.databaseName || params.database,
 		userName: params.user,
 		userPassword: params.password,
 	};