Skip to content

Commit 2e49a65

Browse files
consoleVersionSelect: add dummy value as first option
This avoids users mindlessly clicking to a potentially invalid page. Also fixes a bug where the version is marked as valid when empty...
1 parent fb9244d commit 2e49a65

File tree

2 files changed

+78
-69
lines changed

2 files changed

+78
-69
lines changed

docs/_internal/consoleVersionSelect.html

Lines changed: 74 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<div id="selectversion" class="selectversion">
1212
<br>
1313
<select id="major">
14+
<option />
1415
<option>11</option>
1516
<option>10</option>
1617
<option>9</option>
@@ -24,79 +25,83 @@
2425
<option>1</option>
2526
<option>0</option>
2627
</select>.<select id="minor">
27-
<option>17</option>
28-
<option>16</option>
29-
<option>15</option>
30-
<option>14</option>
31-
<option>13</option>
32-
<option>12</option>
33-
<option>11</option>
34-
<option>10</option>
35-
<option>9</option>
36-
<option>8</option>
37-
<option>7</option>
38-
<option>6</option>
39-
<option>5</option>
40-
<option>4</option>
41-
<option>3</option>
42-
<option>2</option>
43-
<option>1</option>
44-
<option>0</option>
28+
<option />
29+
<option>17</option>
30+
<option>16</option>
31+
<option>15</option>
32+
<option>14</option>
33+
<option>13</option>
34+
<option>12</option>
35+
<option>11</option>
36+
<option>10</option>
37+
<option>9</option>
38+
<option>8</option>
39+
<option>7</option>
40+
<option>6</option>
41+
<option>5</option>
42+
<option>4</option>
43+
<option>3</option>
44+
<option>2</option>
45+
<option>1</option>
46+
<option>0</option>
4547
</select>.<select id="whydidnintendodecidetodothingslikethis">
48+
<option />
4649
<option>0</option>
4750
</select>-<select id="nver">
48-
<option>50</option>
49-
<option>49</option>
50-
<option>48</option>
51-
<option>47</option>
52-
<option>46</option>
53-
<option>45</option>
54-
<option>44</option>
55-
<option>43</option>
56-
<option>42</option>
57-
<option>41</option>
58-
<option>40</option>
59-
<option>39</option>
60-
<option>38</option>
61-
<option>37</option>
62-
<option>36</option>
63-
<option>35</option>
64-
<option>34</option>
65-
<option>33</option>
66-
<option>32</option>
67-
<option>31</option>
68-
<option>30</option>
69-
<option>29</option>
70-
<option>28</option>
71-
<option>27</option>
72-
<option>26</option>
73-
<option>25</option>
74-
<option>24</option>
75-
<option>23</option>
76-
<option>22</option>
77-
<option>21</option>
78-
<option>20</option>
79-
<option>19</option>
80-
<option>18</option>
81-
<option>17</option>
82-
<option>16</option>
83-
<option>15</option>
84-
<option>14</option>
85-
<option>13</option>
86-
<option>12</option>
87-
<option>11</option>
88-
<option>10</option>
89-
<option>9</option>
90-
<option>8</option>
91-
<option>7</option>
92-
<option>6</option>
93-
<option>5</option>
94-
<option>4</option>
95-
<option>3</option>
96-
<option>2</option>
97-
<option>1</option>
98-
<option>0</option>
51+
<option />
52+
<option>50</option>
53+
<option>49</option>
54+
<option>48</option>
55+
<option>47</option>
56+
<option>46</option>
57+
<option>45</option>
58+
<option>44</option>
59+
<option>43</option>
60+
<option>42</option>
61+
<option>41</option>
62+
<option>40</option>
63+
<option>39</option>
64+
<option>38</option>
65+
<option>37</option>
66+
<option>36</option>
67+
<option>35</option>
68+
<option>34</option>
69+
<option>33</option>
70+
<option>32</option>
71+
<option>31</option>
72+
<option>30</option>
73+
<option>29</option>
74+
<option>28</option>
75+
<option>27</option>
76+
<option>26</option>
77+
<option>25</option>
78+
<option>24</option>
79+
<option>23</option>
80+
<option>22</option>
81+
<option>21</option>
82+
<option>20</option>
83+
<option>19</option>
84+
<option>18</option>
85+
<option>17</option>
86+
<option>16</option>
87+
<option>15</option>
88+
<option>14</option>
89+
<option>13</option>
90+
<option>12</option>
91+
<option>11</option>
92+
<option>10</option>
93+
<option>9</option>
94+
<option>8</option>
95+
<option>7</option>
96+
<option>6</option>
97+
<option>5</option>
98+
<option>4</option>
99+
<option>3</option>
100+
<option>2</option>
101+
<option>1</option>
102+
<option>0</option>
99103
</select><select id="region">
104+
<option />
100105
<option>E</option>
101106
<option>U</option>
102107
<option>J</option>

docs/public/assets/js/common.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@ if (!window.COMMON_LOADED) {
3434
// CHN/TWN doesn't have new model
3535
// KOR/CHN/TWN doesn't have 11.17 currently
3636
c("validate_version", (major, minor, native, region, model) => {
37+
// These need to actually exist.
38+
if(!major || !minor || !native || !region) {
39+
return false;
40+
}
3741
if (model == DEVICE_N3DS && ["C", "T"].includes(region)) {
3842
return false;
3943
}

0 commit comments

Comments
 (0)