fix a data syncing bug. wasn't unregistering receivers

Author: srcreigh

android/src/main/java/com/hackthenorth/android/base/BaseListFragment.java

@@ -6,7 +6,6 @@
 import android.content.Intent;
 import android.content.IntentFilter;
 import android.support.v4.content.LocalBroadcastManager;
-import android.widget.ArrayAdapter;
 
 import java.util.concurrent.ConcurrentHashMap;
 
@@ -17,6 +16,9 @@ public abstract class BaseListFragment extends Fragment {
     private static ConcurrentHashMap<String, Object> mMemoryCache =
             new ConcurrentHashMap<String, Object>();
 
+    private BroadcastReceiver mReceiver;
+    private Context mContext;
+
     public static Object getCachedObject(String f) {
         return mMemoryCache.get(f);
     }
@@ -25,39 +27,51 @@ public static void setCachedObject(String f, Object o) {
         mMemoryCache.put(f, o);
     }
 
-    protected abstract void handleJSONUpdateInBackground(String json);
+    protected abstract void handleJSONUpdateInBackground(String json, String action);
 
     /**
-     * Creates a BroadcastReceiver that is listening to broadcasts of the type action.
+     * Given an action string, the handleJSONUpdateInBackground method will be called whenever there
+     * is an update.
      *
-     * @param context Used to set up the LocalBroadcastReceiver. Must be non-null.
-     * @param action The action to listen to in the broadcast receiver.
-     * @param adapter The adapter to pass to handleJSONInBackground in onReceive of the
-     *                BroadcastReceiver.
+     * @param context The current Fragment context.
+     * @param action The action to sync to. This is the same action string you would pass to
+     *               HTTPFirebase.GET().
      */
-    protected void registerForSync(Context context, final String action,
-                                   final ArrayAdapter adapter) {
-
-        // Set up BroadcastReceiver for updates.
-        BroadcastReceiver receiver = new BroadcastReceiver() {
-            @Override
-            public void onReceive(Context context, Intent intent) {
-                if (action != null && action.equals(intent.getAction())) {
-
-                    // Update with the new data
-                    String key = intent.getAction();
-                    String json = intent.getStringExtra(key);
-                    handleJSONUpdateInBackground(json);
+    protected void registerForSync(Context context, final String action) {
+
+        final String className = getClass().getSimpleName();
+        final String TAG = className;
+        if (mReceiver == null) {
+            // Set up BroadcastReceiver for updates.
+            mContext = context;
+            mReceiver = new BroadcastReceiver() {
+                @Override
+                public void onReceive(Context context, Intent intent) {
+                    if (action != null && action.equals(intent.getAction())) {
+
+                        // Update with the new data
+                        String key = intent.getAction();
+                        String json = intent.getStringExtra(key);
+                        handleJSONUpdateInBackground(json, action);
+                    }
                 }
-            }
-        };
+            };
 
-        // Register our broadcast receiver.
-        IntentFilter filter = new IntentFilter();
-        filter.addAction(action);
+            // Register our broadcast receiver.
+            IntentFilter filter = new IntentFilter();
+            filter.addAction(action);
+
+            LocalBroadcastManager manager = LocalBroadcastManager.getInstance(mContext);
+            manager.registerReceiver(mReceiver, filter);
+        }
+    }
 
-        LocalBroadcastManager manager = LocalBroadcastManager.getInstance(context);
-        manager.registerReceiver(receiver, filter);
+    @Override
+    public void onPause() {
+        super.onPause();
 
+        // Unregister the broadcast receiver here
+        LocalBroadcastManager manager = LocalBroadcastManager.getInstance(mContext);
+        manager.unregisterReceiver(mReceiver);
     }
 }

android/src/main/java/com/hackthenorth/android/ui/MentorsFragment.java

@@ -42,7 +42,7 @@ public void onAttach(Activity activity) {
         mAdapter = new MentorListAdapter(activity, R.layout.mentor_list_item, mData);
 
         // Register for updates
-        registerForSync(activity, HackTheNorthApplication.Actions.SYNC_MENTORS, mAdapter);
+        registerForSync(activity, HackTheNorthApplication.Actions.SYNC_MENTORS);
 
         HTTPFirebase.GET("/mentors", activity, HackTheNorthApplication.Actions.SYNC_MENTORS);
     }
@@ -86,7 +86,7 @@ public void endSearch() {
     }
 
     @Override
-    protected void handleJSONUpdateInBackground(final String json) {
+    protected void handleJSONUpdateInBackground(final String json, String action) {
         final Activity activity = getActivity();
         new AsyncTask<Void, Void, Void>() {
             @Override

android/src/main/java/com/hackthenorth/android/ui/PrizesFragment.java

@@ -57,7 +57,7 @@ public void onAttach(Activity activity) {
         mAdapter = new PrizesFragmentAdapter(activity, R.layout.prizes_list_item, mData);
         mAdapter.setFragment(this);
 
-        registerForSync(activity, HackTheNorthApplication.Actions.SYNC_PRIZES, mAdapter);
+        registerForSync(activity, HackTheNorthApplication.Actions.SYNC_PRIZES);
 
         HTTPFirebase.GET("/prizes", activity,
                 HackTheNorthApplication.Actions.SYNC_PRIZES);
@@ -87,7 +87,7 @@ public void onResume() {
     }
 
     @Override
-    protected void handleJSONUpdateInBackground(final String json) {
+    protected void handleJSONUpdateInBackground(final String json, String action) {
         final Activity activity = getActivity();
         new AsyncTask<Void, Void, Void>(){
             @Override

android/src/main/java/com/hackthenorth/android/ui/ScheduleFragment.java

@@ -69,7 +69,7 @@ public void onAttach(Activity activity) {
         mAdapter.setFragment(this);
 
         // Register for updates
-        registerForSync(activity, HackTheNorthApplication.Actions.SYNC_SCHEDULE, mAdapter);
+        registerForSync(activity, HackTheNorthApplication.Actions.SYNC_SCHEDULE);
 
         HTTPFirebase.GET("/schedule", activity,
                 HackTheNorthApplication.Actions.SYNC_SCHEDULE);
@@ -113,7 +113,7 @@ public void onNegativeClick(ConfirmDialogFragment fragment) {
     }
 
     @Override
-    protected void handleJSONUpdateInBackground(final String json) {
+    protected void handleJSONUpdateInBackground(final String json, String actio) {
         final Activity activity = getActivity();
         new AsyncTask<Void, Void, Void>() {
             @Override

android/src/main/java/com/hackthenorth/android/ui/TeamFragment.java

@@ -55,7 +55,7 @@ public void onAttach(Activity activity) {
         mAdapter = new TeamFragmentAdapter(activity, R.layout.team_list_item, mData);
 
         // Register for updates
-        registerForSync(activity, HackTheNorthApplication.Actions.SYNC_TEAM, mAdapter);
+        registerForSync(activity, HackTheNorthApplication.Actions.SYNC_TEAM);
 
         HTTPFirebase.GET("/team", activity, HackTheNorthApplication.Actions.SYNC_TEAM);
     }
@@ -78,7 +78,7 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
     }
 
     @Override
-    protected void handleJSONUpdateInBackground(final String json) {
+    protected void handleJSONUpdateInBackground(final String json, String action) {
         final Activity activity = getActivity();
         new AsyncTask<Void, Void, Void>(){
             @Override

android/src/main/java/com/hackthenorth/android/ui/UpdatesFragment.java

@@ -59,7 +59,7 @@ public void onAttach(Activity activity) {
         mAdapter = new UpdatesFragmentAdapter(activity, R.layout.update_list_item, mData);
 
         // Register for updates
-        registerForSync(activity, HackTheNorthApplication.Actions.SYNC_UPDATES, mAdapter);
+        registerForSync(activity, HackTheNorthApplication.Actions.SYNC_UPDATES);
 
         HTTPFirebase.GET("/updates", activity,
                 HackTheNorthApplication.Actions.SYNC_UPDATES);
@@ -86,7 +86,7 @@ public void onResume() {
     }
 
     @Override
-    protected void handleJSONUpdateInBackground(final String json) {
+    protected void handleJSONUpdateInBackground(final String json, String action) {
         final Activity activity = getActivity();
         new AsyncTask<Void, Void, Void>() {
             @Override