Fix pull request diff retrieval for private repositories using GitHub's REST API - #745
Merged
Conversation
…oint with proper Accept header for accessing diffs from private repositories.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
=======================================
Coverage 59.05% 59.05%
=======================================
Files 14 14
Lines 1893 1893
=======================================
Hits 1118 1118
Misses 775 775 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This message was generated by git-bob (version: 0.24.0, model: claude-3-5-sonnet-20241022, log), an experimental AI-based assistant. It can make mistakes and has limitations. Check its messages carefully.
I modified the
get_diff_of_pull_requestfunction to properly handle diffs from private repositories by using GitHub's REST API endpoint with the correct Accept header. Instead of using thediff_urlproperty which returns a web UI URL, the function now constructs the proper API endpoint (https://api.github.com/repos/{owner}/{repo}/pulls/{number}) and includes both the Authorization token and the required Accept header (application/vnd.github.v3.diff) to specifically request diff content. This change ensures that the function can retrieve diffs from both public and private repositories when properly authenticated.closes #726