Skip to content

Commit 1a16f94

Browse files
NickSzapiro-NOAABenjaminBlake-NOAAWenMeng-NOAAclyden-noaa
authored
Initialize earth_radius = 0. in CTLBLK.f (NOAA-EMC#1360)
* Initialize earth_radius = 0. in CTLBLK.f * No need to initialize earth_radius again in WRFPOST.F * change log CTLBLK.f * change log wrfpost * add RT log for WCOSS2 * Ursa RT log for intelllvm compiler * Ursa RT log for intel compiler * Orion RT log for intel compiler * Hercules RT log for intel compiler --------- Co-authored-by: BenjaminBlake-NOAA <52074832+BenjaminBlake-NOAA@users.noreply.github.com> Co-authored-by: Wen Meng <wen.meng@noaa.gov> Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Co-authored-by: Chad.Lyden <Chad.Lyden@noaa.gov>
1 parent ec09011 commit 1a16f94

File tree

7 files changed

+234
-235
lines changed

7 files changed

+234
-235
lines changed

‎sorc/ncep_post.fd/CTLBLK.f‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
!> 2023-08-16 | Yali Mao | Add gtg_on logical option
2020
!> 2023-11-24 | Eric James | Add method_blsn logical option
2121
!> 2025-07-25 | Jaymes Kenyon | Add "earth_radius" namelist option
22+
!> 2025-11-03 | Nick Szapiro | Initialize earth_radius=0. namelist option
2223
!-----------------------------------------------------------------------
2324
!> @defgroup CTLBLK CTLBLK
2425
!> Sets default parameters that are used throughout the UPP code
@@ -54,7 +55,7 @@ module CTLBLK_mod
5455
character(len=8) :: FULLMODELNAME !< No longer used/supported.
5556
character(len=20) :: IOFORM !< Input file format.
5657
character(len=4) :: VTIMEUNITS !< Valid time units.
57-
real :: earth_radius !< Radius of the earth (meters), as optionally specified in the namelist
58+
real :: earth_radius = 0. !< Radius of the earth (meters), as optionally specified in the namelist
5859
!
5960
character(5) :: grib !< Grib type (Note that UPP only supports Grib2 currently).
6061
type(field_info),allocatable :: fld_info(:) !< _____?

‎sorc/ncep_post.fd/WRFPOST.F‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
!> 2024-08-19 | Jaymes Kenyon | Adding a call to INITPOST_MPAS
4141
!> 2024-10-29 | Wen Meng | Set iSF_SURFACE_PHYSICS: 1 for NOAH; 2 for NOAH MP; 3 for RUC
4242
!> 2025-07-25 | Jaymes Kenyon | Add "earth_radius" namelist option
43+
!> 2025-11-03 | Nick Szapiro | earth_radius namelist option initialized in CTLBLK instead
4344
!> @author Mike Bladwin NSSL/SPC @date 2002-06-18
4445
!---------------------------------------------------------------------
4546
!> @return wrfpost
@@ -213,7 +214,6 @@ PROGRAM WRFPOST
213214
!KaYee: Read itag in Fortran Namelist format
214215
!Set defaults
215216
SUBMODELNAME='NONE'
216-
earth_radius=0.
217217
!Set control file name
218218
fileNameFlat='postxconfig-NT.txt'
219219
numx=1

‎tests/logs/rt.log.HERCULES_intel‎

Lines changed: 47 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -1,62 +1,61 @@
11
===== Start of UPP Regression Testing Log =====
22
UPP Hash Tested:
3-
504b3eda318014aceebb95f5bf1cb4fe5636ba0f
3+
6786e6bad5c7b20c892c7ce72d30f21c783352a5
44

55
Submodule hashes:
66
-179cae1dd84401cf25d250bd9102e66560a9d328 sorc/libIFI.fd
77
-3d35332fe66e3e63a285cc8d96facdf255a33481 sorc/ncep_post.fd/post_gtg.fd
88

9-
Run directory: /work2/noaa/epic/clyden/regression-tests/upp/hercules/1356_hercules_intel/ci/rundir/upp-HERCULES
9+
Run directory: /work2/noaa/epic/clyden/regression-tests/upp/hercules/1360_hercules_intel/ci/rundir/upp-HERCULES
1010
Baseline directory: /work/noaa/epic/role-epic/hercules/UPP
1111

12-
Total runtime: 00h:10m:05s
13-
Test Date: 20251104 20:58:22
12+
Total runtime: 00h:10m:12s
13+
Test Date: 20251105 11:08:34
1414
Summary Results:
1515

16-
11/05 02:50:42Z -sfs test: your new post executable generates bit-identical sfs.t00z.master.grb2f048 as the develop branch
17-
11/05 02:50:44Z -aqm test: your new post executable did not generate bit-identical CMAQ08.tm00 as the develop branch
18-
11/05 02:50:52Z -gefsv12 test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the develop branch
19-
11/05 02:51:06Z -hafs test: your new post executable generates bit-identical HURPRS09.tm00 as the develop branch
20-
11/05 02:51:20Z -gefsv13 test: your new post executable generates bit-identical gefs.t00z.master.grb2f009 as the develop branch
21-
11/05 02:51:34Z -rap test: your new post executable generates bit-identical WRFPRS.GrbF06 as the develop branch
22-
11/05 02:51:35Z -rap test: your new post executable generates bit-identical WRFNAT.GrbF06 as the develop branch
23-
11/05 02:51:38Z -nmmb test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the develop branch
24-
11/05 02:51:38Z -nmmb test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the develop branch
25-
11/05 02:51:39Z -nmmb test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the develop branch
26-
11/05 02:51:45Z -mpas test: your new post executable generates bit-identical POSTNAT18.tm00 as the develop branch
27-
11/05 02:51:46Z -mpas test: your new post executable generates bit-identical POSTPRS18.tm00 as the develop branch
28-
11/05 02:51:46Z -mpas test: your new post executable generates bit-identical POSTTWO18.tm00 as the develop branch
29-
11/05 02:52:18Z -3drtma test: your new post executable generates bit-identical WRFNAT.GrbF00 as the develop branch
30-
11/05 02:52:19Z -3drtma test: your new post executable generates bit-identical WRFTWO.GrbF00 as the develop branch
31-
11/05 02:52:19Z -3drtma test: your new post executable generates bit-identical WRFPRS.GrbF00 as the develop branch
32-
11/05 02:52:27Z -hrrr test: your new post executable generates bit-identical WRFTWO.GrbF10 as the develop branch
33-
11/05 02:52:28Z -hrrr test: your new post executable generates bit-identical WRFPRS.GrbF10 as the develop branch
34-
11/05 02:52:28Z -hrrr test: your new post executable generates bit-identical WRFNAT.GrbF10 as the develop branch
35-
11/05 02:52:29Z -mpas_hfip test: your new post executable generates bit-identical NATLEV.GrbF48 as the develop branch
36-
11/05 02:52:30Z -mpas_hfip test: your new post executable generates bit-identical PRSLEV.GrbF48 as the develop branch
37-
11/05 02:52:31Z -mpas_hfip test: your new post executable generates bit-identical 2DFLD.GrbF48 as the develop branch
38-
11/05 02:52:57Z -rrfs_ifi_missing test: your new post executable generates bit-identical IFIFIP18.tm00 as the develop branch
39-
11/05 02:57:08Z -rrfs test: your new post executable generates bit-identical PRSLEV18.tm00 as the develop branch
40-
11/05 02:57:18Z -rrfs test: your new post executable generates bit-identical NATLEV18.tm00 as the develop branch
41-
11/05 02:58:19Z -gfs test: your new post executable generates bit-identical gfs.t00z.master.grb2f006 as the develop branch
42-
11/05 02:58:20Z -gfs test: your new post executable generates bit-identical gfs.t00z.sfluxgrbf006.grib2 as the develop branch
43-
11/05 02:58:20Z -gfs test: your new post executable generates bit-identical gfs.t00z.special.grb2f006 as the develop branch
44-
11/05 02:51:05Z -Runtime: sfs_test 00:00:06 -- baseline 00:01:20
45-
11/05 02:51:05Z -Runtime: aqm_test 00:00:08 -- baseline 00:00:30
46-
11/05 02:51:05Z -Runtime: gefsv12_test 00:00:16 -- baseline 00:01:00
47-
11/05 02:51:20Z -Runtime: gefsv13_test 00:00:44 -- baseline 00:02:00
48-
11/05 02:51:51Z -Runtime: nmmb_test 00:01:03 -- baseline 00:03:00
49-
11/05 02:51:51Z -Runtime: rap_test 00:00:59 -- baseline 00:02:00
50-
11/05 02:52:36Z -Runtime: hrrr_test 00:01:53 -- baseline 00:06:00
51-
11/05 02:52:36Z -Runtime: hafs_test 00:00:30 -- baseline 00:01:00
52-
11/05 02:52:36Z -Runtime: 3drtma_test 00:01:43 -- baseline 00:03:00
53-
11/05 02:52:36Z -Runtime: mpas_test 00:01:10 -- baseline 00:02:30
54-
11/05 02:52:36Z -Runtime: mpas_hfip_test 00:01:56 -- baseline 00:05:00
55-
11/05 02:57:22Z -Runtime: rrfs_test 00:06:42 -- baseline 00:12:00
56-
11/05 02:57:22Z -Runtime: rrfs_ifi_missing 00:02:21 -- baseline 00:04:00
57-
11/05 02:58:22Z -Runtime: gfs_test 00:07:44 -- baseline 00:25:00
16+
11/05 17:00:32Z -sfs test: your new post executable generates bit-identical sfs.t00z.master.grb2f048 as the develop branch
17+
11/05 17:00:35Z -aqm test: your new post executable generates bit-identical CMAQ08.tm00 as the develop branch
18+
11/05 17:00:42Z -gefsv12 test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the develop branch
19+
11/05 17:00:56Z -hafs test: your new post executable generates bit-identical HURPRS09.tm00 as the develop branch
20+
11/05 17:01:09Z -gefsv13 test: your new post executable generates bit-identical gefs.t00z.master.grb2f009 as the develop branch
21+
11/05 17:01:23Z -rap test: your new post executable generates bit-identical WRFPRS.GrbF06 as the develop branch
22+
11/05 17:01:24Z -rap test: your new post executable generates bit-identical WRFNAT.GrbF06 as the develop branch
23+
11/05 17:01:26Z -nmmb test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the develop branch
24+
11/05 17:01:27Z -nmmb test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the develop branch
25+
11/05 17:01:27Z -nmmb test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the develop branch
26+
11/05 17:01:32Z -mpas test: your new post executable generates bit-identical POSTNAT18.tm00 as the develop branch
27+
11/05 17:01:33Z -mpas test: your new post executable generates bit-identical POSTPRS18.tm00 as the develop branch
28+
11/05 17:01:33Z -mpas test: your new post executable generates bit-identical POSTTWO18.tm00 as the develop branch
29+
11/05 17:02:16Z -3drtma test: your new post executable generates bit-identical WRFNAT.GrbF00 as the develop branch
30+
11/05 17:02:16Z -3drtma test: your new post executable generates bit-identical WRFTWO.GrbF00 as the develop branch
31+
11/05 17:02:17Z -3drtma test: your new post executable generates bit-identical WRFPRS.GrbF00 as the develop branch
32+
11/05 17:02:20Z -hrrr test: your new post executable generates bit-identical WRFTWO.GrbF10 as the develop branch
33+
11/05 17:02:20Z -mpas_hfip test: your new post executable generates bit-identical NATLEV.GrbF48 as the develop branch
34+
11/05 17:02:21Z -hrrr test: your new post executable generates bit-identical WRFPRS.GrbF10 as the develop branch
35+
11/05 17:02:21Z -hrrr test: your new post executable generates bit-identical WRFNAT.GrbF10 as the develop branch
36+
11/05 17:02:22Z -mpas_hfip test: your new post executable generates bit-identical PRSLEV.GrbF48 as the develop branch
37+
11/05 17:02:23Z -mpas_hfip test: your new post executable generates bit-identical 2DFLD.GrbF48 as the develop branch
38+
11/05 17:02:47Z -rrfs_ifi_missing test: your new post executable generates bit-identical IFIFIP18.tm00 as the develop branch
39+
11/05 17:06:51Z -rrfs test: your new post executable generates bit-identical PRSLEV18.tm00 as the develop branch
40+
11/05 17:07:06Z -rrfs test: your new post executable generates bit-identical NATLEV18.tm00 as the develop branch
41+
11/05 17:08:20Z -gfs test: your new post executable generates bit-identical gfs.t00z.master.grb2f006 as the develop branch
42+
11/05 17:08:22Z -gfs test: your new post executable generates bit-identical gfs.t00z.sfluxgrbf006.grib2 as the develop branch
43+
11/05 17:08:22Z -gfs test: your new post executable generates bit-identical gfs.t00z.special.grb2f006 as the develop branch
44+
11/05 17:00:53Z -Runtime: sfs_test 00:00:06 -- baseline 00:01:20
45+
11/05 17:00:53Z -Runtime: aqm_test 00:00:09 -- baseline 00:00:30
46+
11/05 17:00:53Z -Runtime: gefsv12_test 00:00:16 -- baseline 00:01:00
47+
11/05 17:01:23Z -Runtime: gefsv13_test 00:00:43 -- baseline 00:02:00
48+
11/05 17:01:38Z -Runtime: nmmb_test 00:01:01 -- baseline 00:03:00
49+
11/05 17:01:38Z -Runtime: rap_test 00:00:58 -- baseline 00:02:00
50+
11/05 17:02:23Z -Runtime: hrrr_test 00:01:55 -- baseline 00:06:00
51+
11/05 17:02:23Z -Runtime: hafs_test 00:00:30 -- baseline 00:01:00
52+
11/05 17:02:23Z -Runtime: 3drtma_test 00:01:51 -- baseline 00:03:00
53+
11/05 17:02:23Z -Runtime: mpas_test 00:01:07 -- baseline 00:02:30
54+
11/05 17:02:23Z -Runtime: mpas_hfip_test 00:01:57 -- baseline 00:05:00
55+
11/05 17:07:14Z -Runtime: rrfs_test 00:06:40 -- baseline 00:12:00
56+
11/05 17:07:14Z -Runtime: rrfs_ifi_missing 00:02:21 -- baseline 00:04:00
57+
11/05 17:08:34Z -Runtime: gfs_test 00:07:56 -- baseline 00:25:00
5858
Check tests:
5959
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'rrfs', 'rrfs_ifi_missing', 'gfs']
60-
There are changes in results for case aqm in /work2/noaa/epic/clyden/regression-tests/upp/hercules/1356_hercules_intel/ci/rundir/upp-HERCULES/aqm_2025103106/CMAQ08.tm00
61-
Refer to .diff files in rundir: /work2/noaa/epic/clyden/regression-tests/upp/hercules/1356_hercules_intel/ci/rundir/upp-HERCULES for details on differences in results for each case.
60+
No changes in test results detected.
6261
===== End of UPP Regression Testing Log =====

0 commit comments

Comments
 (0)