Crash when uploading a file from seafile android app

[markusd112]

When Choosing "Add" --> "Upload file" the app crashes each time.. Several crash reports via android crash reporting has been already sent.

[markusd112]

App Version 2.2.6, Android 7.0, Moto G5 Plus

[markusd112]

The problem occurs, when choosing a file to upload from SD card. When choosing a file stored in internal memory of the smartphone, the upload works...

same thing happening to me. device Note8 Oreo

[DoS007]

Yeah, and just look at google play store comments. There are plenty, who have the same problem that upload does not work. And that problem does not exists since yesterday, but for months. Is seafile still activley developed?!

Only other option would be to move to nextcloud, but i don't want to yet. Plzz fix, uploading is crucial for an uploading and downloading app. And Android is the consumer most used plattform these days. So please please, fix it.

[freeplant]

We have fixed a few related issues that causing file uploading crash in recent versions. We will check a again.

[DoS007]

@freeplant I really, really appreciate your fast response 👍 .

Is the version, in which the few related issues are solved, the play store version at this moment? If not, when will it be published in play store?

Edit: I'm using version 2.2.8 (from playstore). And it still has a problem.

On this https://github.com/haiwen/seadroid/releases site, there is only one newer version, which doesn't fix anything according file uploading regaring realese notes.

So the problem still exists. If there is any way to help you, give you logs or something, I would be happy to help.

[Firefly1337]

@freeplant
I had some time and debugged it, this is for downloading files:
SeafConnection.java#getDownloadLink looks like the following:

HttpRequest req = prepareApiGetRequest(apiPath, params);
checkRequestResponseStatus(req, HttpURLConnection.HTTP_OK);
String result = new String(req.bytes(), "UTF-8");

String fileID = req.header("oid");
// should return "\"http://gonggeng.org:8082/...\"" or "\"https://gonggeng.org:8082/...\"
if (result.startsWith("\"http") && fileID != null) {
    String url = result.substring(1, result.length() - 1);
    return new Pair<String, String>(url, fileID);
} else {
    throw SeafException.illFormatException;
}

prepareApiGetRequest redirects to https://<url>/api2/repos/<repo-id>/file/?p=<file>&op=download which returns, at least on my server, "/seafhttp/files/<repo-id>/<file>".
That value is saved to String result.

The following check (if (result.startsWith("\"http") && fileID != null) {) will not work because it is missing the URL.
Simply adding the URL (retrievable via accounts.server) to String result will make it work.

I have not yet looked at the upload function but I suspect it might be the same issue.
I am unsure wether this is an issue with the server, the app or my specific server config. Given the fact that I am not alone it's either the seafile server or app. Probably the app.

[Firefly1337]

Found the same issue for SeafConnection.java#getUploadLink.
Added the URL and upload is working fine again.

[Firefly1337]

I created a PR for this, see #772

[freeplant]

@Firefly1337 Thanks for debugging the problem. What version of the server do you use? In our API document

GET https://cloud.seafile.com/api2/repos/{repo-id}/file/?p=/foo

should return something like

https://cloud.seafile.com:8082/files/adee6094/foo.c