Try to fix compile/test issues.

Author: mcourteaux

src/ApproximationTables.h

@@ -32,13 +32,13 @@ struct Approximation {
 };
 
 namespace ApproximationTables {
-extern const std::vector<Approximation> table_atan;
-extern const std::vector<Approximation> table_sin;
-extern const std::vector<Approximation> table_cos;
-extern const std::vector<Approximation> table_tan;
-extern const std::vector<Approximation> table_expm1;
-extern const std::vector<Approximation> table_exp;
-extern const std::vector<Approximation> table_log;
+extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_atan;
+extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_sin;
+extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_cos;
+extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_tan;
+extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_expm1;
+extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_exp;
+extern HALIDE_EXPORT_SYMBOL const std::vector<Approximation> table_log;
 
 const Approximation *best_atan_approximation(Halide::ApproximationPrecision precision, Type type);
 const Approximation *best_sin_approximation(Halide::ApproximationPrecision precision, Type type);

src/CodeGen_Metal_Dev.cpp

@@ -64,33 +64,37 @@ class CodeGen_Metal_Dev : public CodeGen_GPU_Dev {
     extern_function_name_map[x "_f16"] = y; \
     extern_function_name_map[x "_f32"] = y
             alias("sqrt", "sqrt");
-            alias("sin", "sin");
-            alias("cos", "cos");
-            alias("exp", "exp");
-            alias("log", "log");
+            alias("sin", "precise::sin");
+            alias("cos", "precise::cos");
+            alias("exp", "precise::exp");
+            alias("log", "precise::log");
             alias("abs", "fabs");  // f-prefix!
             alias("floor", "floor");
             alias("ceil", "ceil");
             alias("trunc", "trunc");
-            alias("pow", "pow");
-            alias("asin", "asin");
-            alias("acos", "acos");
-            alias("tan", "tan");
-            alias("atan", "atan");
-            alias("atan2", "atan2");
-            alias("sinh", "sinh");
-            alias("asinh", "asinh");
-            alias("cosh", "cosh");
-            alias("acosh", "acosh");
-            alias("tanh", "tanh");
-            alias("atanh", "atanh");
+            alias("pow", "precise::pow");
+            alias("asin", "precise::asin");
+            alias("acos", "precise::acos");
+            alias("tan", "precise::tan");
+            alias("atan", "precise::atan");
+            alias("atan2", "precise::atan2");
+            alias("sinh", "precise::sinh");
+            alias("asinh", "precise::asinh");
+            alias("cosh", "precise::cosh");
+            alias("acosh", "precise::acosh");
+            alias("tanh", "precise::tanh");
+            alias("atanh", "precise::atanh");
 
             alias("is_nan", "isnan");
             alias("is_inf", "isinf");
             alias("is_finite", "isfinite");
 
-            alias("fast_sin", "fast::sin");
+            alias("fast_acos", "fast::asin");
+            alias("fast_asin", "fast::asin");
+            alias("fast_atan", "fast::atan");
+            alias("fast_atan2", "fast::atan2");
             alias("fast_cos", "fast::cos");
+            alias("fast_sin", "fast::sin");
             alias("fast_tan", "fast::tan");
             alias("fast_exp", "fast::exp");
             alias("fast_log", "fast::log");

test/correctness/determine_fast_function_approximation_metrics.cpp

@@ -7,8 +7,6 @@ using namespace Halide;
 using namespace Halide::Internal;
 
 constexpr double PI = 3.14159265358979323846;
-constexpr double ONE_OVER_PI = 1.0 / PI;
-constexpr double TWO_OVER_PI = 2.0 / PI;
 constexpr double PI_OVER_TWO = PI / 2;
 constexpr double PI_OVER_FOUR = PI / 4;