Skip to content

perf: use ibm-semeru-runtimes to replace eclipse-temurin as the base image #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 24, 2023
Merged

perf: use ibm-semeru-runtimes to replace eclipse-temurin as the base image #4896

merged 4 commits into from
Nov 24, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 23, 2023

What type of PR is this?

/area core
/milestone 2.11.x
/kind improvement

What this PR does / why we need it:

使用 ibm-semeru-runtimes:open-17-jre 作为基础镜像构建 Halo 镜像，以获得更优的内存消耗。

Which issue(s) this PR fixes:

Fixes #2584

Special notes for your reviewer:

./gradlew build

docker build -t halohub/halo:openj9 .

Does this PR introduce a user-facing change?

使用 ibm-semeru-runtimes:open-17-jre 作为基础镜像构建 Halo 镜像，以获得更优的内存消耗。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/core Issues or PRs related to the Halo Core labels Nov 23, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 23, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen November 23, 2023 06:31
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Nov 23, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e97f313) 56.88% compared to head (e5dc116) 56.88%.
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #4896   +/-   ##
=========================================
  Coverage     56.88%   56.88%           
  Complexity     2975     2975           
=========================================
  Files           514      514           
  Lines         16912    16912           
  Branches       1273     1273           
=========================================
  Hits           9621     9621           
  Misses         6750     6750           
  Partials        541      541

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing
Copy link
Member

guqing commented Nov 23, 2023 •
edited
Loading

[linux/arm/v7 internal] load metadata for docker.io/library/ibm-semeru-runtimes:open-17-jre
ERROR: no match for platform in manifest: not found

由于不支持 linux/arm/v7，如果确认忽略，是否还需要先去修改 halo-sigs/actions的 https://github.com/halo-sigs/actions/blob/cc69a3cfd8911334b45c66f552e751245410b162/halo-next-docker-build/action.yaml#L28 或者修改 halo 的 workflow?

@JohnNiang
Copy link
Member

[linux/arm/v7 internal] load metadata for docker.io/library/ibm-semeru-runtimes:open-17-jre
ERROR: no match for platform in manifest: not found

由于不支持 linux/arm/v7，如果确认忽略，是否还需要先去修改 halo-sigs/actions的 https://github.com/halo-sigs/actions/blob/cc69a3cfd8911334b45c66f552e751245410b162/halo-next-docker-build/action.yaml#L28 或者修改 halo 的 workflow?

Hi @guqing ，建议在当前的 PR 中修改 platforms 参数。正好 halo-sigs/actions 近期的修改中已经提取 platforms 为参数了。

@ruibaby
Copy link
Member Author

ruibaby commented Nov 23, 2023

Hi @guqing ，建议在当前的 PR 中修改 platforms 参数。正好 halo-sigs/actions 近期的修改中已经提取 platforms 为参数了。

已添加。

@guqing
Copy link
Member

guqing commented Nov 23, 2023

um, 会 OOM 无法构建🧑‍🎤

@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2023
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2023
@JohnNiang
Add CARGO_NET_GIT_FETCH_WITH_CLI env into Dockerfile to prevent OOM e…
e5dc116 
…rror during building multi-platforms Docker image
@JohnNiang
Copy link
Member

um, 会 OOM 无法构建🧑‍🎤

Hi @guqing ，多平台构建的问题已经修复， 请参考 e5dc116。

@guqing
Copy link
Member

guqing commented Nov 24, 2023

um, 会 OOM 无法构建🧑‍🎤

Hi @guqing ，多平台构建的问题已经修复， 请参考 e5dc116。

niubility🐮

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
JohnNiang
JohnNiang approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang JohnNiang added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Nov 24, 2023
@JohnNiang JohnNiang merged commit 4ee4a8f into halo-dev:main Nov 24, 2023
@ruibaby ruibaby modified the milestones: 2.11.x, 2.11.0 Nov 24, 2023
@JohnNiang JohnNiang changed the title chore: use ibm-semeru-runtimes to replace eclipse-temurin as the base image perf: use ibm-semeru-runtimes to replace eclipse-temurin as the base image Nov 24, 2023
@JohnNiang JohnNiang mentioned this pull request Nov 28, 2023
Closed
@ruibaby ruibaby mentioned this pull request Nov 30, 2023
Closed
@ruibaby ruibaby deleted the chore/use-ibm-semeru-runtimes branch March 24, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing guqing approved these changes

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

可以采用openj9，对内存的占用比hotspot少一些
3 participants
@ruibaby @guqing @JohnNiang