feat: add Ghostty target support and improve code quality

Add Ghostty as a third theme migration target with config-based
activation, diff preview, and backup. Refactor Target dispatch into
impl methods for extensibility. Replace --no-activate with --activate
opt-in flag.

Cherry-pick quality improvements: fix strip_jsonc escaped backslash
bug, replace unwrap_or(0) with proper error handling, extract magic
numbers to constants, add tests for superset/warp/store/reader.

Code review fixes: remove dead as_rgb(), fix ghostty_config_dir panic,
harden filename sanitization, extract shared test fixture, remove
unused serde derives.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: minsoo-web

Cargo.lock

@@ -1,12 +1,12 @@
 [package]
 name = "chromaport"
-version = "0.1.0"
+version = "0.2.0"
 edition = "2021"
 description = "Migrate VS Code / Cursor themes to Superset, Warp, and more"
 license = "MIT"
 repository = "https://github.com/hamsurang/chromaport"
 homepage = "https://github.com/hamsurang/chromaport"
-keywords = ["theme", "vscode", "cursor", "superset", "warp"]
+keywords = ["theme", "vscode", "cursor", "superset", "warp", "ghostty"]
 
 [[bin]]
 name = "chromaport"
@@ -22,6 +22,8 @@ rayon = "1"
 serde = { version = "1", features = ["derive"] }
 serde_yaml_ng = "0.10"
 serde_json = "1"
+similar = { version = "2", features = ["inline"] }
+console = "0.15"
 tempfile = "3"
 
 [dev-dependencies]

Cargo.toml

@@ -1,5 +1,5 @@
 <p align="center">
-  <img src="assets/chromaport_og.png" alt="Chromaport" width="600" />
+  <img src="assets/chromaport.png" alt="Chromaport" width="600" />
 </p>
 
 # chromaport
@@ -70,17 +70,17 @@ chromaport --editor vscode --target superset --yes
 
 ## Supported editors
 
-| Editor | Path |
-|--------|------|
+| Editor  | Path                    |
+| ------- | ----------------------- |
 | VS Code | `~/.vscode/extensions/` |
-| Cursor | `~/.cursor/extensions/` |
+| Cursor  | `~/.cursor/extensions/` |
 
 ## Supported targets
 
-| Target | How it works |
-|--------|-------------|
-| Superset | Writes to `~/.superset/app-state.json` (quit Superset first) |
-| Warp | Writes to `~/.warp/themes/*.yaml` (auto-detected while running) |
+| Target   | How it works                                                    |
+| -------- | --------------------------------------------------------------- |
+| Superset | Writes to `~/.superset/app-state.json` (quit Superset first)    |
+| Warp     | Writes to `~/.warp/themes/*.yaml` (auto-detected while running) |
 
 ## How it works
 

README.md

@@ -3,7 +3,7 @@ use clap::{Parser, ValueEnum};
 #[derive(Parser)]
 #[command(
     version,
-    about = "Migrate VS Code / Cursor themes to Superset, Warp, and more",
+    about = "Migrate VS Code / Cursor themes to Superset, Warp, Ghostty, and more",
     long_about = None
 )]
 pub struct Cli {
@@ -20,8 +20,12 @@ pub struct Cli {
     #[arg(short = 'y', long)]
     pub yes: bool,
 
-    /// Do not change the active theme after import
+    /// Apply the theme to the target app's config
     #[arg(long)]
+    pub activate: bool,
+
+    /// Deprecated: themes are no longer activated by default. Use --activate instead.
+    #[arg(long, hide = true)]
     pub no_activate: bool,
 }
 
@@ -35,4 +39,5 @@ pub enum Editor {
 pub enum Target {
     Superset,
     Warp,
+    Ghostty,
 }

assets/chromaport.png

@@ -82,7 +82,8 @@ fn get_color(
             }
         }
     }
-    HexColor::parse(fallback).unwrap_or_else(|_| HexColor::parse("#000000").unwrap())
+    HexColor::parse(fallback)
+        .unwrap_or_else(|_| HexColor::parse("#000000").expect("valid hex literal"))
 }
 
 /// Chart color scopes to search for (in priority order)
@@ -132,16 +133,12 @@ fn extract_chart_colors(
                 }
             }
         }
-        result.push(HexColor::parse(fallback).unwrap());
+        result.push(HexColor::parse(fallback).expect("CHART_SCOPES fallbacks are valid hex"));
     }
 
-    [
-        result.remove(0),
-        result.remove(0),
-        result.remove(0),
-        result.remove(0),
-        result.remove(0),
-    ]
+    result
+        .try_into()
+        .expect("CHART_SCOPES has exactly 5 entries")
 }
 
 /// Convert a VS Code theme (ThemeEntry + parsed JSON) into the intermediate representation.
@@ -208,15 +205,23 @@ pub fn convert(entry: &ThemeEntry, theme_json: &Value) -> Result<ThemeIR> {
         .or_else(|| colors.get("editor.selectionBackground"))
         .and_then(|v| HexColor::parse(v).ok());
 
-    let ansi = |normal_key: &str, bright_key: &str, dk: &str, lk: &str| {
+    let ansi = |normal_key: &str, bright_key: &str, normal_default: &str, bright_default: &str| {
         let fallback = if matches!(theme_type, ThemeType::Dark) {
-            dk
+            normal_default
         } else {
-            lk
+            bright_default
         };
         (
-            get_color(colors, &[normal_key], d.get(dk).unwrap_or(&fallback)),
-            get_color(colors, &[bright_key], d.get(lk).unwrap_or(&fallback)),
+            get_color(
+                colors,
+                &[normal_key],
+                d.get(normal_default).unwrap_or(&fallback),
+            ),
+            get_color(
+                colors,
+                &[bright_key],
+                d.get(bright_default).unwrap_or(&fallback),
+            ),
         )
     };
 

src/cli.rs

@@ -5,6 +5,8 @@ use anyhow::Result;
 use inquire::{InquireError, MultiSelect, Select};
 use std::io::IsTerminal;
 
+const THEME_LIST_PAGE_SIZE: usize = 12;
+
 pub fn is_tty() -> bool {
     std::io::stdin().is_terminal()
 }
@@ -23,7 +25,10 @@ pub fn select_editor(available: &[(Editor, String)]) -> Result<usize> {
         .prompt()
         .map_err(handle_inquire_error)?;
 
-    Ok(options.iter().position(|o| o == &selected).unwrap_or(0))
+    options
+        .iter()
+        .position(|o| o == &selected)
+        .ok_or_else(|| anyhow::anyhow!("selected item not found in options"))
 }
 
 /// Let user select one or more themes to migrate.
@@ -56,7 +61,7 @@ pub fn select_themes(themes: &[ThemeEntry], active_id: Option<&str>) -> Result<V
         .collect();
 
     let selected = MultiSelect::new("Select themes to migrate:", options.clone())
-        .with_page_size(12)
+        .with_page_size(THEME_LIST_PAGE_SIZE)
         .prompt()
         .map_err(handle_inquire_error)?;
 
@@ -83,19 +88,22 @@ pub fn select_target(available: &[Target]) -> Result<Target> {
 
     if available.len() == 1 {
         let t = available[0].clone();
-        println!("Target: {} (auto-detected)", target_name(&t));
+        println!("Target: {} (auto-detected)", t.display_name());
         return Ok(t);
     }
 
     let options: Vec<String> = available
         .iter()
-        .map(|t| target_name(t).to_string())
+        .map(|t| t.display_name().to_string())
         .collect();
     let selected = Select::new("Select target app:", options.clone())
         .prompt()
         .map_err(handle_inquire_error)?;
 
-    let idx = options.iter().position(|o| o == &selected).unwrap_or(0);
+    let idx = options
+        .iter()
+        .position(|o| o == &selected)
+        .ok_or_else(|| anyhow::anyhow!("selected item not found in options"))?;
     Ok(available[idx].clone())
 }
 
@@ -116,16 +124,20 @@ pub fn select_active(irs: &[ThemeIR]) -> Result<Option<String>> {
     if selected == keep {
         Ok(None)
     } else {
-        let idx = options.iter().position(|o| o == &selected).unwrap_or(0);
+        let idx = options
+            .iter()
+            .position(|o| o == &selected)
+            .ok_or_else(|| anyhow::anyhow!("selected item not found in options"))?;
         Ok(irs.get(idx).map(|ir| ir.id.clone()))
     }
 }
 
-fn target_name(t: &Target) -> &'static str {
-    match t {
-        Target::Superset => "Superset",
-        Target::Warp => "Warp",
-    }
+pub fn confirm_activate() -> Result<bool> {
+    let answer = inquire::Confirm::new("Apply this change?")
+        .with_default(false)
+        .prompt()
+        .map_err(handle_inquire_error)?;
+    Ok(answer)
 }
 
 fn handle_inquire_error(e: InquireError) -> anyhow::Error {

src/converter.rs

@@ -149,6 +149,22 @@ pub struct AnsiPalette {
     pub white: HexColor,
 }
 
+impl AnsiPalette {
+    /// Returns palette colors indexed from `offset` (0 for normal, 8 for bright).
+    pub fn as_indexed(&self, offset: u8) -> [(u8, &HexColor); 8] {
+        [
+            (offset, &self.black),
+            (offset + 1, &self.red),
+            (offset + 2, &self.green),
+            (offset + 3, &self.yellow),
+            (offset + 4, &self.blue),
+            (offset + 5, &self.magenta),
+            (offset + 6, &self.cyan),
+            (offset + 7, &self.white),
+        ]
+    }
+}
+
 #[derive(Debug, Clone)]
 pub struct AnsiColors {
     pub normal: AnsiPalette,
@@ -181,3 +197,53 @@ pub struct ThemeIR {
     // Terminal ANSI
     pub terminal: AnsiColors,
 }
+
+#[cfg(test)]
+pub(crate) mod test_fixtures {
+    use super::*;
+
+    pub fn make_test_ir() -> ThemeIR {
+        let hex = |s: &str| HexColor::parse(s).unwrap();
+        let palette = || AnsiPalette {
+            black: hex("#000000"),
+            red: hex("#FF0000"),
+            green: hex("#00FF00"),
+            yellow: hex("#FFFF00"),
+            blue: hex("#0000FF"),
+            magenta: hex("#FF00FF"),
+            cyan: hex("#00FFFF"),
+            white: hex("#FFFFFF"),
+        };
+        ThemeIR {
+            id: "test-theme".to_string(),
+            name: "Test Theme".to_string(),
+            theme_type: ThemeType::Dark,
+            background: hex("#1E1E1E"),
+            foreground: hex("#D4D4D4"),
+            accent: hex("#0078D4"),
+            cursor: hex("#D4D4D4"),
+            selection_bg: hex("#264F78"),
+            border: hex("#3E3E3E"),
+            sidebar_bg: hex("#252526"),
+            sidebar_fg: hex("#CCCCCC"),
+            input_bg: hex("#3C3C3C"),
+            muted_fg: hex("#858585"),
+            chart_colors: [
+                hex("#E06C75"),
+                hex("#98C379"),
+                hex("#61AFEF"),
+                hex("#C678DD"),
+                hex("#56B6C2"),
+            ],
+            terminal: AnsiColors {
+                normal: palette(),
+                bright: palette(),
+                background: hex("#1E1E1E"),
+                foreground: hex("#D4D4D4"),
+                cursor: hex("#D4D4D4"),
+                cursor_accent: None,
+                selection_bg: Some(hex("#264F78")),
+            },
+        }
+    }
+}