Fix for #70, #73 (isolation level issues) and ordering #69

Author: Vytautas Kasparavičius

src/Hangfire.PostgreSql/Hangfire.PostgreSql.csproj

@@ -14,9 +14,9 @@
     <PackageReleaseNotes>https://github.com/frankhommers/Hangfire.PostgreSql/releases</PackageReleaseNotes>
     <PackageProjectUrl>http://hmm.rs/Hangfire.PostgreSql</PackageProjectUrl>
     <PackageLicenseUrl>https://raw.github.com/frankhommers/Hangfire.PostgreSql/master/LICENSE.md</PackageLicenseUrl>
-    <Version>1.4.7.1</Version>
-    <FileVersion>1.4.7.1</FileVersion>
-    <AssemblyVersion>1.4.7.1</AssemblyVersion>
+    <Version>1.4.8</Version>
+    <FileVersion>1.4.8.0</FileVersion>
+    <AssemblyVersion>1.4.8.0</AssemblyVersion>
   </PropertyGroup>
 
   <ItemGroup>

src/Hangfire.PostgreSql/PostgreSqlConnection.cs

@@ -324,14 +324,26 @@ SELECT 1
 	AND ""updatedrows"".""field"" = ""insertvalues"".""field""
 );
 ";
-
-			using (var transaction = _connection.BeginTransaction(IsolationLevel.Serializable))
+			var execute = true;
+			while (execute)
 			{
-				foreach (var keyValuePair in keyValuePairs)
+				try
+				{
+					using (var transaction = _connection.BeginTransaction(IsolationLevel.Serializable))
+					{
+						foreach (var keyValuePair in keyValuePairs)
+						{
+							_connection.Execute(sql, new {key = key, field = keyValuePair.Key, value = keyValuePair.Value}, transaction);
+						}
+						transaction.Commit();
+						execute = false;
+					}
+				}
+				catch (PostgresException exception)
 				{
-					_connection.Execute(sql, new { key = key, field = keyValuePair.Key, value = keyValuePair.Value }, transaction);
+					if (!exception.SqlState.Equals("40001"))
+						throw;
 				}
-				transaction.Commit();
 			}
 		}
 

src/Hangfire.PostgreSql/PostgreSqlMonitoringApi.cs

@@ -536,7 +536,7 @@ private JobList<TDto> GetJobs<TDto>(NpgsqlConnection connection, int @from, int
 FROM """ + _options.SchemaName + @""".""job"" j
 LEFT JOIN """ + _options.SchemaName + @""".""state"" s ON j.""stateid"" = s.""id""
 WHERE j.""statename"" = @stateName 
-ORDER BY j.""id""
+ORDER BY j.""id"" DESC
 LIMIT @count OFFSET @start;
 ";
 

tests/Hangfire.PostgreSql.Tests/Hangfire.PostgreSql.Tests.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <AssemblyTitle>Hangfire.PostgreSql.Tests</AssemblyTitle>
-    <TargetFramework>netcoreapp1.0</TargetFramework>
+    <TargetFramework>netcoreapp1.1</TargetFramework>
     <AssemblyName>Hangfire.PostgreSql.Tests</AssemblyName>
     <PackageId>Hangfire.PostgreSql.Tests</PackageId>
     <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>

tests/Hangfire.PostgreSql.Tests/PostgreSqlConnectionFacts.cs

@@ -3,7 +3,9 @@
 using System.Data;
 using System.Globalization;
 using System.Linq;
+using System.Runtime.InteropServices.ComTypes;
 using System.Threading;
+using System.Threading.Tasks;
 using Dapper;
 using Hangfire.Common;
 using Hangfire.Server;
@@ -786,6 +788,22 @@ public void SetRangeInHash_MergesAllRecords()
 			});
 		}
 
+		[Fact, CleanDatabase]
+		public void SetRangeInHash_DoesNotThrowSerializationException()
+		{
+			Parallel.For(1, 1000, (i) =>
+			{
+				UseConnection((connection2) =>
+				{
+					connection2.SetRangeInHash("some-hash", new Dictionary<string, string>
+					{
+						{"Key1", "Value1"},
+						{"Key2", "Value2"}
+					});
+				});
+			});
+		}
+
 		[Fact, CleanDatabase]
 		public void GetAllEntriesFromHash_ThrowsAnException_WhenKeyIsNull()
 		{