Merge pull request #243 from frankhommers/features/lower-loglevel-serialization-failure-when-locking

frankhommers · web-flow · commit aec47768863c · 2022-02-11T18:45:51.000+02:00
Changed serialization failure when acquiring lock to debug log level
diff --git a/src/Hangfire.PostgreSql/PostgreSqlDistributedLock.cs b/src/Hangfire.PostgreSql/PostgreSqlDistributedLock.cs
@@ -25,6 +25,7 @@
 using System.Threading;
 using Dapper;
 using Hangfire.Logging;
+using Npgsql;
 
 namespace Hangfire.PostgreSql
 {
@@ -34,7 +35,8 @@ public sealed class PostgreSqlDistributedLock
 
     private static void Log(string resource, string message, Exception ex)
     {
-      _logger.WarnException($"{resource}: {message}", ex);
+      bool isConcurrencyError = ex is PostgresException { SqlState: PostgresErrorCodes.SerializationFailure };
+      _logger.Log(isConcurrencyError ? LogLevel.Trace : LogLevel.Warn, () => $"{resource}: {message}", ex);
     }
 
     internal static void Acquire(IDbConnection connection, string resource, TimeSpan timeout, PostgreSqlStorageOptions options)

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@`
`25`	`25`	`using System.Threading;`
`26`	`26`	`using Dapper;`
`27`	`27`	`using Hangfire.Logging;`
	`28`	`+using Npgsql;`
`28`	`29`
`29`	`30`	`namespace Hangfire.PostgreSql`
`30`	`31`	`{`
`@@ -34,7 +35,8 @@ public sealed class PostgreSqlDistributedLock`
`34`	`35`
`35`	`36`	`private static void Log(string resource, string message, Exception ex)`
`36`	`37`	`{`
`37`		`- _logger.WarnException($"{resource}: {message}", ex);`
	`38`	`+ bool isConcurrencyError = ex is PostgresException { SqlState: PostgresErrorCodes.SerializationFailure };`
	`39`	`+ _logger.Log(isConcurrencyError ? LogLevel.Trace : LogLevel.Warn, () => $"{resource}: {message}", ex);`
`38`	`40`	`}`
`39`	`41`
`40`	`42`	`internal static void Acquire(IDbConnection connection, string resource, TimeSpan timeout, PostgreSqlStorageOptions options)`