Skip to content

Commit b154eb2

Browse files
committed
Use array as value type for job arguments column
1 parent 9004076 commit b154eb2

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

src/Hangfire.PostgreSql/PostgreSqlConnection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ public override string CreateExpiredJob(
125125
string jobId = connection.QuerySingle<long>(createJobSql,
126126
new {
127127
InvocationData = new JsonParameter(SerializationHelper.Serialize(invocationData)),
128-
Arguments = new JsonParameter(invocationData.Arguments),
128+
Arguments = new JsonParameter(invocationData.Arguments, JsonParameter.ValueType.Array),
129129
CreatedAt = createdAt,
130130
ExpireAt = createdAt.Add(expireIn),
131131
}).ToString(CultureInfo.InvariantCulture);

tests/Hangfire.PostgreSql.Tests/PostgreSqlConnectionFacts.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ public void GetJobData_ReturnsResult_WhenJobExists()
202202
new {
203203
InvocationData = new JsonParameter(SerializationHelper.Serialize(InvocationData.SerializeJob(job))),
204204
StateName = "Succeeded",
205-
Arguments = new JsonParameter("[\"\\\"Arguments\\\"\"]"),
205+
Arguments = new JsonParameter("[\"\\\"Arguments\\\"\"]", JsonParameter.ValueType.Array),
206206
});
207207

208208
JobData result = jobStorageConnection.GetJobData(jobId.ToString(CultureInfo.InvariantCulture));

tests/Hangfire.PostgreSql.Tests/PostgreSqlJobQueueFacts.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ WITH i AS (
204204
// Arrange
205205
UseConnection((connection, storage) => {
206206
connection.Execute(arrangeSql,
207-
new { InvocationData = new JsonParameter(""), Arguments = new JsonParameter(""), Queue = "default" });
207+
new { InvocationData = new JsonParameter(""), Arguments = new JsonParameter("", JsonParameter.ValueType.Array), Queue = "default" });
208208
PostgreSqlJobQueue queue = CreateJobQueue(storage, useNativeDatabaseTransactions);
209209

210210
// Act
@@ -298,8 +298,8 @@ WITH i AS (
298298
UseConnection((connection, storage) => {
299299
connection.Execute(arrangeSql,
300300
new[] {
301-
new { Queue = "default", InvocationData = new JsonParameter(""), Arguments = new JsonParameter("") },
302-
new { Queue = "default", InvocationData = new JsonParameter(""), Arguments = new JsonParameter("") },
301+
new { Queue = "default", InvocationData = new JsonParameter(""), Arguments = new JsonParameter("", JsonParameter.ValueType.Array) },
302+
new { Queue = "default", InvocationData = new JsonParameter(""), Arguments = new JsonParameter("", JsonParameter.ValueType.Array) },
303303
});
304304
PostgreSqlJobQueue queue = CreateJobQueue(storage, useNativeDatabaseTransactions);
305305

@@ -345,7 +345,7 @@ WITH i AS (
345345
PostgreSqlJobQueue queue = CreateJobQueue(storage, useNativeDatabaseTransactions);
346346

347347
connection.Execute(arrangeSql,
348-
new { Queue = "critical", InvocationData = new JsonParameter(""), Arguments = new JsonParameter("") });
348+
new { Queue = "critical", InvocationData = new JsonParameter(""), Arguments = new JsonParameter("", JsonParameter.ValueType.Array) });
349349

350350
Assert.Throws<OperationCanceledException>(() => queue.Dequeue(_defaultQueues,
351351
CreateTimingOutCancellationToken()));
@@ -383,8 +383,8 @@ WITH i AS (
383383
UseConnection((connection, storage) => {
384384
connection.Execute(arrangeSql,
385385
new[] {
386-
new { Queue = queueNames.First(), InvocationData = new JsonParameter("") , Arguments = new JsonParameter("") },
387-
new { Queue = queueNames.Last(), InvocationData = new JsonParameter(""), Arguments = new JsonParameter("") },
386+
new { Queue = queueNames.First(), InvocationData = new JsonParameter("") , Arguments = new JsonParameter("", JsonParameter.ValueType.Array) },
387+
new { Queue = queueNames.Last(), InvocationData = new JsonParameter(""), Arguments = new JsonParameter("", JsonParameter.ValueType.Array) },
388388
});
389389

390390
PostgreSqlJobQueue queue = CreateJobQueue(storage, useNativeDatabaseTransactions);

tests/Hangfire.PostgreSql.Tests/PostgreSqlMonitoringApiFacts.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public void GetJobs_MixedCasing_ReturnsJob()
3737
long jobId = connection.QuerySingle<long>(arrangeSql,
3838
new {
3939
InvocationData = new JsonParameter(SerializationHelper.Serialize(invocationData)),
40-
Arguments = new JsonParameter(invocationData.Arguments),
40+
Arguments = new JsonParameter(invocationData.Arguments, JsonParameter.ValueType.Array),
4141
});
4242

4343
Mock<IState> state = new();

0 commit comments

Comments
 (0)