Skip to content

TRACE improvements #832

Open
Open
@hannorein

Description

@hannorein

While working on the barycentric integrator, I'm stumbling across a few TRACE things which could be improved. I put them here for reference.

  • Right now, TRACE enters an infinite loop if BS fails due to a NaN occurring at some point. This could be fixed by adding a condition like r->status <= 0 to this while loop.
  • Sometimes the BS step fails for ok reasons (initial timestep too large, etc) and needs to be redone. However, even if a BS step fails, we still do a collision search. I don't think this makes sense. See this if statement.

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions