MacOS: renameExchange introduces errors in gocryptfs

[doits]

I'm not sure if this is a go-fuse error or a gocryptfs error, but gocryptfs has problems saving files on MacOS after the following commit was introduced in go-fuse: 3502146.

The whole story is in rfjakob/gocryptfs#914, the summary is:

• MacOS got problems to save files after a gocryptfs update, please see MacOS: Apps complain they cannot save existing documents starting with v2.5.0 rfjakob/gocryptfs#914 for the whole context and error description
• I traced it back to be because to a go-fuse upgrade to v2.5.0. Using v2.4.0 with the latest gocryptfs release works and does not have the bug.
• Finally i ran a manual bisect against go-fuse and found the commit that introduced the error: 3502146
• Using the latest go-fuse v2.8.0 doesn't help, the error is still present

I don't know if gocryptfs is doing something wrong with go-fuse or if go-fuse has a bug on MacOS.

I'm doing all the tests on MacOS 15.5 with macFUSE 5.0.5. Though I know the error was present with macFUSE 4.10.2 because I upgraded to 5.0.5 to see if it fixes the error (it didn't).

Is there anything I can do to help to debug and fix this? Thanks for your help!

[doits]

One more information: I tried to run the go-fuse tests with all.bash – I had to comment out go build ./... – but there are a lot of errors. Not sure if it helps.

Output of `all.bash` 86c2f38

+ uname -a
Darwin xxx.local 24.5.0 Darwin Kernel Version 24.5.0: Tue Apr 22 19:53:27 PDT 2025; root:xnu-11417.121.6~2/RELEASE_ARM64_T6041 arm64
+ GOOS=darwin
+ go build ./fs/... ./example/loopback/...
+ GOOS=freebsd
+ go build ./fs/... ./example/loopback/...
+ GO_TEST='go test -timeout 5m -p 1 -count 1'
+ go test -timeout 5m -p 1 -count 1 ./...
?       github.com/hanwen/go-fuse/v2    [no test files]
read: (g=0): rw=read, bs=(R) 128KiB-128KiB, (W) 128KiB-128KiB, (T) 128KiB-128KiB, ioengine=psync, iodepth=1
fio-3.40
Starting 1 process
read: Laying out IO file (1 file / 1024MiB)
fio: pid=0, err=13/file:filesetup.c:174, func=open, error=Permission denied


Run status group 0 (all jobs):
--- FAIL: TestBenchmarkMemFSFio (0.67s)
    mem_test.go:72: exit status 1
FAIL
FAIL    github.com/hanwen/go-fuse/v2/benchmark  1.018s
?       github.com/hanwen/go-fuse/v2/benchmark/bulkstat [no test files]
?       github.com/hanwen/go-fuse/v2/example/benchmark-read-throughput  [no test files]
?       github.com/hanwen/go-fuse/v2/example/hello      [no test files]
?       github.com/hanwen/go-fuse/v2/example/loopback   [no test files]
?       github.com/hanwen/go-fuse/v2/example/memfs      [no test files]
?       github.com/hanwen/go-fuse/v2/example/multizip   [no test files]
?       github.com/hanwen/go-fuse/v2/example/statfs     [no test files]
?       github.com/hanwen/go-fuse/v2/example/winfs      [no test files]
?       github.com/hanwen/go-fuse/v2/example/zipfs      [no test files]
# github.com/hanwen/go-fuse/v2/posixtest
posixtest/test.go:87:70: undefined: syscall.O_DIRECT
posixtest/test.go:109:37: undefined: syscall.O_DIRECT
posixtest/test.go:707:20: undefined: syscall.Fallocate
posixtest/test.go:707:48: undefined: unix.FALLOC_FL_KEEP_SIZE
posixtest/test.go:935:21: undefined: syscall.Creat
posixtest/test.go:960:23: undefined: syscall.Creat
FAIL    github.com/hanwen/go-fuse/v2/fs [build failed]
--- FAIL: TestFlagStringOrder (0.00s)
    print_test.go:23: flagString:
        have: "ASYNC_READ,SPLICE_WRITE,READDIRPLUS,MAX_PAGES"
        want: "ASYNC_READ,SPLICE_WRITE,READDIRPLUS,MAX_PAGES,EXPLICIT_INVAL_DATA"
FAIL
FAIL    github.com/hanwen/go-fuse/v2/fuse       0.366s
--- FAIL: TestMemNodeFsBasic (0.18s)
    memnode_test.go:85: Readdir got [- ._test - test], expected 1 file named 'test'
--- FAIL: TestMemNodeSetattr (0.18s)
    memnode_test.go:112: Chown: chown /var/folders/_0/qpvpcptd2yjdpqltrhjf80f40000gn/T/TestMemNodeSetattr1518233109/001/mnt/test: operation not permitted
    memnode_test.go:119: got (0, 0), want 42,21
FAIL
FAIL    github.com/hanwen/go-fuse/v2/fuse/nodefs        1.051s
ok      github.com/hanwen/go-fuse/v2/fuse/pathfs        0.690s
FAIL    github.com/hanwen/go-fuse/v2/fuse/test [build failed]
ok      github.com/hanwen/go-fuse/v2/internal   0.146s
?       github.com/hanwen/go-fuse/v2/internal/fallocate [no test files]
?       github.com/hanwen/go-fuse/v2/internal/ioctl     [no test files]
?       github.com/hanwen/go-fuse/v2/internal/openat    [no test files]
?       github.com/hanwen/go-fuse/v2/internal/renameat  [no test files]
?       github.com/hanwen/go-fuse/v2/internal/testutil  [no test files]
?       github.com/hanwen/go-fuse/v2/internal/utimens   [no test files]
?       github.com/hanwen/go-fuse/v2/internal/xattr     [no test files]
FAIL    github.com/hanwen/go-fuse/v2/newunionfs [build failed]
# github.com/hanwen/go-fuse/v2/posixtest [github.com/hanwen/go-fuse/v2/posixtest.test]
posixtest/test.go:87:70: undefined: syscall.O_DIRECT
posixtest/test.go:109:37: undefined: syscall.O_DIRECT
posixtest/test.go:707:20: undefined: syscall.Fallocate
posixtest/test.go:707:48: undefined: unix.FALLOC_FL_KEEP_SIZE
posixtest/test.go:935:21: undefined: syscall.Creat
posixtest/test.go:960:23: undefined: syscall.Creat
FAIL    github.com/hanwen/go-fuse/v2/posixtest [build failed]
--- FAIL: TestMultiZipFs (0.18s)
    multizip_test.go:70: Symlink failed: symlink /Users/xxx/svn/go-fuse/zipfs/test.zip /var/folders/_0/qpvpcptd2yjdpqltrhjf80f40000gn/T/TestMultiZipFs959182763/001/config/zipmount: permission denied
--- FAIL: TestZipFs (0.18s)
    zipfs_test.go:73: got block count 32, want 1
FAIL
FAIL    github.com/hanwen/go-fuse/v2/zipfs      1.013s
FAIL

Output of `all.bash` [v2.4.0](https://github.com/hanwen/go-fuse/releases/tag/v2.4.0)

+ GOOS=darwin
+ go build ./fuse/... ./fs/... ./example/loopback/...
+ GO_TEST='go test -timeout 5m -p 1 -count 1'
+ go test -timeout 5m -p 1 -count 1 ./...
go: downloading golang.org/x/sync v0.0.0-20201207232520-09787c993a3a
?       github.com/hanwen/go-fuse/v2    [no test files]
ok      github.com/hanwen/go-fuse/v2/benchmark  0.358s
?       github.com/hanwen/go-fuse/v2/benchmark/bulkstat [no test files]
?       github.com/hanwen/go-fuse/v2/example/benchmark-read-throughput  [no test files]
?       github.com/hanwen/go-fuse/v2/example/hello      [no test files]
?       github.com/hanwen/go-fuse/v2/example/loopback   [no test files]
?       github.com/hanwen/go-fuse/v2/example/memfs      [no test files]
?       github.com/hanwen/go-fuse/v2/example/multizip   [no test files]
?       github.com/hanwen/go-fuse/v2/example/statfs     [no test files]
?       github.com/hanwen/go-fuse/v2/example/winfs      [no test files]
?       github.com/hanwen/go-fuse/v2/example/zipfs      [no test files]
# github.com/hanwen/go-fuse/v2/posixtest
posixtest/test.go:52:70: undefined: syscall.O_DIRECT
posixtest/test.go:74:37: undefined: syscall.O_DIRECT
posixtest/test.go:310:8: v.st.Ctim undefined (type syscall.Stat_t has no field or method Ctim)
posixtest/test.go:311:6: st.Ctim undefined (type syscall.Stat_t has no field or method Ctim)
posixtest/test.go:608:21: undefined: syscall.Openat
posixtest/test.go:625:16: undefined: syscall.Fallocate
posixtest/xfstests.go:50:18: undefined: unix.Getdents
posixtest/xfstests.go:63:27: d.Off undefined (type *"golang.org/x/sys/unix".Dirent has no field or method Off)
posixtest/xfstests.go:65:19: d.Off undefined (type *"golang.org/x/sys/unix".Dirent has no field or method Off)
posixtest/xfstests.go:68:26: d.Off undefined (type *"golang.org/x/sys/unix".Dirent has no field or method Off)
posixtest/xfstests.go:68:26: too many errors
FAIL    github.com/hanwen/go-fuse/v2/fs [build failed]
ok      github.com/hanwen/go-fuse/v2/fuse       0.148s
--- FAIL: TestMemNodeFsBasic (0.18s)
    memnode_test.go:90: Readdir got [0x140003d20d0 0x140003d21a0], expected 1 file named 'test'
--- FAIL: TestMemNodeSetattr (0.18s)
    memnode_test.go:118: Chown: chown /var/folders/_0/qpvpcptd2yjdpqltrhjf80f40000gn/T/go-fuse-memnode_test2061088410/mnt/test: operation not permitted
    memnode_test.go:125: got (0, 0), want 42,21
FAIL
FAIL    github.com/hanwen/go-fuse/v2/fuse/nodefs        1.080s
ok      github.com/hanwen/go-fuse/v2/fuse/pathfs        0.689s
FAIL    github.com/hanwen/go-fuse/v2/fuse/test [build failed]
ok      github.com/hanwen/go-fuse/v2/internal   0.148s
?       github.com/hanwen/go-fuse/v2/internal/testutil  [no test files]
?       github.com/hanwen/go-fuse/v2/internal/utimens   [no test files]
FAIL    github.com/hanwen/go-fuse/v2/newunionfs [build failed]
FAIL    github.com/hanwen/go-fuse/v2/posixtest [build failed]
# github.com/hanwen/go-fuse/v2/splice [github.com/hanwen/go-fuse/v2/splice.test]
splice/pool.go:96:4: p.discard undefined (type *Pair has no field or method discard)
splice/splice.go:76:17: undefined: syscall.Pipe2
splice/splice_test.go:43:4: p.discard undefined (type *Pair has no field or method discard)
FAIL    github.com/hanwen/go-fuse/v2/splice [build failed]
--- FAIL: TestMultiZipFs (0.18s)
    multizip_test.go:71: Symlink failed: symlink /Users/xxx/svn/go-fuse/zipfs/test.zip /var/folders/_0/qpvpcptd2yjdpqltrhjf80f40000gn/T/TestMultiZipFs3379703278/001/config/zipmount: permission denied
--- FAIL: TestZipFs (0.18s)
    zipfs_test.go:73: got block count 32, want 1
FAIL
FAIL    github.com/hanwen/go-fuse/v2/zipfs      1.030s
FAIL

Output of `all.bash` [v2.5.0](https://github.com/hanwen/go-fuse/releases/tag/v2.5.0)

+ GOOS=darwin
+ go build ./fuse/... ./fs/... ./example/loopback/...
+ GO_TEST='go test -timeout 5m -p 1 -count 1'
+ go test -timeout 5m -p 1 -count 1 ./...
go: downloading github.com/kylelemons/godebug v0.0.0-20170820004349-d65d576e9348
?       github.com/hanwen/go-fuse/v2    [no test files]
ok      github.com/hanwen/go-fuse/v2/benchmark  0.394s
?       github.com/hanwen/go-fuse/v2/benchmark/bulkstat [no test files]
?       github.com/hanwen/go-fuse/v2/example/benchmark-read-throughput  [no test files]
?       github.com/hanwen/go-fuse/v2/example/hello      [no test files]
?       github.com/hanwen/go-fuse/v2/example/loopback   [no test files]
?       github.com/hanwen/go-fuse/v2/example/memfs      [no test files]
?       github.com/hanwen/go-fuse/v2/example/multizip   [no test files]
?       github.com/hanwen/go-fuse/v2/example/statfs     [no test files]
?       github.com/hanwen/go-fuse/v2/example/winfs      [no test files]
?       github.com/hanwen/go-fuse/v2/example/zipfs      [no test files]
# github.com/hanwen/go-fuse/v2/posixtest
posixtest/test.go:54:70: undefined: syscall.O_DIRECT
posixtest/test.go:76:37: undefined: syscall.O_DIRECT
posixtest/test.go:312:8: v.st.Ctim undefined (type syscall.Stat_t has no field or method Ctim)
posixtest/test.go:313:6: st.Ctim undefined (type syscall.Stat_t has no field or method Ctim)
posixtest/test.go:610:21: undefined: syscall.Openat
posixtest/test.go:627:16: undefined: syscall.Fallocate
posixtest/xfstests.go:50:18: undefined: unix.Getdents
posixtest/xfstests.go:63:27: d.Off undefined (type *"golang.org/x/sys/unix".Dirent has no field or method Off)
posixtest/xfstests.go:65:19: d.Off undefined (type *"golang.org/x/sys/unix".Dirent has no field or method Off)
posixtest/xfstests.go:68:26: d.Off undefined (type *"golang.org/x/sys/unix".Dirent has no field or method Off)
posixtest/xfstests.go:68:26: too many errors
FAIL    github.com/hanwen/go-fuse/v2/fs [build failed]
--- FAIL: TestFlagStringOrder (0.00s)
    print_test.go:19: flagString:
        have: "ASYNC_READ,SPLICE_WRITE,READDIRPLUS,MAX_PAGES"
        want: "ASYNC_READ,SPLICE_WRITE,READDIRPLUS,MAX_PAGES,EXPLICIT_INVAL_DATA"
FAIL
FAIL    github.com/hanwen/go-fuse/v2/fuse       0.152s
--- FAIL: TestMemNodeFsBasic (0.18s)
    memnode_test.go:90: Readdir got [0x140001bc270 0x140001bc1a0], expected 1 file named 'test'
--- FAIL: TestMemNodeSetattr (0.18s)
    memnode_test.go:118: Chown: chown /var/folders/_0/qpvpcptd2yjdpqltrhjf80f40000gn/T/go-fuse-memnode_test1731940988/mnt/test: operation not permitted
    memnode_test.go:125: got (0, 0), want 42,21
FAIL
FAIL    github.com/hanwen/go-fuse/v2/fuse/nodefs        1.047s
ok      github.com/hanwen/go-fuse/v2/fuse/pathfs        0.684s
FAIL    github.com/hanwen/go-fuse/v2/fuse/test [build failed]
ok      github.com/hanwen/go-fuse/v2/internal   0.145s
?       github.com/hanwen/go-fuse/v2/internal/renameat  [no test files]
?       github.com/hanwen/go-fuse/v2/internal/testutil  [no test files]
?       github.com/hanwen/go-fuse/v2/internal/utimens   [no test files]
FAIL    github.com/hanwen/go-fuse/v2/newunionfs [build failed]
# github.com/hanwen/go-fuse/v2/posixtest [github.com/hanwen/go-fuse/v2/posixtest.test]
posixtest/test.go:54:70: undefined: syscall.O_DIRECT
posixtest/test.go:76:37: undefined: syscall.O_DIRECT
posixtest/test.go:312:8: v.st.Ctim undefined (type syscall.Stat_t has no field or method Ctim)
posixtest/test.go:313:6: st.Ctim undefined (type syscall.Stat_t has no field or method Ctim)
posixtest/test.go:610:21: undefined: syscall.Openat
posixtest/test.go:627:16: undefined: syscall.Fallocate
posixtest/xfstests.go:50:18: undefined: unix.Getdents
posixtest/xfstests.go:63:27: d.Off undefined (type *"golang.org/x/sys/unix".Dirent has no field or method Off)
posixtest/xfstests.go:65:19: d.Off undefined (type *"golang.org/x/sys/unix".Dirent has no field or method Off)
posixtest/xfstests.go:68:26: d.Off undefined (type *"golang.org/x/sys/unix".Dirent has no field or method Off)
posixtest/xfstests.go:68:26: too many errors
FAIL    github.com/hanwen/go-fuse/v2/posixtest [build failed]
# github.com/hanwen/go-fuse/v2/splice [github.com/hanwen/go-fuse/v2/splice.test]
splice/pool.go:96:4: p.discard undefined (type *Pair has no field or method discard)
splice/splice.go:84:17: undefined: syscall.Pipe2
splice/splice_test.go:43:4: p.discard undefined (type *Pair has no field or method discard)
FAIL    github.com/hanwen/go-fuse/v2/splice [build failed]
--- FAIL: TestMultiZipFs (0.18s)
    multizip_test.go:71: Symlink failed: symlink /Users/xxx/svn/go-fuse/zipfs/test.zip /var/folders/_0/qpvpcptd2yjdpqltrhjf80f40000gn/T/TestMultiZipFs61142084/001/config/zipmount: permission denied
--- FAIL: TestZipFs (0.18s)
    zipfs_test.go:73: got block count 32, want 1
FAIL
FAIL    github.com/hanwen/go-fuse/v2/zipfs      1.065s
FAIL

[doits]

One more info: The provided go-fuse example loopback works and does not have the problems.