Merge pull request #3092 from AnslemHack/bug-coerceStringsWithEmptySpaces

fix: allow coercion of string booleans with trailing whitespace

Author: Marsup

lib/types/boolean.js

@@ -45,7 +45,8 @@ module.exports = Any.extend({
         }
 
         if (typeof value === 'string') {
-            const normalized = schema._flags.sensitive ? value : value.toLowerCase();
+            const trimmedValue = value.trim();
+            const normalized = schema._flags.sensitive ? trimmedValue : trimmedValue.toLowerCase();
             value = normalized === 'true' ? true : (normalized === 'false' ? false : value);
         }
 

test/types/boolean.js

@@ -31,6 +31,14 @@ describe('boolean', () => {
         ]);
     });
 
+    it('converts boolean string with trailing spaces to a boolean', () => {
+
+        Helper.validate(Joi.boolean(), [
+            ['true ', true, true],
+            ['false ', true, false]
+        ]);
+    });
+
     it('does not convert boolean string to a boolean in strict mode', () => {
 
         Helper.validate(Joi.boolean().strict(), [