Problem serializing URL classes when stringifying a value

[damusix]

Runtime

nodejs

Runtime version

22.14 and 20.15

Module version

17.13.3

Last module version without issue

No response

Used with

hapi application

Any other relevant information

When validating something with a class, the JSON validator throws an error whenever a URL instance is present.

What are you trying to achieve or the steps to reproduce?

const Joi = require('joi');

const someSchema = Joi.object({
    type: Joi.string().required(),
}).unknown(false);

const configs = [
    {
        someUrl: new URL('https://some-url.com')
    }
]

Joi.assert(
    configs,
    Joi.array().items(someSchema)
);

What was the result you got?

TypeError: Receiver must be an instance of class URL
    at URL.toJSON (node:internal/url:1136:10)
    at JSON.stringify (<anonymous>)
    at internals.safeStringify (/repos/joibug/node_modules/joi/lib/annotate.js:93:17)
    at exports.error [as annotate] (/repos/joibug/node_modules/joi/lib/annotate.js:70:29)
    at internals.assert (/repos/joibug/node_modules/joi/lib/index.js:236:78)
    at Object.assert (/repos/joibug/node_modules/joi/lib/index.js:102:19)
    at Object.<anonymous> (/repos/joibug/index.js:14:5)
    at Module._compile (node:internal/modules/cjs/loader:1554:14)
    at Object..js (node:internal/modules/cjs/loader:1706:10)
    at Module.load (node:internal/modules/cjs/loader:1289:32)

Node.js v22.14.0

What result did you expect?

/repos/joibug/node_modules/joi/lib/index.js:243
    throw error;
    ^

Error [ValidationError]: [
  {
    "someUrl": "...",
    "type" [1]: -- missing --
  }
]

[1] "[0].type" is required
    at exports.process (/repos/joibug/node_modules/joi/lib/errors.js:193:16)
    at internals.entry (/repos/joibug/node_modules/joi/lib/validator.js:250:26)
    at exports.entry (/repos/joibug/node_modules/joi/lib/validator.js:27:30)
    at internals.Base.validate (/repos/joibug/node_modules/joi/lib/base.js:548:26)
    at internals.assert (/repos/joibug/node_modules/joi/lib/index.js:225:27)
    at Object.assert (/repos/joibug/node_modules/joi/lib/index.js:102:19)
    at Object.<anonymous> (/repos/joibug/index.js:14:5)
    at Module._compile (node:internal/modules/cjs/loader:1554:14)
    at Object..js (node:internal/modules/cjs/loader:1706:10)
    at Module.load (node:internal/modules/cjs/loader:1289:32) {
  _original: [ { someUrl: '...' } ],
  details: [
    {
      message: '"[0].type" is required',
      path: [ 0, 'type' ],
      type: 'any.required',
      context: { label: '[0].type', key: 'type' }
    }
  ]
}

Node.js v22.14.0

[damusix]

Quite strangely, when I try to console.log() within Joi's serializer, I get an error upon trying to render the value to stdout

node .
key... 
node:internal/util/inspect:1111
    if (!isStackOverflowError(err)) throw err;
                                    ^

TypeError: Receiver must be an instance of class URL
    at get href (node:internal/url:947:10)
    at [nodejs.util.inspect.custom] (node:internal/url:847:21)
    at formatValue (node:internal/util/inspect:850:19)
    at formatProperty (node:internal/util/inspect:2008:11)
    at formatRaw (node:internal/util/inspect:1104:9)
    at formatValue (node:internal/util/inspect:885:10)
    at formatProperty (node:internal/util/inspect:2008:11)
    at formatArray (node:internal/util/inspect:1815:32)
    at formatRaw (node:internal/util/inspect:1100:14)
    at formatValue (node:internal/util/inspect:885:10)

Node.js v22.14.0

I'm not able to replicate this with pure NodeJS:

node
Welcome to Node.js v22.14.0.
Type ".help" for more information.
> JSON.stringify({ x: new URL('http://hello') })
'{"x":"http://hello/"}'
> JSON.stringify({ x: new URL('http://hello') })

[callmeyaz]

First of all correct your code like this:

const Joi = require('joi');

const someSchema = Joi.object({
    someUrl: Joi.string().required(),
}).unknown(false);

const configs = [
    {
        someUrl: new URL('https://some-url.com')
    }
]

Joi.assert(
    configs,
    Joi.array().items(someSchema)
);

This will give you a different error now, a more correct one.

[callmeyaz]

First of all correct your code like this:

const Joi = require('joi');

const someSchema = Joi.object({
    someUrl: Joi.string().required(),
}).unknown(false);

const configs = [
    {
        someUrl: new URL('https://some-url.com')
    }
]

Joi.assert(
    configs,
    Joi.array().items(someSchema)
);

This will give you a different error now, a more correct one.

Now you should code like this:

const Joi = require('joi');

const someSchema = Joi.object({
    someUrl: Joi.string().required(),
}).unknown(false);

const configs = [
    {
        someUrl: new URL('https://some-url.com').toString()
    }
]

Joi.assert(
    configs,
    Joi.array().items(someSchema)
);

Hope this helps