fix: json schema bugfixes#3120
Open
Marsup wants to merge 9 commits into
Open
Conversation
|
Hi @Marsup, sounds good overall (attribution, and cutting the other PR). Hopefully merging this also shrinks the diff on the bigger PR. After that I'm happy to split the rest into subsets of features, and you can tell me which ones are actually worth it for Joi given the maintenance cost (or cherry-pick them yourself as you did here). If that's the direction you have in mind, I'll open smaller PRs, just a heads up that I'll be slow to respond over the next few weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @AbdelrahmanHafez.
As your PR is too big a wall to review, I allowed myself to cherry-pick some of your work, focusing first on fixing the parts that are already present in the latest release. I don't know yet how we can cut the rest of it, but this feels like a good 1st step.
I tried to keep attribution where I could, but your name may appear on commits that don't strictly reflect what you did. Let me know if it's OK.
I hope the conflicts will be manageable.