Skip to content

fix: json schema bugfixes#3120

Open
Marsup wants to merge 9 commits into
masterfrom
fix/json-schema-bugfixes
Open

fix: json schema bugfixes#3120
Marsup wants to merge 9 commits into
masterfrom
fix/json-schema-bugfixes

Conversation

@Marsup

@Marsup Marsup commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Hi @AbdelrahmanHafez.

As your PR is too big a wall to review, I allowed myself to cherry-pick some of your work, focusing first on fixing the parts that are already present in the latest release. I don't know yet how we can cut the rest of it, but this feels like a good 1st step.

I tried to keep attribution where I could, but your name may appear on commits that don't strictly reflect what you did. Let me know if it's OK.

I hope the conflicts will be manageable.

@Marsup Marsup self-assigned this May 27, 2026
@Marsup Marsup added the bug Bug or defect label May 27, 2026
@AbdelrahmanHafez

Copy link
Copy Markdown

Hi @Marsup, sounds good overall (attribution, and cutting the other PR).

Hopefully merging this also shrinks the diff on the bigger PR. After that I'm happy to split the rest into subsets of features, and you can tell me which ones are actually worth it for Joi given the maintenance cost (or cherry-pick them yourself as you did here).

If that's the direction you have in mind, I'll open smaller PRs, just a heads up that I'll be slow to respond over the next few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug or defect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants