Merge pull request #4 from DoobleD/master

Fix CRIT error

Author: msimerson

CHANGELOG.md

@@ -1,18 +1,18 @@
 # Changelog
 
-## [1.2.0](https://github.com/haraka/haraka-plugin-mailauth/compare/v1.1.1...v1.2.0) (2024-10-02)
+## [Unreleased]
 
+### Bug Fixes
 
-### Features
+* **hook_mail:** call `params[0].address` as a property instead of a method
+* **hook_data_post:** guard against missing `txn.notes.mailauth` when `hook_mail` was not called
 
-* **autopublish:** Use release-please to publish packages to npm from now on ([77bf575](https://github.com/haraka/haraka-plugin-mailauth/commit/77bf575a32dbb35d6a4cdf4938838ea1aa7d3d3a))
+## [1.2.0](https://github.com/haraka/haraka-plugin-mailauth/compare/v1.1.1...v1.2.0) (2024-10-02)
 
+### Features
 
-### Bug Fixes
+* **autopublish:** Use release-please to publish packages to npm from now on ([77bf575](https://github.com/haraka/haraka-plugin-mailauth/commit/77bf575a32dbb35d6a4cdf4938838ea1aa7d3d3a))
 
-* **checkSpf:** Merge pull request [#3](https://github.com/haraka/haraka-plugin-mailauth/issues/3) from haraka/release-1.1.1 ([5b92485](https://github.com/haraka/haraka-plugin-mailauth/commit/5b92485fa3592645b854333c9b6a6cb7ef35449d))
-* **checkSpf:** use modern paths to connection attributes ([5b92485](https://github.com/haraka/haraka-plugin-mailauth/commit/5b92485fa3592645b854333c9b6a6cb7ef35449d))
-* **checkSpf:** use modern paths to connection attributes ([3cdff3d](https://github.com/haraka/haraka-plugin-mailauth/commit/3cdff3df09ff457f411d772b4447e846d6753f9d))
 
 ## [1.1.1](https://github.com/postalsys/haraka-plugin-mailauth/compare/v1.1.0...v1.1.1) (2024-10-02)
 

index.js

@@ -62,7 +62,7 @@ exports.hook_mail = function (next, connection, params) {
 
     // Step 1. SPF
 
-    const sender = params[0].address();
+    const sender = params[0].address;
     txn.notes.mailauth = {
         sender
     };
@@ -100,6 +100,10 @@ exports.hook_mail = function (next, connection, params) {
 async function hookDataPostAsync(stream, plugin, connection) {
     const txn = connection.transaction;
 
+    if (!txn.notes.mailauth) {
+        txn.notes.mailauth = {};
+    }
+
     // Step 2. DKIM
     let dkimResult;
     try {