Skip to content

Commit 0e1be68

Browse files
kblokclaude
andcommitted
fix: rename GetExtensionsAsync to ExtensionsAsync to match test expectations
Also fix IReadOnlyList<T> .Length -> .Count in ExtensionsTests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent b01924b commit 0e1be68

6 files changed

Lines changed: 8 additions & 8 deletions

File tree

lib/PuppeteerSharp.Tests/ExtensionsTests/ExtensionsTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ await browserWithExtension.WaitForTargetAsync(target =>
8080
target.Url.Contains(extensionId) && target.Type == TargetType.ServiceWorker);
8181

8282
var workers = await extension.WorkersAsync();
83-
Assert.That(workers.Length, Is.GreaterThan(0));
83+
Assert.That(workers.Count, Is.GreaterThan(0));
8484
}
8585

8686
[Test, PuppeteerTest("extensions.spec", "extensions", "should trigger extension action")]
@@ -124,7 +124,7 @@ await browserWithExtension.WaitForTargetAsync(target =>
124124
target.Url.Contains("popup.html") && target.Url.Contains(extensionId));
125125

126126
var pages = await extension.PagesAsync();
127-
Assert.That(pages.Length, Is.GreaterThanOrEqualTo(1));
127+
Assert.That(pages.Count, Is.GreaterThanOrEqualTo(1));
128128
Assert.That(pages.Any(p => p.Url.Contains("popup.html")), Is.True);
129129
}
130130

lib/PuppeteerSharp/Bidi/BidiBrowser.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,8 @@ await Driver.WebExtension.UninstallAsync(
205205
}
206206

207207
/// <inheritdoc/>
208-
public override Task<IReadOnlyDictionary<string, Extension>> GetExtensionsAsync()
209-
=> throw new NotSupportedException("GetExtensions is not supported in WebDriver BiDi.");
208+
public override Task<IReadOnlyDictionary<string, Extension>> ExtensionsAsync()
209+
=> throw new NotSupportedException("Extensions is not supported in WebDriver BiDi.");
210210

211211
/// <inheritdoc />
212212
public override ITarget[] Targets()

lib/PuppeteerSharp/Browser.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public abstract class Browser : IBrowser
106106
public abstract Task UninstallExtensionAsync(string id);
107107

108108
/// <inheritdoc/>
109-
public abstract Task<IReadOnlyDictionary<string, Extension>> GetExtensionsAsync();
109+
public abstract Task<IReadOnlyDictionary<string, Extension>> ExtensionsAsync();
110110

111111
/// <inheritdoc/>
112112
public async Task<IPage[]> PagesAsync(bool includeAll = false)

lib/PuppeteerSharp/Cdp/CdpBrowser.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ public override async Task UninstallExtensionAsync(string id)
223223
}
224224

225225
/// <inheritdoc/>
226-
public override async Task<IReadOnlyDictionary<string, Extension>> GetExtensionsAsync()
226+
public override async Task<IReadOnlyDictionary<string, Extension>> ExtensionsAsync()
227227
{
228228
var response = await Connection.SendAsync<ExtensionsGetExtensionsResponse>("Extensions.getExtensions")
229229
.ConfigureAwait(false);

lib/PuppeteerSharp/IBrowser.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ public interface IBrowser : IDisposable, IAsyncDisposable
337337
/// and the <c>--enable-unsafe-extension-debugging</c> flag is set.
338338
/// </summary>
339339
/// <returns>A task that resolves to a dictionary of extension ID to <see cref="Extension"/>.</returns>
340-
Task<IReadOnlyDictionary<string, Extension>> GetExtensionsAsync();
340+
Task<IReadOnlyDictionary<string, Extension>> ExtensionsAsync();
341341

342342
/// <summary>
343343
/// Creates a Chrome Devtools Protocol session attached to the browser.

lib/PuppeteerSharp/IsolatedWorld.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public override async Task<Extension> ExtensionAsync()
104104
}
105105

106106
// _worldId is the extension ID for extension worlds
107-
var extensions = await ((IPage)((CdpFrame)Frame).FrameManager.Page).Browser.GetExtensionsAsync().ConfigureAwait(false);
107+
var extensions = await ((IPage)((CdpFrame)Frame).FrameManager.Page).Browser.ExtensionsAsync().ConfigureAwait(false);
108108
extensions.TryGetValue(_worldId, out var extension);
109109
return extension;
110110
}

0 commit comments

Comments
 (0)