Commit d680c99
fix: restore VerifyInterception exception and align error handling with upstream
Remove the erroneous early-return guard (if !PageLevelInterceptionEnabled return)
that was silently swallowing calls to ContinueAsync/RespondAsync/AbortAsync when
interception was not enabled. The correct behavior, matching upstream Puppeteer,
is for VerifyInterception() to throw "Request Interception is not enabled!" so that
ShouldThrowIfInterceptionIsNotEnabled passes on Firefox BiDi.
Also align ContinueInternalAsync and RespondInternalAsync error handling with
upstream's handleError: re-throw header-validation errors (Invalid header, Unsafe
header, Expected "header", invalid argument) and silently swallow all other
WebDriverBiDiException protocol errors (cancelled request, etc.).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 564e4ce commit d680c99
1 file changed
Lines changed: 22 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | 127 | | |
133 | 128 | | |
134 | 129 | | |
| |||
172 | 167 | | |
173 | 168 | | |
174 | 169 | | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | 170 | | |
181 | 171 | | |
182 | 172 | | |
| |||
214 | 204 | | |
215 | 205 | | |
216 | 206 | | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | 207 | | |
223 | 208 | | |
224 | 209 | | |
| |||
480 | 465 | | |
481 | 466 | | |
482 | 467 | | |
483 | | - | |
484 | | - | |
485 | | - | |
| 468 | + | |
486 | 469 | | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
487 | 480 | | |
488 | 481 | | |
489 | 482 | | |
| |||
503 | 496 | | |
504 | 497 | | |
505 | 498 | | |
506 | | - | |
507 | 499 | | |
508 | 500 | | |
509 | 501 | | |
| |||
587 | 579 | | |
588 | 580 | | |
589 | 581 | | |
590 | | - | |
591 | | - | |
592 | | - | |
593 | | - | |
| 582 | + | |
594 | 583 | | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
595 | 594 | | |
596 | 595 | | |
597 | 596 | | |
| |||
0 commit comments