Commit f0dfd8d
committed
chore(bidi): no-op for upstream PR #14967 (remove intermediate object wrappers)
Upstream PR #14967 is a TypeScript-only refactor that removes `{key: value}`
destructuring wrappers from BiDi internal event emissions. In TypeScript,
those wrappers existed only to be destructured at the call site, so removing
them avoids one allocation per event.
PuppeteerSharp's equivalent wrapper classes (`ClosedEventArgs`,
`RequestEventArgs`, `BidiBrowsingContextEventArgs`, etc.) play a different
role: they are the `EventArgs` types required by the .NET
`EventHandler<TEventArgs>` pattern that the BiDi layer uses throughout.
Removing them would force a switch to `Action<T>` everywhere, which is
non-idiomatic for .NET events and would not yield the same allocation win
(an EventArgs object would still need to flow through the event handler).
No code changes needed in this PR.
Upstream: puppeteer/puppeteer#149671 parent 8e11f0b commit f0dfd8d
0 file changed
0 commit comments