Skip to content

Commit 3f38c56

Browse files
Minor improvement
1 parent f444686 commit 3f38c56

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

app/dao/sample_sql_dao.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@
1717
)
1818

1919
async def read_sample_by_id(sample_id: uuid.UUID) -> Sample | None:
20-
row = await database.fetch_one(query=READ_SAMPLE_BY_ID, values={"sample_id": str(sample_id)})
20+
row = await database.fetch_one(query=READ_SAMPLE_BY_ID, values={"sample_id": sample_id})
2121
if row:
2222
return Sample(**dict(row))
2323
else:
2424
return None
2525

2626
async def create_sample(sample: SampleCreate) -> Sample | None:
2727
sample_id: uuid.UUID = uuid.uuid4()
28-
input_dict = {"sample_id": str(sample_id), "username": sample.username}
28+
input_dict = {"sample_id": sample_id, "username": sample.username}
2929
await database.execute(query=INSERT_SAMPLE, values=input_dict)
3030
return await read_sample_by_id(sample_id)

tests_integration/dao/test_sample_sql_dao.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ async def test_sample_create_and_read():
3434
# assert_that(create_result.bool_field).is_equal_to(request.bool_field)
3535
# assert_that(create_result.float_field).is_equal_to(request.float_field)
3636
# assert_that(create_result.decimal_field).is_equal_to(request.decimal_field)
37-
assert_that(create_result.created_datetime).is_greater_than_or_equal_to(start_time)
38-
assert_that(create_result.created_datetime).is_less_than_or_equal_to(datetime.now(tz=timezone.utc) + timedelta(seconds=2))
39-
assert_that(create_result.updated_datetime).is_greater_than_or_equal_to(start_time)
40-
assert_that(create_result.updated_datetime).is_less_than_or_equal_to(datetime.now(tz=timezone.utc) + timedelta(seconds=2))
37+
assert_that(create_result.created_datetime).is_between(start_time, datetime.now(tz=timezone.utc) + timedelta(seconds=2))
38+
assert_that(create_result.updated_datetime).is_between(start_time, datetime.now(tz=timezone.utc) + timedelta(seconds=2))
4139

0 commit comments

Comments
 (0)