update sliding window logic to 3AM daily message reset

Author: fegloff

src/bot.ts

@@ -498,6 +498,19 @@ const logErrorHandler = (ex: any): void => {
   logger.error(ex)
 }
 
+// bot.command('testcleanup', async (ctx) => {
+//   await openAiBot.testCleanup(ctx as OnMessageContext)
+// })
+
+bot.command('new', async (ctx) => {
+  writeCommandLog(ctx as OnMessageContext).catch(logErrorHandler)
+  await openAiBot.onStop(ctx as OnMessageContext)
+  return await ctx.reply('Chat history reseted', {
+    parse_mode: 'Markdown',
+    message_thread_id: ctx.message?.message_thread_id
+  })
+})
+
 bot.command('more', async (ctx) => {
   writeCommandLog(ctx as OnMessageContext).catch(logErrorHandler)
   return await ctx.reply(commandsHelpText.more, {

src/helpers.ts

@@ -1,4 +1,5 @@
 import config from './config'
+import { conversationManager } from './modules/llms/utils/conversationManager'
 import { LlmModelsEnum } from './modules/llms/utils/llmModelsManager'
 import { type DalleImageSize } from './modules/llms/utils/types'
 import { type BotSessionData } from './modules/types'
@@ -26,7 +27,8 @@ export function createInitialSessionData (): BotSessionData {
       price: 0,
       usage: 0,
       isProcessingQueue: false,
-      requestQueue: []
+      requestQueue: [],
+      cleanupState: conversationManager.initializeCleanupTimes()
     },
     chatGpt: {
       model: config.llms.model,
@@ -36,7 +38,8 @@ export function createInitialSessionData (): BotSessionData {
       price: 0,
       usage: 0,
       isProcessingQueue: false,
-      requestQueue: []
+      requestQueue: [],
+      cleanupState: conversationManager.initializeCleanupTimes()
     },
     dalle: {
       numImages: config.openAi.dalle.sessionDefault.numImages,

src/modules/llms/llmsBase.ts

@@ -233,8 +233,7 @@ export abstract class LlmsBase implements PayableBot {
 
   async onChatRequestHandler (ctx: OnMessageContext | OnCallBackQueryData, stream: boolean, usesTools: boolean): Promise<void> {
     const session = this.getSession(ctx)
-    session.chatConversation = conversationManager.manageConversationWindow(session.chatConversation)
-
+    session.chatConversation = conversationManager.manageConversationWindow(session.chatConversation, ctx, this.sessionDataKey)
     while (session.requestQueue.length > 0) {
       try {
         const msg = session.requestQueue.shift()
@@ -478,6 +477,49 @@ export abstract class LlmsBase implements PayableBot {
     session.price = 0
   }
 
+  async testCleanup (ctx: OnMessageContext | OnCallBackQueryData): Promise<void> {
+    const session = this.getSession(ctx)
+    // Force cleanup times for testing
+    const now = new Date()
+    const forcedCleanupTime = new Date(now)
+    forcedCleanupTime.setHours(2, 59, 0, 0) // Set to 2:59 AM
+    session.cleanupState = {
+      nextCleanupTime: forcedCleanupTime.getTime() + (60 * 1000), // 3 AM
+      lastCleanupTime: forcedCleanupTime.getTime() - (24 * 60 * 60 * 1000) // Yesterday 2:59 AM
+    }
+    console.log('Testing cleanup with forced times:', {
+      nextCleanup: new Date(session.cleanupState.nextCleanupTime).toLocaleString(),
+      lastCleanup: new Date(session.cleanupState.lastCleanupTime).toLocaleString(),
+      currentTime: now.toLocaleString()
+    })
+    // Add some test messages with various timestamps
+    if (session.chatConversation.length === 0) {
+      const yesterday = new Date(now)
+      yesterday.setDate(yesterday.getDate() - 1)
+      session.chatConversation = [
+        {
+          role: 'user',
+          content: 'Message from 2 days ago',
+          model: 'test',
+          timestamp: yesterday.getTime() - (24 * 60 * 60 * 1000)
+        },
+        {
+          role: 'assistant',
+          content: 'Message from yesterday',
+          model: 'test',
+          timestamp: yesterday.getTime()
+        },
+        {
+          role: 'user',
+          content: 'Message from today',
+          model: 'test',
+          timestamp: now.getTime()
+        }
+      ]
+    }
+    await this.onChatRequestHandler(ctx, false, false)
+  }
+
   async onError (
     ctx: OnMessageContext | OnCallBackQueryData,
     e: any,

src/modules/llms/utils/conversationManager.ts

@@ -1,41 +1,106 @@
-import { type VisionContent, type ChatConversation } from '../../types'
-
-const MINUTE_IN_MS = 60000 // 1 minute in milliseconds
-const INACTIVE_THRESHOLD = 5 * MINUTE_IN_MS // 5 minutes
-const IDLE_THRESHOLD = MINUTE_IN_MS // 1 minute
-const IDLE_MESSAGE_LIMIT = 5
-
-// const HOUR_IN_MS = 3600000 // 1 hour in milliseconds
-// const INACTIVE_THRESHOLD = 12 * HOUR_IN_MS // 12 hours
-// const IDLE_THRESHOLD = HOUR_IN_MS // 1 hour
-// const IDLE_MESSAGE_LIMIT = 5
-
-// Utility functions
-export const conversationManager = {
-  manageConversationWindow (conversation: ChatConversation[]): ChatConversation[] {
-    console.log('fco::::::: here', conversation.length)
-    if (conversation.length === 0) return conversation
+import {
+  type VisionContent,
+  type ChatConversation,
+  type OnMessageContext,
+  type OnCallBackQueryData,
+  type ConversationManagerState,
+  type BotSessionData,
+  type LlmsSessionData,
+  type ImageGenSessionData
+} from '../../types'
+
+// Constants for time calculations
+const MS_PER_DAY = 24 * 60 * 60 * 1000
+const CLEANUP_HOUR = 3 // 3 AM cleanup time
+
+const getSession = (ctx: OnMessageContext | OnCallBackQueryData, sessionDataKey: string):
+LlmsSessionData & ImageGenSessionData => {
+  return ctx.session[sessionDataKey as keyof BotSessionData] as LlmsSessionData & ImageGenSessionData
+}
+
+const conversationManager = {
+  /**
+   * Initialize or update cleanup timestamps
+   */
+  initializeCleanupTimes (): ConversationManagerState {
+    const now = new Date()
+    const today3AM = new Date(now)
+    today3AM.setHours(CLEANUP_HOUR, 0, 0, 0)
+
+    if (now.getTime() >= today3AM.getTime()) {
+      // If current time is past 3 AM, set next cleanup to tomorrow 3 AM
+      return {
+        nextCleanupTime: today3AM.getTime() + MS_PER_DAY,
+        lastCleanupTime: today3AM.getTime()
+      }
+    } else {
+      // If current time is before 3 AM, set next cleanup to today 3 AM
+      return {
+        nextCleanupTime: today3AM.getTime(),
+        lastCleanupTime: today3AM.getTime() - MS_PER_DAY
+      }
+    }
+  },
+
+  /**
+   * Check if cleanup is needed based on context
+   */
+  needsCleanup (ctx: OnMessageContext | OnCallBackQueryData, sessionDataKey: string): boolean {
     const now = Date.now()
-    const lastMessageTime = conversation[conversation.length - 1].timestamp
-    const timeDifference = now - lastMessageTime
-    // Case 1: Inactive conversation (>12 hours) - Reset
-    if (timeDifference > INACTIVE_THRESHOLD) {
-      return []
+    const session = getSession(ctx, sessionDataKey)
+
+    // Initialize times if not set
+    if (!session.cleanupState || session.cleanupState.nextCleanupTime === 0) {
+      session.cleanupState = this.initializeCleanupTimes()
     }
 
-    // Case 2: Idle conversation (>1 hour) - Keep last 5 messages
-    if (timeDifference > IDLE_THRESHOLD) {
-      return conversation.slice(-IDLE_MESSAGE_LIMIT)
+    // Check if we've passed the next cleanup time
+    if (now >= session.cleanupState.nextCleanupTime) {
+      // Update cleanup times in session
+      session.cleanupState = {
+        lastCleanupTime: session.cleanupState.nextCleanupTime,
+        nextCleanupTime: session.cleanupState.nextCleanupTime + MS_PER_DAY
+      }
+      return true
+    }
+
+    return false
+  },
+
+  /**
+   * Manage conversation window with context-aware cleanup
+   */
+  manageConversationWindow (conversation: ChatConversation[], ctx: OnMessageContext | OnCallBackQueryData, sessionDataKey: string): ChatConversation[] {
+    if (conversation.length === 0) return conversation
+
+    // Only perform cleanup if needed
+    if (this.needsCleanup(ctx, sessionDataKey)) {
+      const session = getSession(ctx, sessionDataKey)
+      return conversation.filter(msg => msg.timestamp >= session.cleanupState.lastCleanupTime)
     }
 
-    // Case 3: Active conversation (<1 hour) - Keep full history
     return conversation
   },
 
-  addMessageWithTimestamp (message: Omit<ChatConversation, 'timestamp'> | Partial<Omit<ChatConversation, 'content' | 'timestamp'>> & { content: string | VisionContent[] }): ChatConversation {
+  /**
+   * Add a new message to the conversation with current timestamp
+   */
+  addMessageWithTimestamp (
+    message: Omit<ChatConversation, 'timestamp'> |
+    Partial<Omit<ChatConversation, 'content' | 'timestamp'>> &
+    { content: string | VisionContent[] },
+    ctx: OnMessageContext | OnCallBackQueryData
+  ): ChatConversation {
+    // Initialize times if not set
+    if (!ctx.session.llms.cleanupState || ctx.session.llms.cleanupState.nextCleanupTime === 0) {
+      ctx.session.llms.cleanupState = this.initializeCleanupTimes()
+    }
+
     return {
       ...message,
       timestamp: Date.now()
     }
   }
 }
+
+export { conversationManager }

src/modules/types.ts

@@ -85,6 +85,11 @@ export interface promptRequest {
   commandPrefix?: string
 }
 
+export interface ConversationManagerState {
+  lastCleanupTime: number
+  nextCleanupTime: number
+}
+
 export interface LlmsSessionData {
   model: string
   isEnabled: boolean
@@ -94,6 +99,7 @@ export interface LlmsSessionData {
   price: number
   requestQueue: ChatConversation[]
   isProcessingQueue: boolean
+  cleanupState: ConversationManagerState
 }
 
 export interface OneCountryData {