call discover context cancel function to avoid a context leak

GheisMohammadi · GheisMohammadi · commit 2d6143f617c1 · 2025-06-09T21:42:22.000+08:00
diff --git a/p2p/stream/common/streammanager/streammanager.go b/p2p/stream/common/streammanager/streammanager.go
@@ -504,7 +504,11 @@ func (sm *streamManager) discover(ctx context.Context) (<-chan libp2p_peer.AddrI
 		return nil, nil
 	}
 
-	ctx2, _ := context.WithTimeout(ctx, discTimeout)
+	ctx2, cancel := context.WithTimeout(ctx, discTimeout)
+	go func() { // avoid context leak
+		<-time.After(discTimeout)
+		cancel()
+	}()
 	return sm.pf.FindPeers(ctx2, string(sm.myProtoID), discBatch)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -504,7 +504,11 @@ func (sm *streamManager) discover(ctx context.Context) (<-chan libp2p_peer.AddrI`
`504`	`504`	`return nil, nil`
`505`	`505`	`}`
`506`	`506`
`507`		`- ctx2, _ := context.WithTimeout(ctx, discTimeout)`
	`507`	`+ ctx2, cancel := context.WithTimeout(ctx, discTimeout)`
	`508`	`+ go func() { // avoid context leak`
	`509`	`+ <-time.After(discTimeout)`
	`510`	`+ cancel()`
	`511`	`+ }()`
`508`	`512`	`return sm.pf.FindPeers(ctx2, string(sm.myProtoID), discBatch)`
`509`	`513`	`}`
`510`	`514`