You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tier 1 of a codebase modernization pass. These are low-risk, mechanical changes with no behavior impact. They should all land in a single commit/PR.
Scope
Fix broken install_requires in setup.py:21-23 — missing comma silently concatenates 'numpy >1.22.0' 'scikit-learn >1.0.0' into one string, so scikit-learn is never pinned. (Already flagged by users in Install problem and some question #32.)
Remove unused imports
ComplexityData.py:5-8: sys, functools.wraps, time, datetime
calc_density.py, calc_proximity.py, coicog.py: unused pandas as pd
Convert remaining .format() to f-string — ComplexityData.py:161
Replace print() with logging / warnings — ecomplexity.py:103,176, proximity.py:52. Libraries shouldn't write to stdout unconditionally; verbose flag should control a logger.
Drop class Foo(object) — ComplexityData.py:11. Python 3 implies object.
Remove commented-out print calls in coicog.py:17,23.
Non-goals
No behavior changes, no API changes, no type hints, no packaging migration. Those are separate tiers.
Acceptance
pip install -e . succeeds and correctly pins scikit-learn.
All existing outputs identical (verify by running the README example and diffing against a saved reference if we can capture one — see the companion tests issue).
Tier 1 of a codebase modernization pass. These are low-risk, mechanical changes with no behavior impact. They should all land in a single commit/PR.
Scope
install_requiresinsetup.py:21-23— missing comma silently concatenates'numpy >1.22.0' 'scikit-learn >1.0.0'into one string, so scikit-learn is never pinned. (Already flagged by users in Install problem and some question #32.)ComplexityData.py:5-8:sys,functools.wraps,time,datetimecalc_density.py,calc_proximity.py,coicog.py: unusedpandas as pdproximity.py:3-4: duplicatecalc_proximityimports== False/== Truewith boolean idiomscalc_proximity.py:22,25ecomplexity.py:203,210,215proximity.py:70,74,76.format()to f-string —ComplexityData.py:161print()withlogging/warnings—ecomplexity.py:103,176,proximity.py:52. Libraries shouldn't write to stdout unconditionally;verboseflag should control a logger.class Foo(object)—ComplexityData.py:11. Python 3 impliesobject.printcalls incoicog.py:17,23.Non-goals
No behavior changes, no API changes, no type hints, no packaging migration. Those are separate tiers.
Acceptance
pip install -e .succeeds and correctly pins scikit-learn.