fix(webhook): return err when the ns label on nad is missing

Signed-off-by: Zespre Chang <[email protected]>
(cherry picked from commit 54275d2)

Author: starbops

pkg/webhook/vmnetcfg/validator.go

@@ -45,7 +45,13 @@ func (v *Validator) Create(request *admission.Request, newObj runtime.Object) er
 		}
 		ipPoolNamespace, ok := nad.Labels[util.IPPoolNamespaceLabelKey]
 		if !ok {
-			ipPoolNamespace = nadNamespace
+			return fmt.Errorf(
+				webhook.CreateErr,
+				vmNetCfg.Kind,
+				vmNetCfg.Namespace,
+				vmNetCfg.Name,
+				fmt.Errorf("%s label not found", util.IPPoolNamespaceLabelKey),
+			)
 		}
 		ipPoolName, ok := nad.Labels[util.IPPoolNameLabelKey]
 		if !ok {

pkg/webhook/vmnetcfg/validator_test.go

@@ -121,6 +121,19 @@ func TestValidator_Create(t *testing.T) {
 				shouldErr: true,
 			},
 		},
+		{
+			name: "nad referenced has incomplete labels set to associate with the target ippool",
+			given: input{
+				vmNetCfg: newTestVirtualMachineNetworkConfigBuilder().
+					WithNetworkConfig("", "", testNetworkName).Build(),
+				ipPool: newTestIPPoolBuilder().Build(),
+				nad: newTestNetworkAttachmentDefinitionBuilder().
+					Label(util.IPPoolNameLabelKey, testIPPoolName).Build(),
+			},
+			expected: output{
+				shouldErr: true,
+			},
+		},
 	}
 
 	nadGVR := schema.GroupVersionResource{